Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | testing poor behavior of hash serialization | Aaron Patterson | 2010-09-22 | 1 | -0/+4 | |
| | ||||||
* | Remove helper methods that were moved to helper.rb | Emilio Tagua | 2010-09-21 | 1 | -15/+0 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | serialized attributes should be serialized before validation [#5525 ↵ | Aaron Patterson | 2010-09-07 | 1 | -1/+5 | |
| | | | | state:resolved] | |||||
* | order should always be concatenated. | Neeraj Singh | 2010-09-05 | 1 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | order that is declared first has highest priority in all cases. Here are some examples. Car.order('name desc').find(:first, :order => 'id').name Car.named_scope_with_order.named_scope_with_another_order Car.order('id DESC').scoping do Car.find(:first, :order => 'id asc') end No special treatment to with_scope or scoping. Also note that if default_scope declares an order then the order declared in default_scope has the highest priority unless with_exclusive_scope is used. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Reset default scope in Thread.current when class is unloaded [#5497 ↵ | Andrew White | 2010-09-01 | 1 | -0/+15 | |
| | | | | | | state:resolved] Signed-off-by: Xavier Noria <fxn@hashref.com> | |||||
* | Memoize STI class lookups for the duration of a request | Jeremy Kemper | 2010-08-19 | 1 | -1/+1 | |
| | ||||||
* | Both tests are using the same model, move the model to another file and add ↵ | Santiago Pastorino | 2010-08-14 | 1 | -13/+14 | |
| | | | | the missing require | |||||
* | bringing over latest from master | Brian Lopez | 2010-08-09 | 1 | -542/+0 | |
|\ | ||||||
| * | Making Active Record base_test.rb thinner by moving tests | Neeraj Singh | 2010-08-03 | 1 | -532/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | to relevant files. Number of assertions before refactoring: 2391 tests, 7579 assertions, 0 failures, 0 errors Number of assertions after refactoring: 2391 tests, 7579 assertions, 0 failures, 0 errors Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | | skip the before_type_cast_on_datetime test entirely for mysql2 | Brian Lopez | 2010-08-02 | 1 | -17/+18 | |
| | | ||||||
* | | update tests for mysql2 support | Brian Lopez | 2010-08-02 | 1 | -4/+13 | |
|/ | ||||||
* | Test for behaviour of befeore_type_cast when operating on datetime colmun | Łukasz Strzałkowski | 2010-07-19 | 1 | -0/+8 | |
| | ||||||
* | Removed warnings when a variable is shadowed | Łukasz Strzałkowski | 2010-07-19 | 1 | -2/+2 | |
| | ||||||
* | moving persistence related tests to a new file | Neeraj Singh | 2010-07-16 | 1 | -327/+0 | |
| | | | | | | | | | | Before refactoring test result from AR: 2291 tests, 7180 assertions, 0 failures, 0 errors After the refactoring test result from AR: 2291 tests, 7180 assertions, 0 failures, 0 errors Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Revert "Style fixes" | Pratik Naik | 2010-07-15 | 1 | -3/+1 | |
| | | | | This reverts commit 3c300b31219f2af3ecd46ef22b04e5c5548db899. | |||||
* | Style fixes | wycats | 2010-07-14 | 1 | -1/+3 | |
| | ||||||
* | Style fixes | Pratik Naik | 2010-07-14 | 1 | -3/+1 | |
| | ||||||
* | Return from ActiveRecord::Base#attributes= unless value is a hash [#4070 ↵ | David Trasbo | 2010-07-08 | 1 | -0/+7 | |
| | | | | | | state:committed] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | This patch changes update_attribute implementatino so: | Neeraj Singh | 2010-07-08 | 1 | -0/+40 | |
| | | | | | | | | | | - it will only save the attribute it has been asked to save and not all dirty attributes - it does not invoke callbacks - it does change updated_at/on Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | fix ActiveRecord `destroy_all` so it returns destroyed records | Mislav Marohnić | 2010-07-08 | 1 | -6/+14 | |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | mass_assignment_security moved from AR to AMo, and minor test cleanup | Josh Kalderimis | 2010-07-08 | 1 | -1/+1 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | minor changes to mass assignment security patch to bring it in line with ↵ | Josh Kalderimis | 2010-07-08 | 1 | -125/+1 | |
| | | | | | | rails standards Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Mass assignment security refactoring | Eric Chapweske | 2010-07-08 | 1 | -13/+13 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Remove ActiveRecord::Base#class_name [#379 state:committed] | David Trasbo | 2010-06-29 | 1 | -19/+0 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | adding column named 'group' to ensure that nothing breaks given that 'group' ↵ | Neeraj Singh | 2010-06-23 | 1 | -1/+1 | |
| | | | | | | | | is sql reserved word [#4945 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Don't clone associations [#4894 state:resolved] | Paul Gillard | 2010-06-23 | 1 | -0/+8 | |
| | | | | | | Cloning an active record object should be shallow in that it should copy attributes but not associations. This was no longer true as a result of #3164. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | remove executable permission from files that don't need it. [#4802 ↵ | rohit | 2010-06-20 | 1 | -0/+0 | |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | ActiveRecord and ActionPack now use the new descendants implementation. | José Valim | 2010-06-19 | 1 | -4/+0 | |
| | ||||||
* | Fix ActiveRecord::Base.compute_type swallowing NoMethodError. [#4751 ↵ | Andrew Bloomgarden | 2010-06-08 | 1 | -0/+17 | |
| | | | | | | state:resolved] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | |||||
* | Explicitly set Topic model last_read attribute as Date value when Oracle ↵ | Raimonds Simanovskis | 2010-06-04 | 1 | -3/+4 | |
| | | | | | | enhanced adapter is used (otherwise some tests are failing which assume that this attribute will have Date value) | |||||
* | move counter_cache tests to a separate file and refactor | Mislav Marohnić | 2010-05-24 | 1 | -49/+0 | |
| | ||||||
* | Use better assertion methods for testing | Neeraj Singh | 2010-05-19 | 1 | -25/+25 | |
| | | | | | | [#4645 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | AR::Base#clone fixed to set dirty bits for cloned object | pleax | 2010-05-16 | 1 | -0/+50 | |
| | | | | | | [#2919 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Reset quoted_table_name after set_table_name [#4568 state:resolved] | Santiago Pastorino | 2010-05-15 | 1 | -0/+12 | |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Fix unintuitive behavior with multiple order and group clauses | Ernie Miller | 2010-05-06 | 1 | -0/+10 | |
| | | | | | | [#4545 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Move several configuration values from Hash to ActiveSupport::XmlMini, which ↵ | José Valim | 2010-04-29 | 1 | -4/+1 | |
| | | | | | | both Hash and Array depends on. Also, refactored ActiveModel serializers to just use ActiveSupport::XmlMini.to_tag. As consequence, if a serialized attribute is an array or a hash, it's not encoded as yaml, but as a hash or array. | |||||
* | making yaml tests less specific to emitter. [#4425 state:resolved] | Aaron Patterson | 2010-04-17 | 1 | -1/+2 | |
| | | | | Signed-off-by: wycats <wycats@gmail.com> | |||||
* | fix a failure and some warnings on 1.9.2 [#4417 state:resolved] | Aaron Patterson | 2010-04-16 | 1 | -1/+1 | |
| | | | | Signed-off-by: Xavier Noria <fxn@hashref.com> | |||||
* | Refactor compute_type to handle situations where the correct class is ↵ | Andrew White | 2010-04-12 | 1 | -8/+0 | |
| | | | | | | already loaded Signed-off-by: wycats <wycats@gmail.com> | |||||
* | make ActiveRecord::Base.subclasses a public method | Emmanuel Oga | 2010-04-12 | 1 | -0/+4 | |
| | | | | Signed-off-by: wycats <wycats@gmail.com> | |||||
* | table_name_prefix and table_name_suffix are class_attributes instead of ↵ | Phil Smith | 2010-04-12 | 1 | -7/+51 | |
| | | | | | | cattr_accessors. [#4230] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | cleaning up a bunch of parse time warnings in AR [#4186 state:resolved] | Aaron Patterson | 2010-03-15 | 1 | -9/+9 | |
| | | | | Signed-off-by: wycats <wycats@gmail.com> | |||||
* | fixed a 'RecordNotFound' bug when calling 'reload' on a object which doesn't ↵ | Tobias Bielohlawek | 2010-02-26 | 1 | -0/+6 | |
| | | | | | | | | met the default_scope conditions, added test [#3166 status:resolved] The reload method didn't made use of 'with_exclusive_scope' when reloading the object. This lead to a RecordNotFound exception, in case the object doesn't met the default_scope condition (anymore) - which is obviously a bug. This quick fix makes use of with_exclusive_scope in the reload method as well. See test for full example. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Require persisted? in ActiveModel::Lint and remove new_record? and ↵ | José Valim | 2010-02-21 | 1 | -5/+17 | |
| | | | | destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not. | |||||
* | Make merging of order values consistent | Pratik Naik | 2010-01-17 | 1 | -1/+3 | |
| | ||||||
* | Deprecate ActiveRecord::Base.colorize_logging. | José Valim | 2010-01-13 | 1 | -1/+1 | |
| | ||||||
* | Changed ActiveRecord::Base.store_full_sti_class to be true by default ↵ | David Heinemeier Hansson | 2010-01-03 | 1 | -0/+3 | |
| | | | | reflecting the previously announced Rails 3 default [DHH] | |||||
* | Simplify repair_validations on AR and make it work with new callbacks. | José Valim | 2010-01-01 | 1 | -1/+4 | |
| | ||||||
* | Don't publicize with_scope for tests since it may shadow public misuse | Jeremy Kemper | 2009-12-28 | 1 | -9/+9 | |
| | ||||||
* | Make Model.all return an array rather than a relation for consistency. Use ↵ | Pratik Naik | 2009-12-27 | 1 | -1/+7 | |
| | | | | Model.scoped to get a relation |