Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix indent in PG array tests | Carlos Antonio da Silva | 2013-12-19 | 1 | -5/+5 |
| | | | | [ci skip] | ||||
* | Merge pull request #13395 from kuldeepaggarwal/postgres-table-ref-regex | Carlos Antonio da Silva | 2013-12-19 | 1 | -0/+12 |
|\ | | | | | modified regex for finding table_name from a multiline sql query in postgresql | ||||
| * | Fix PostgreSQL insert to properly extract table name from multiline string SQL. | Kuldeep Aggarwal | 2013-12-19 | 1 | -0/+12 |
| | | | | | | | | | | | | | | | | | | | | | | | | Previously, executing an insert SQL in PostgreSQL with a command like this: insert into articles( number) values( 5152 ) would not work because the adapter was unable to extract the correct articles table name. | ||||
* | | Fix PostgreSQL range tests | Matthew Draper | 2013-12-19 | 1 | -11/+11 |
|/ | | | | The changes in c4044b2 meant the tests would error on a fresh DB. | ||||
* | support creating temporary tables from queries | Cody Cutrer | 2013-12-14 | 1 | -0/+9 |
| | | | | | also override drop_table in AbstractMySQLAdapter to properly drop temporary tables without committing the transaction | ||||
* | refactor, reuse assertions in range_test.rb. | Yves Senn | 2013-12-13 | 1 | -186/+111 |
| | |||||
* | extract PG range tests from datatype_test.rb into range_test.rb | Yves Senn | 2013-12-13 | 2 | -282/+320 |
| | |||||
* | Fix warnings on mysql2 explain test | Carlos Antonio da Silva | 2013-12-10 | 1 | -3/+3 |
| | |||||
* | Merge pull request #13248 from yahonda/support_mysql573_explain | Jeremy Kemper | 2013-12-09 | 1 | -3/+3 |
|\ | | | | | Support MySQL 5.7 explain | ||||
| * | Support MySQL 5.7 explain | Yasuo Honda | 2013-12-10 | 1 | -3/+3 |
| | | |||||
* | | Remove `DEFAULT NULL` for primary key column to support MySQL 5.7.3 | Yasuo Honda | 2013-12-10 | 2 | -6/+6 |
|/ | | | | Since MySQL 5.7.3 m13 does now allow primary key column is null. | ||||
* | Merge pull request #13054 from senny/remove_oracle_tests | Yves Senn | 2013-11-27 | 1 | -17/+0 |
|\ | | | | | Remove leftover Oracle tests. | ||||
| * | the oracle adapter lives in a gem. Tests should live there as well. | Yves Senn | 2013-11-26 | 1 | -17/+0 |
| | | |||||
* | | remove leftover firebird adapter tests. | Yves Senn | 2013-11-26 | 3 | -148/+0 |
|/ | |||||
* | `rename_index`: add the new index before removing the old one. | Yves Senn | 2013-11-26 | 1 | -6/+19 |
| | | | | | | | | | | | This prevents the following error when a MySQL index on a foreign key column is renamed: ``` ActiveRecord::StatementInvalid: Mysql2::Error: Cannot drop index 'index_engines_on_car_id': needed in a foreign key constraint: DROP INDEX `index_engines_on_car_id` ON `engines` ``` refs: #13038. | ||||
* | Merge pull request #12779 from ↵ | Aaron Patterson | 2013-11-15 | 2 | -0/+10 |
|\ | | | | | | | | | dougbarth/dont_swallow_exceptions_during_transactional_statements_in_mysql Don't swallow exceptions in transctional statements | ||||
| * | Remove tests for not swallowing exceptions. | Doug Barth | 2013-11-15 | 2 | -42/+0 |
| | | | | | | | | From PR, @tenderlove would prefer to not maintain these tests. | ||||
| * | Don't swallow exceptions in transctional statements | Doug Barth | 2013-11-05 | 2 | -0/+52 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The MySQL connection adapater swallows all StandardError exceptions, which includes Mysql::Error and Mysql2::Error. The comment in the exception clause claims errors thrown here indicate that transactions aren't supported by the server but that isn't necessarily true. It's possible the MySQL server has gone away and swallowing a failed commit may let the application return a successful response when the data has not been saved. Also, replication libraries like Galera require that the application handle exceptions thrown at BEGIN/COMMIT. I'm unable to determine what version of MySQL threw an exception for transactional statements. I tried as far back as 3.23.49 with InnoDB disabled but BEGIN & COMMIT statements do not throw an error. If there's a real case for this logic to continue, we could instead push this behavior into a configuration setting. The exception swallowing has been there since the beginning: db045dbbf60b53dbe013ef25554fd013baf88134 | ||||
* | | Unifies mysql and mysql2 casting of booleans. | Yves Senn | 2013-11-11 | 1 | -3/+3 |
| | | |||||
* | | test cases to describe the MySQL boolean behavior. | Yves Senn | 2013-11-11 | 1 | -0/+91 |
| | | |||||
* | | Don't skip tests if we don't need to. | Rafael Mendonça França | 2013-11-08 | 9 | -452/+434 |
| | | | | | | | | | | | | | | We can conditional define the tests depending on the adapter or connection. Lets keep the skip for fail tests that need to be fixed. | ||||
* | | Warning removed for ruby-head | Rashmi Yadav | 2013-11-07 | 1 | -1/+1 |
|/ | |||||
* | short arrays in inspect | Jan Bernacki | 2013-10-30 | 1 | -0/+5 |
| | |||||
* | Merge pull request #12643 from severin/pg_cast_json_on_write | Yves Senn | 2013-10-25 | 1 | -0/+7 |
|\ | | | | | cast json values on write to be consistent with reading from the db. | ||||
| * | cast json values on write to be consistent with reading from the db. | Severin Schoepke | 2013-10-25 | 1 | -0/+7 |
| | | | | | | | | See also commit 5ac2341fab689344991b2a4817bd2bc8b3edac9d | ||||
* | | Merge pull request #12633 from senny/no_more_time_zone_leaks | Yves Senn | 2013-10-25 | 1 | -25/+15 |
|\ \ | |/ |/| | prevent global timezone state from leaking out of test cases. | ||||
| * | prevent global timezone state from leaking out of test cases. | Yves Senn | 2013-10-25 | 1 | -25/+15 |
| | | |||||
* | | `ActiveRecord::Store` works together with PG `hstore` columns. | Yves Senn | 2013-10-25 | 1 | -0/+21 |
| | | | | | | | | | | | | This is necessary because as of 5ac2341 `hstore` columns are always stored as `Hash` with `String` keys. `ActiveRecord::Store` expected the attribute to be an instance of `HashWithIndifferentAccess`, which led to the bug. | ||||
* | | test to verify the `ActiveRecord::Store` behavior with PG's json type | Yves Senn | 2013-10-25 | 1 | -0/+18 |
|/ | |||||
* | Dump the default function when the primary key is uuid | Rafael Mendonça França | 2013-10-14 | 1 | -2/+2 |
| | | | | Fixes #12489 | ||||
* | log the statement name along with the SQL | Aaron Patterson | 2013-10-04 | 1 | -0/+10 |
| | |||||
* | stop adding singleton methods to the SQLite3 connection | Aaron Patterson | 2013-10-04 | 1 | -11/+11 |
| | |||||
* | stop adding singleton methods to the mysql2 adapter | Aaron Patterson | 2013-10-04 | 2 | -22/+7 |
| | |||||
* | stop adding singleton methods to the PG connection | Aaron Patterson | 2013-10-04 | 1 | -11/+26 |
| | |||||
* | Merge pull request #12315 from gaurish/super | Rafael Mendonça França | 2013-09-23 | 1 | -26/+28 |
|\ | | | | | TypeError: superclass mismatch for class PostgreSQLAdapter | ||||
| * | We shouldn't override PostgreSQLAdapter's superclass inheritance while ↵ | Gaurish Sharma | 2013-09-23 | 1 | -26/+28 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | monkeypatching Changing Inheritance section leads to following error on JRuby TypeError: superclass mismatch for class PostgreSQLAdapter After this change, Jruby: The above error no longer appear. Tests are still failing but they do run. Progress! MRI: No change, all green(tested by running take test_test_postgresql) Thanks to Aditya Sanghi(@asanghi) for help | ||||
* | | Merge pull request #11382 from kennyj/fix_10751-2 | Rafael Mendonça França | 2013-09-22 | 1 | -0/+1 |
|\ \ | | | | | | | | | | | | | | | | | | | Dump UUID default functions to schema.rb [2nd version]. Fixes #10751. Conflicts: activerecord/CHANGELOG.md | ||||
| * | | Migration dump UUID default functions to schema.rb. Fixes #10751. | kennyj | 2013-07-10 | 1 | -0/+1 |
| | | | |||||
* | | | Merge pull request #10500 from kennyj/fix_10450 | Rafael Mendonça França | 2013-09-22 | 1 | -0/+40 |
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | Fixed a bug in when using has_many association with :inverse_of option and UUID primary key. Conflicts: activerecord/CHANGELOG.md | ||||
| * | | Fixed a bug in when using has_many association with :inverse_of option and ↵ | kennyj | 2013-05-08 | 1 | -0/+40 |
| | | | | | | | | | | | | UUID primary key. | ||||
* | | | Test that PostgreSQL adapter includes `usec` when quoting `DateTime` | Ben Cherry | 2013-08-28 | 1 | -0/+5 |
| | | | |||||
* | | | PG adapter deals with negative money values formatted with parenthesis. | Yves Senn | 2013-08-26 | 1 | -0/+8 |
| | | | | | | | | | | | | Closes #11899. | ||||
* | | | Stop interpreting SQL 'string' columns as :string type. | Ben Woosley | 2013-08-17 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | SQL doesn't have a string type, and interpreting 'string' as text is contrary to at least SQLite3's behavior: "Note that a declared type of 'STRING' has an affinity of NUMERIC, not TEXT." http://www.sqlite.org/datatype3.html | ||||
* | | | Merge pull request #11574 from jetthoughts/11552_rescue_on_invalid_inet_assign | Yves Senn | 2013-08-14 | 1 | -0/+14 |
|\ \ \ | | | | | | | | | Fix assign ip address with invalid values raise exception | ||||
| * | | | Rescue invalid ip address exceptions on assign. | Paul Nikitochkin | 2013-08-14 | 1 | -0/+14 |
| | | | | | | | | | | | | | | | | In order that set attribute should not be bang method | ||||
* | | | | Removed redundant asserts for assigns attribute operation | Paul Nikitochkin | 2013-08-14 | 1 | -28/+28 |
|/ / / | |||||
* | | | using assert_not instead of refute | Rajarshi Das | 2013-08-13 | 1 | -3/+3 |
| | | | |||||
* | | | cast hstore values on write to be consistent with reading from the db. | Yves Senn | 2013-08-08 | 1 | -0/+7 |
| | | | |||||
* | | | Fix multidimensional PG arrays containing non-string items | Yves Senn | 2013-08-07 | 1 | -14/+19 |
| | | | |||||
* | | | test to express that we can't turn non-array columns to array columns. | Yves Senn | 2013-08-06 | 1 | -0/+9 |
| | | | | | | | | | | | | Closes #11062 |