diff options
author | Aaron Patterson <aaron.patterson@gmail.com> | 2013-10-04 15:16:49 -0700 |
---|---|---|
committer | Aaron Patterson <aaron.patterson@gmail.com> | 2013-10-04 15:16:49 -0700 |
commit | 6828ae7779c0ff1be321408027851b73a964593b (patch) | |
tree | a749939fc3bf0db99d12ba79633073fd18cd2dad /activerecord/test/cases/adapters | |
parent | cc04a4a9037cc91684a99a69d031c04bad1a1467 (diff) | |
download | rails-6828ae7779c0ff1be321408027851b73a964593b.tar.gz rails-6828ae7779c0ff1be321408027851b73a964593b.tar.bz2 rails-6828ae7779c0ff1be321408027851b73a964593b.zip |
stop adding singleton methods to the mysql2 adapter
Diffstat (limited to 'activerecord/test/cases/adapters')
-rw-r--r-- | activerecord/test/cases/adapters/mysql2/connection_test.rb | 14 | ||||
-rw-r--r-- | activerecord/test/cases/adapters/postgresql/connection_test.rb | 15 |
2 files changed, 7 insertions, 22 deletions
diff --git a/activerecord/test/cases/adapters/mysql2/connection_test.rb b/activerecord/test/cases/adapters/mysql2/connection_test.rb index fedd9f603c..679c515e8c 100644 --- a/activerecord/test/cases/adapters/mysql2/connection_test.rb +++ b/activerecord/test/cases/adapters/mysql2/connection_test.rb @@ -3,14 +3,14 @@ require "cases/helper" class MysqlConnectionTest < ActiveRecord::TestCase def setup super + @subscriber = SQLSubscriber.new + ActiveSupport::Notifications.subscribe('sql.active_record', @subscriber) @connection = ActiveRecord::Base.connection - @connection.extend(LogIntercepter) - @connection.intercepted = true end def teardown - @connection.intercepted = false - @connection.logged = [] + ActiveSupport::Notifications.unsubscribe(@subscriber) + super end def test_no_automatic_reconnection_after_timeout @@ -72,14 +72,14 @@ class MysqlConnectionTest < ActiveRecord::TestCase def test_logs_name_show_variable @connection.show_variable 'foo' - assert_equal "SCHEMA", @connection.logged[0][1] + assert_equal "SCHEMA", @subscriber.logged[0][1] end def test_logs_name_rename_column_sql @connection.execute "CREATE TABLE `bar_baz` (`foo` varchar(255))" - @connection.logged = [] + @subscriber.logged.clear @connection.send(:rename_column_sql, 'bar_baz', 'foo', 'foo2') - assert_equal "SCHEMA", @connection.logged[0][1] + assert_equal "SCHEMA", @subscriber.logged[0][1] ensure @connection.execute "DROP TABLE `bar_baz`" end diff --git a/activerecord/test/cases/adapters/postgresql/connection_test.rb b/activerecord/test/cases/adapters/postgresql/connection_test.rb index f482a36d86..59d95d1293 100644 --- a/activerecord/test/cases/adapters/postgresql/connection_test.rb +++ b/activerecord/test/cases/adapters/postgresql/connection_test.rb @@ -5,21 +5,6 @@ module ActiveRecord class NonExistentTable < ActiveRecord::Base end - class SQLSubscriber - attr_reader :logged - - def initialize - @logged = [] - end - - def start(name, id, payload) - @logged << [payload[:sql], payload[:name], payload[:binds]] - end - - def finish(name, id, payload) - end - end - def setup super @subscriber = SQLSubscriber.new |