aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/adapters
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #13054 from senny/remove_oracle_testsYves Senn2013-11-271-17/+0
|\ | | | | Remove leftover Oracle tests.
| * the oracle adapter lives in a gem. Tests should live there as well.Yves Senn2013-11-261-17/+0
| |
* | remove leftover firebird adapter tests.Yves Senn2013-11-263-148/+0
|/
* `rename_index`: add the new index before removing the old one.Yves Senn2013-11-261-6/+19
| | | | | | | | | | | This prevents the following error when a MySQL index on a foreign key column is renamed: ``` ActiveRecord::StatementInvalid: Mysql2::Error: Cannot drop index 'index_engines_on_car_id': needed in a foreign key constraint: DROP INDEX `index_engines_on_car_id` ON `engines` ``` refs: #13038.
* Merge pull request #12779 from ↵Aaron Patterson2013-11-152-0/+10
|\ | | | | | | | | dougbarth/dont_swallow_exceptions_during_transactional_statements_in_mysql Don't swallow exceptions in transctional statements
| * Remove tests for not swallowing exceptions.Doug Barth2013-11-152-42/+0
| | | | | | | | From PR, @tenderlove would prefer to not maintain these tests.
| * Don't swallow exceptions in transctional statementsDoug Barth2013-11-052-0/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The MySQL connection adapater swallows all StandardError exceptions, which includes Mysql::Error and Mysql2::Error. The comment in the exception clause claims errors thrown here indicate that transactions aren't supported by the server but that isn't necessarily true. It's possible the MySQL server has gone away and swallowing a failed commit may let the application return a successful response when the data has not been saved. Also, replication libraries like Galera require that the application handle exceptions thrown at BEGIN/COMMIT. I'm unable to determine what version of MySQL threw an exception for transactional statements. I tried as far back as 3.23.49 with InnoDB disabled but BEGIN & COMMIT statements do not throw an error. If there's a real case for this logic to continue, we could instead push this behavior into a configuration setting. The exception swallowing has been there since the beginning: db045dbbf60b53dbe013ef25554fd013baf88134
* | Unifies mysql and mysql2 casting of booleans.Yves Senn2013-11-111-3/+3
| |
* | test cases to describe the MySQL boolean behavior.Yves Senn2013-11-111-0/+91
| |
* | Don't skip tests if we don't need to.Rafael Mendonça França2013-11-089-452/+434
| | | | | | | | | | | | | | We can conditional define the tests depending on the adapter or connection. Lets keep the skip for fail tests that need to be fixed.
* | Warning removed for ruby-headRashmi Yadav2013-11-071-1/+1
|/
* short arrays in inspectJan Bernacki2013-10-301-0/+5
|
* Merge pull request #12643 from severin/pg_cast_json_on_writeYves Senn2013-10-251-0/+7
|\ | | | | cast json values on write to be consistent with reading from the db.
| * cast json values on write to be consistent with reading from the db.Severin Schoepke2013-10-251-0/+7
| | | | | | | | See also commit 5ac2341fab689344991b2a4817bd2bc8b3edac9d
* | Merge pull request #12633 from senny/no_more_time_zone_leaksYves Senn2013-10-251-25/+15
|\ \ | |/ |/| prevent global timezone state from leaking out of test cases.
| * prevent global timezone state from leaking out of test cases.Yves Senn2013-10-251-25/+15
| |
* | `ActiveRecord::Store` works together with PG `hstore` columns.Yves Senn2013-10-251-0/+21
| | | | | | | | | | | | This is necessary because as of 5ac2341 `hstore` columns are always stored as `Hash` with `String` keys. `ActiveRecord::Store` expected the attribute to be an instance of `HashWithIndifferentAccess`, which led to the bug.
* | test to verify the `ActiveRecord::Store` behavior with PG's json typeYves Senn2013-10-251-0/+18
|/
* Dump the default function when the primary key is uuidRafael Mendonça França2013-10-141-2/+2
| | | | Fixes #12489
* log the statement name along with the SQLAaron Patterson2013-10-041-0/+10
|
* stop adding singleton methods to the SQLite3 connectionAaron Patterson2013-10-041-11/+11
|
* stop adding singleton methods to the mysql2 adapterAaron Patterson2013-10-042-22/+7
|
* stop adding singleton methods to the PG connectionAaron Patterson2013-10-041-11/+26
|
* Merge pull request #12315 from gaurish/superRafael Mendonça França2013-09-231-26/+28
|\ | | | | TypeError: superclass mismatch for class PostgreSQLAdapter
| * We shouldn't override PostgreSQLAdapter's superclass inheritance while ↵Gaurish Sharma2013-09-231-26/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | monkeypatching Changing Inheritance section leads to following error on JRuby TypeError: superclass mismatch for class PostgreSQLAdapter After this change, Jruby: The above error no longer appear. Tests are still failing but they do run. Progress! MRI: No change, all green(tested by running take test_test_postgresql) Thanks to Aditya Sanghi(@asanghi) for help
* | Merge pull request #11382 from kennyj/fix_10751-2Rafael Mendonça França2013-09-221-0/+1
|\ \ | | | | | | | | | | | | | | | | | | Dump UUID default functions to schema.rb [2nd version]. Fixes #10751. Conflicts: activerecord/CHANGELOG.md
| * | Migration dump UUID default functions to schema.rb. Fixes #10751.kennyj2013-07-101-0/+1
| | |
* | | Merge pull request #10500 from kennyj/fix_10450Rafael Mendonça França2013-09-221-0/+40
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | Fixed a bug in when using has_many association with :inverse_of option and UUID primary key. Conflicts: activerecord/CHANGELOG.md
| * | Fixed a bug in when using has_many association with :inverse_of option and ↵kennyj2013-05-081-0/+40
| | | | | | | | | | | | UUID primary key.
* | | Test that PostgreSQL adapter includes `usec` when quoting `DateTime`Ben Cherry2013-08-281-0/+5
| | |
* | | PG adapter deals with negative money values formatted with parenthesis.Yves Senn2013-08-261-0/+8
| | | | | | | | | | | | Closes #11899.
* | | Stop interpreting SQL 'string' columns as :string type.Ben Woosley2013-08-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | SQL doesn't have a string type, and interpreting 'string' as text is contrary to at least SQLite3's behavior: "Note that a declared type of 'STRING' has an affinity of NUMERIC, not TEXT." http://www.sqlite.org/datatype3.html
* | | Merge pull request #11574 from jetthoughts/11552_rescue_on_invalid_inet_assignYves Senn2013-08-141-0/+14
|\ \ \ | | | | | | | | Fix assign ip address with invalid values raise exception
| * | | Rescue invalid ip address exceptions on assign.Paul Nikitochkin2013-08-141-0/+14
| | | | | | | | | | | | | | | | In order that set attribute should not be bang method
* | | | Removed redundant asserts for assigns attribute operationPaul Nikitochkin2013-08-141-28/+28
|/ / /
* | | using assert_not instead of refuteRajarshi Das2013-08-131-3/+3
| | |
* | | cast hstore values on write to be consistent with reading from the db.Yves Senn2013-08-081-0/+7
| | |
* | | Fix multidimensional PG arrays containing non-string itemsYves Senn2013-08-071-14/+19
| | |
* | | test to express that we can't turn non-array columns to array columns.Yves Senn2013-08-061-0/+9
| | | | | | | | | | | | Closes #11062
* | | Create sqlite3 directory if not presentschneems2013-08-051-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the `db/` directory is not present on a remote machine it will blow up in unexpected ways with error messages that do not indicate there is a missing directory: ``` SQLite3::CantOpenException: unable to open database file ``` This PR checks to see if a directory exists for the sqlite3 file and if not creates it for you. This PR is an alternative to #11692 as suggested by @josevalim
* | | fix for postgresql failing test in localKarunakar (Ruby)2013-08-041-1/+1
| | |
* | | Merge pull request #11455 from antonio/fix_enable_extension_not_being_definedRafael Mendonça França2013-08-022-0/+24
|\ \ \ | | | | | | | | Define enable_extension method to prevent undefined method error
| * | | Define enable_extension method to prevent undefined method errorAntonio Santos2013-08-022-0/+24
| | |/ | |/| | | | | | | | | | | | | | | | When mixing postgresql and another adapter like sqlite3 (for dev and test respectively), the task `db:test:prepare` will fail due to the `enable_extension` method not being defined in the abstract adapter. This patch simply adds an empty definition to prevent it.
* | | Use assert_nil instead of testing for equalityCarlos Antonio da Silva2013-08-021-2/+1
| | |
* | | Removed redundant xml override from pg adapterPaul Nikitochkin2013-08-021-0/+39
| | | | | | | | | | | | Closes: #11706
* | | Cleanup of class_nameAnkit Gupta2013-07-282-2/+2
| | | | | | | | | | | | Don't think class name is needed as by default belongs_to :select will be linked to Select class.
* | | Revert "Merge pull request #11120 from awilliams/ar_mysql2_boolean_quoting"Yves Senn2013-07-171-25/+0
| | | | | | | | | | | | | | | This reverts commit cb1d07e43926bcec95cb8b4a663ca9889173395a, reversing changes made to 754a373e301d2df0b12a11083405252722bc8366.
* | | Unifies mysql and mysql2 casting of booleansawilliams2013-07-161-0/+25
| | | | | | | | | | | | | | | Using the mysql2 adapter, boolean values were sometimes being incorrectly cast to 't' or 'f'. This changes the cast to match the mysql adapter behavior, ie 1 and 0.
* | | `change_column` for PG adapter respects `:array` option.Yves Senn2013-07-161-0/+12
|/ /
* | Remove deprecated SchemaStatements#distinctFrancesco Rodriguez2013-07-021-46/+0
| |