| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Fix prepared statements disabled test again | Prathamesh Sonpatki | 2016-11-20 | 1 | -22/+0 |
| | | | | | | | | | | | | | | | | | | | - Due to `assert_nothing_raised` this test was not really testing anything. - So updated it to assert that the query gives expected result. - Also in general we can use `connection.unprepared_statement` for testing queries w/o prepared statements but it can't be used in this case. This test cases was added because when prepared_statements config is set to false, then DetermineIfPreparableVisitor module does not extended by Arel visitor resulting into an error. Ref: https://github.com/rails/rails/pull/22748. - Because DetermineIfPreparableVisitor module does not get added to the visitor chain only if prepared_statements is false while **setting up connection**, not when `unprepared_statement` is used. - I have also added an assertion for making sure that prepared_config is set to false from the start, so that nobody accidentally removes the connection setup using `arunit_without_prepared_statements` and replaces it with stubs or unprepared_statement. | ||||
| * | Fix typo s/with/without/ | Ryuta Kamizono | 2016-11-20 | 1 | -1/+1 |
| | | | | | Follow up to #27109. | ||||
| * | Fix tests for prepared_statements: false and queries hitting `#select_all` | Prathamesh Sonpatki | 2016-11-19 | 1 | -4/+4 |
| | | | | | | | | | | | - The query needs to be executed for hitting `select_all` so made sure that query gets executed. - Also instead of changing instance variable, just add new configuration for prepared_statements: false and use it for this test. - This way we don't have to touch the internals of AR code and still disable prepared statements config for this test. | ||||
| * | Fix mucking of connection_config leading to issues in prepared_statements | Vipul A M | 2016-11-17 | 1 | -3/+3 |
| | | |||||
| * | Fix PG prepared statement test | Vipul A M | 2016-11-17 | 1 | -1/+2 |
| | | |||||
| * | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 1 | -1/+0 |
| | | |||||
| * | Fix NoMethodError preparable for Arel::Visitors in case prepared statements ↵ | Azzurrio | 2016-02-22 | 1 | -0/+22 |
| is falsy | |||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |