Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | Remove deprecated support to passing a class as a value in a query | Rafael Mendonça França | 2016-12-29 | 2 | -31/+0 | |
| | | | | ||||||
* | | | | Raises IrreversibleOrderError when using last with an irreversible order | Rafael Mendonça França | 2016-12-29 | 1 | -8/+0 | |
| | | | | ||||||
* | | | | Raise when a through association has an ambiguous reflection name | Rafael Mendonça França | 2016-12-29 | 2 | -9/+22 | |
| | | | | ||||||
* | | | | Raises when `ActiveRecord::Migration` is inherited directly. | Rafael Mendonça França | 2016-12-29 | 2 | -42/+25 | |
| | | | | ||||||
* | | | | Remove original_exception from ActiveRecord::StatementInvalid | Rafael Mendonça França | 2016-12-29 | 2 | -12/+2 | |
| | | | | ||||||
* | | | | `#tables` and `#table_exists?` and returns only tables and not views | Rafael Mendonça França | 2016-12-29 | 7 | -77/+61 | |
| | | | | ||||||
* | | | | Remove deprecated `name` argument from `#tables` | Rafael Mendonça França | 2016-12-29 | 4 | -22/+4 | |
| | | | | ||||||
* | | | | Remove deprecated support to passing a column to #quote | Rafael Mendonça França | 2016-12-29 | 1 | -11/+1 | |
| | | | | ||||||
* | | | | Set time as a timezone aware type and remove related deprecation | Rafael Mendonça França | 2016-12-29 | 1 | -23/+2 | |
| | | | | ||||||
* | | | | Remove deprecated force reload argument in association readers | Rafael Mendonça França | 2016-12-29 | 2 | -20/+4 | |
| | | | | ||||||
* | | | | Remove deprecated i18n scopes in Active Record | Rafael Mendonça França | 2016-12-29 | 2 | -16/+2 | |
| | | | | ||||||
* | | | | Merge pull request #27493 from kamipo/sync_visibility | Rafael França | 2016-12-29 | 1 | -1/+1 | |
|\ \ \ \ | | | | | | | | | | | Sync the visibility of `sql_for_insert` to private | |||||
| * | | | | Sync the visibility of `sql_for_insert` to private | Ryuta Kamizono | 2016-12-29 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | The visibility of all internal protected methods was changed to private since 5b14129. | |||||
* | | | | | Remove try! usage in sqlite_database_tasks. | Kasper Timm Hansen | 2016-12-29 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | We try to not try! internally. | |||||
* | | | | | Merge pull request #27437 from kirs/structure-load-dump-flags | Kasper Timm Hansen | 2016-12-29 | 4 | -11/+28 | |
|\ \ \ \ \ | |/ / / / |/| | | | | Make ActiveRecord structure load/dump configurable | |||||
| * | | | | Make ActiveRecord structure load/dump configurable | Kir Shatrov | 2016-12-22 | 4 | -11/+28 | |
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this patch it's impossible to pass extra flags to mysqldump/pg_dump when running `rake db:structure:dump` or `load` The following config variables (`structure_load_flags` and `structure_dump_flags`) make it better configurable. | |||||
* | | | | Merge pull request #27490 from ↵ | Rafael França | 2016-12-29 | 1 | -4/+6 | |
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | kamipo/should_not_update_children_when_parent_creation_with_no_reason Should not update children when the parent creation with no reason | |||||
| * | | | Should not update children when the parent creation with no reason | Ryuta Kamizono | 2016-12-29 | 1 | -4/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This issue was introduced with d849f42 to solve #19782. However, we can solve #19782 without causing the issue. It is enough to save only when necessary. Fixes #27338. | |||||
* | | | | Merge pull request #26376 from kamipo/remove_polymorphic_base_class_for_array | Rafael França | 2016-12-29 | 1 | -3/+0 | |
|\ \ \ \ | |/ / / |/| | | | Remove extracting `polymorphic_base_class` for `Array` in `AssociationQueryValue` | |||||
| * | | | Remove extracting `polymorphic_base_class` for `Array` in ↵ | Ryuta Kamizono | 2016-09-21 | 1 | -3/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | `AssociationQueryValue` It is handled by `PolymorphicArrayValue`. | |||||
* | | | | Merge pull request #27402 from yui-knk/execute | Rafael França | 2016-12-28 | 1 | -1/+1 | |
|\ \ \ \ | | | | | | | | | | | Use `#execute` instead of `@connection.query` | |||||
| * | | | | Use `#execute` instead of `@connection.query` | yui-knk | 2016-12-19 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | `@connection.query` bypasses instrumenting "sql.active_record". This behavior preventing us from debugging SQLs which Rails generates. | |||||
* | | | | | Fix Rubocop violations and fix documentation visibility | Rafael Mendonça França | 2016-12-28 | 15 | -147/+147 | |
| |_|_|/ |/| | | | | | | | | | | | | | | | | | | | Some methods were added to public API in 5b14129d8d4ad302b4e11df6bd5c7891b75f393c and they should be not part of the public API. | |||||
* | | | | Merge pull request #27442 from kamipo/fix_27434 | Eileen M. Uchitelle | 2016-12-27 | 2 | -13/+16 | |
|\ \ \ \ | | | | | | | | | | | Add a record to target before any callbacks loads the record | |||||
| * | | | | Add a record to target before any callbacks loads the record | Ryuta Kamizono | 2016-12-23 | 2 | -13/+16 | |
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `append_record` was added at 15ddd51 for not double adding the record. But adding `append_record` (checking `@target.include?(record)`) caused performance regression #27434. Instead of checking not double adding the record, add a record to target before any callbacks loads the record. Fixes #27434. | |||||
* | | | | No need `:doc:` for `:nodoc:` classes [ci skip] | Ryuta Kamizono | 2016-12-25 | 5 | -15/+15 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Follow up to 5b14129d8d4ad302b4e11df6bd5c7891b75f393c. http://edgeapi.rubyonrails.org/classes/ActiveRecord/Attribute.html | |||||
* | | | | AR::ConnectionAdapters::PostgreSQL::Name#parts is called from other instances | Akira Matsuda | 2016-12-25 | 1 | -4/+6 | |
| | | | | ||||||
* | | | | Privatize unneededly protected methods in Active Record | Akira Matsuda | 2016-12-24 | 26 | -158/+145 | |
| | | | | ||||||
* | | | | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 11 | -31/+31 | |
| | | | | ||||||
* | | | | Describe what we are protecting | Akira Matsuda | 2016-12-23 | 24 | -0/+50 | |
|/ / / | ||||||
* / / | fix #create_fixtures when equal table names in different databases | Julia Lopez | 2016-12-21 | 1 | -3/+3 | |
|/ / | ||||||
* | | Merge pull request #27329 from kamipo/simplify_unsigned_regex | Eileen M. Uchitelle | 2016-12-17 | 1 | -2/+1 | |
|\ \ | | | | | | | Simplify the regex for `unsigned?` method | |||||
| * | | Simplify the regex for `unsigned?` method | Ryuta Kamizono | 2016-12-11 | 1 | -2/+1 | |
| | | | | | | | | | | | | | | | It is enough to distinguish only the trailing `unsigned` and `unsigned zerofill`. | |||||
* | | | Merge pull request #27375 from kirs/fixture-error-message | Rafael França | 2016-12-16 | 1 | -2/+5 | |
|\ \ \ | | | | | | | | | Throw friendly error message when fixture is not a hash | |||||
| * | | | Throw friendly error message when fixture is not a hash | Kir Shatrov | 2016-12-15 | 1 | -2/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Right now, when fixture is not a Hash we throw an error message saying "fixture is not a hash". This is not very user friendly because it's not saying which fixture is invalid. | |||||
* | | | | fix QueryCache nil dup | Richard Monette | 2016-12-15 | 2 | -3/+8 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | make sql statements frozen dup if arel is not our string expect runtime error dont wrap runtime error in invalid log errors will now be treated as runtime errors update changelog | |||||
* | | | | Merge pull request #27042 from kirs/yaml-schema-cache | Rafael França | 2016-12-13 | 4 | -11/+49 | |
|\ \ \ \ | |_|/ / |/| | | | Schema cache in YAML | |||||
| * | | | Use YAML to serialize schema cache | Kir Shatrov | 2016-11-27 | 4 | -11/+49 | |
| | | | | ||||||
* | | | | Fix CI failure caused by #25227 and #25280 were merged at the same time | Ryuta Kamizono | 2016-12-10 | 1 | -1/+1 | |
| |/ / |/| | | ||||||
* | | | Merge pull request #25280 from ↵ | Sean Griffin | 2016-12-10 | 1 | -0/+2 | |
|\ \ \ | | | | | | | | | | | | | | | | | kamipo/prevent_range_error_for_belongs_to_associations Prevent `RangeError` for `belongs_to` associations | |||||
| * | | | Prevent `RangeError` for `belongs_to` associations | Ryuta Kamizono | 2016-10-10 | 1 | -0/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently to access `belongs_to` associations raises a `RangeError` if foreign key attribute has out of range value. It should return a nil value rather than raising a `RangeError`. Fixes #20140. | |||||
* | | | | Merge pull request #25227 from kamipo/numeric_value_out_of_range | Sean Griffin | 2016-12-10 | 5 | -6/+16 | |
|\ \ \ \ | | | | | | | | | | | Translate numeric value out of range to the specific exception | |||||
| * | | | | Translate numeric value out of range to the specific exception | Ryuta Kamizono | 2016-12-06 | 5 | -6/+16 | |
| | | | | | | | | | | | | | | | | | | | | Raise `ActiveRecord::RangeError` when values that executed are out of range. | |||||
* | | | | | Emulate db trigger behaviour for after_commit :destroy, :update | Stefan Budeanu | 2016-12-09 | 2 | -5/+14 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Race conditions can occur when an ActiveRecord is destroyed twice or destroyed and updated. The callbacks should only be triggered once, similar to a SQL database trigger. | |||||
* | | | | | Resolve association class correctly when assigning ids on a through association | Matthew Draper | 2016-12-09 | 2 | -1/+5 | |
| | | | | | ||||||
* | | | | | Fix test breaking error uninitialized constant ActiveRecord::Type::Value. | utilum | 2016-12-08 | 1 | -0/+1 | |
| | | | | | ||||||
* | | | | | Merge pull request #26696 from iainbeeston/only-ruby-types-in-activemodel | Sean Griffin | 2016-12-08 | 4 | -4/+36 | |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | Moved database-specific ActiveModel types into ActiveRecord | |||||
| * | | | | | Moved database-specific ActiveModel types into ActiveRecord | Iain Beeston | 2016-10-14 | 4 | -3/+36 | |
| | | | | | | | | | | | | | | | | | | | | | | | | ie. DecimalWithoutScale, Text and UnsignedInteger | |||||
* | | | | | | Check whether the current attribute being write is aliased or not before writing | Prathamesh Sonpatki | 2016-12-09 | 1 | -1/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | - If aliased, then use the aliased attribute name. | |||||
* | | | | | | Check whether the current attribute being read is aliased or not before reading | Prathamesh Sonpatki | 2016-12-08 | 1 | -1/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - If aliased, then use the aliased attribute name. - Fixes #26417. |