aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Simplify the regex for `unsigned?` methodRyuta Kamizono2016-12-111-2/+1
| | | | | | | | | | | | | | | It is enough to distinguish only the trailing `unsigned` and `unsigned zerofill`.
* | | Merge pull request #27375 from kirs/fixture-error-messageRafael França2016-12-161-2/+5
|\ \ \ | | | | | | | | Throw friendly error message when fixture is not a hash
| * | | Throw friendly error message when fixture is not a hashKir Shatrov2016-12-151-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | Right now, when fixture is not a Hash we throw an error message saying "fixture is not a hash". This is not very user friendly because it's not saying which fixture is invalid.
* | | | fix QueryCache nil dupRichard Monette2016-12-152-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | make sql statements frozen dup if arel is not our string expect runtime error dont wrap runtime error in invalid log errors will now be treated as runtime errors update changelog
* | | | Merge pull request #27042 from kirs/yaml-schema-cacheRafael França2016-12-134-11/+49
|\ \ \ \ | |_|/ / |/| | | Schema cache in YAML
| * | | Use YAML to serialize schema cacheKir Shatrov2016-11-274-11/+49
| | | |
* | | | Fix CI failure caused by #25227 and #25280 were merged at the same timeRyuta Kamizono2016-12-101-1/+1
| |/ / |/| |
* | | Merge pull request #25280 from ↵Sean Griffin2016-12-101-0/+2
|\ \ \ | | | | | | | | | | | | | | | | kamipo/prevent_range_error_for_belongs_to_associations Prevent `RangeError` for `belongs_to` associations
| * | | Prevent `RangeError` for `belongs_to` associationsRyuta Kamizono2016-10-101-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently to access `belongs_to` associations raises a `RangeError` if foreign key attribute has out of range value. It should return a nil value rather than raising a `RangeError`. Fixes #20140.
* | | | Merge pull request #25227 from kamipo/numeric_value_out_of_rangeSean Griffin2016-12-105-6/+16
|\ \ \ \ | | | | | | | | | | Translate numeric value out of range to the specific exception
| * | | | Translate numeric value out of range to the specific exceptionRyuta Kamizono2016-12-065-6/+16
| | | | | | | | | | | | | | | | | | | | Raise `ActiveRecord::RangeError` when values that executed are out of range.
* | | | | Emulate db trigger behaviour for after_commit :destroy, :updateStefan Budeanu2016-12-092-5/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Race conditions can occur when an ActiveRecord is destroyed twice or destroyed and updated. The callbacks should only be triggered once, similar to a SQL database trigger.
* | | | | Resolve association class correctly when assigning ids on a through associationMatthew Draper2016-12-092-1/+5
| | | | |
* | | | | Fix test breaking error uninitialized constant ActiveRecord::Type::Value.utilum2016-12-081-0/+1
| | | | |
* | | | | Merge pull request #26696 from iainbeeston/only-ruby-types-in-activemodelSean Griffin2016-12-084-4/+36
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Moved database-specific ActiveModel types into ActiveRecord
| * | | | | Moved database-specific ActiveModel types into ActiveRecordIain Beeston2016-10-144-3/+36
| | | | | | | | | | | | | | | | | | | | | | | | ie. DecimalWithoutScale, Text and UnsignedInteger
* | | | | | Check whether the current attribute being write is aliased or not before writingPrathamesh Sonpatki2016-12-091-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | - If aliased, then use the aliased attribute name.
* | | | | | Check whether the current attribute being read is aliased or not before readingPrathamesh Sonpatki2016-12-081-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - If aliased, then use the aliased attribute name. - Fixes #26417.
* | | | | | Merge pull request #27278 from kamipo/should_be_sync_primary_key_definitionSean Griffin2016-12-081-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Should be sync the `primary_key` definition with actually created
| * | | | | | Should be sync the `primary_key` definition with actually createdRyuta Kamizono2016-12-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Actually the `primary_key` definition is not used but the inconsistency is confusing. Actual definition is `bigint auto_increment PRIMARY KEY` so `UNSIGNED` and `(8)` is unnecessary. See also #21607.
* | | | | | | Add some documentation around internal APIs [ci skip]Sean Griffin2016-12-081-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While these method aren't public API, they are a non-trivial internal API which warrant a bit of explanation.
* | | | | | | Merge pull request #27251 from ebeigarts/fix-autosaveSean Griffin2016-12-061-3/+3
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix association scope inside autosaved association callbacks
| * | | | | | | Reload association scope inside autosaved associationsEdgars Beigarts2016-12-021-3/+3
| | | | | | | |
* | | | | | | | [ci skip] Document regex changeAlex Kitchens2016-12-061-0/+1
| |_|_|/ / / / |/| | | | | |
* | | | | | | Merge pull request #25451 from ↵Sean Griffin2016-12-064-0/+13
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/translate_not_null_violation_to_specific_exception Translate NOT NULL violation to the specific exception
| * | | | | | | Translate NOT NULL violation to the specific exceptionRyuta Kamizono2016-12-064-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Raise `ActiveRecord::NotNullViolation` when a record cannot be inserted or updated because it would violate a not null constraint.
* | | | | | | | Merge pull request #27275 from kamipo/should_inherit_statement_invalidSean Griffin2016-12-061-1/+1
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | Should inherit `StatementInvalid` rather than `WrappedDatabaseException`
| * | | | | | | Should inherit `StatementInvalid` rather than `WrappedDatabaseException`Ryuta Kamizono2016-12-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Because defunct wrapper class is kept for compatibility.
* | | | | | | | Merge pull request #26687 from kamipo/fix_add_index_to_normalize_optionsMatthew Draper2016-12-062-0/+2
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Fix `add_index` to normalize column names and options
| * | | | | | | | Fix `add_index` to normalize column names and optionsRyuta Kamizono2016-10-032-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently does not work the following code. ```ruby add_index(:people, ["last_name", "first_name"], order: { last_name: :desc, first_name: :asc }) ``` Normalize column names and options to fix the issue.
* | | | | | | | | Merge pull request #27277 from kamipo/remove_unnecessary_variableMatthew Draper2016-12-061-2/+1
|\ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / |/| | | | | | | | Remove unnecessary `connection_name` variable
| * | | | | | | | Remove unnecessary `connection_name` variableRyuta Kamizono2016-12-061-2/+1
| | |/ / / / / / | |/| | | | | |
* | | | | | | | Merge pull request #27274 from kamipo/primary_key_with_auto_increment_and_bigintMatthew Draper2016-12-062-3/+7
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | Make `:auto_increment` option works on `:bigint`
| * | | | | | | Make `:auto_increment` option works on `:bigint`Ryuta Kamizono2016-12-062-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to #27272.
* | | | | | | | Make pg adapter use bigserial for pk by defaultPavel Pravosud2016-12-053-2/+62
| | | | | | | |
* | | | | | | | Change MySQL and Postgresql to use Bigint primary keysJon McCartie2016-12-059-11/+27
|/ / / / / / /
* | | | | | | Make `:auto_increment` to internal primary key optionRyuta Kamizono2016-12-063-1/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using `:auto_increment` option for abstracting the DB-specific auto incremental types. It is worth to ease to implement the compatibility layer.
* | | | | | | Don't try to run multiple insert queries at onceSean Griffin2016-12-051-5/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SQLite's default query interface ignores anything after the first semicolon in a query. This is actually quite common behavior in database drivers, especially when dealing with code paths for prepared statements (which we are). While this should only affect SQLite, as I'm not aware of any drivers which don't support multi-insert. Even if this does affect other third party drivers though, I'd prefer not to assume that more than one query can be executed per call to `execute`. Fixes #26948. Close #27242.
* | | | | | | Fix that `change_column` lose a commentRyuta Kamizono2016-12-051-0/+4
| |/ / / / / |/| | | | |
* | | | | | Stop using the `pg` Float encoderSean Griffin2016-12-011-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PG's type map assumes that all Ruby floats are going to a field with an OID of type float4 or float8, and generates text which is invalid syntax for other types. Since the gem can handle floats properly without this encoder (albeit slightly slower), we can continue to use that as we have in prior versions of Rails. Fixes #27246
* | | | | | Make the second argument to `attribute` optionalSean Griffin2016-11-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While working on updating Paper Trail for 5.1 compatibility, I noticed that I was required to pass a second argument to `attribute`. I didn't intend for this to be the case, as `attribute :foo` is totally reasonable shorthand for "I want `attr_accessor :foo`, but also have it work with things like `.attributes` and `ActiveRecord::Dirty`"
* | | | | | Correct deprecation warnings in `ActiveRecord::Dirty`Sean Griffin2016-11-301-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | I had pointed the messages at the new behavior, not the old.
* | | | | | Merge pull request #27126 from kamipo/fix_unsigned_with_zerofillRafael França2016-11-292-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix that unsigned with zerofill is treated as signed
| * | | | | | Fix that unsigned with zerofill is treated as signedRyuta Kamizono2016-11-272-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #27125.
* | | | | | | fixing update_all and delete_all when chained with left_joins. fixes #27192Diego Plentz2016-11-271-2/+6
|/ / / / / /
* | | | | | Merge pull request #26865 from ↵Matthew Draper2016-11-271-4/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | sergey-alekseev/uniqueness-validation-scope-with-polymorphic-association fix the uniqueness validation scope with a polymorphic association
| * | | | | | fix the uniqueness validation scope with a polymorphic associationSergey Alekseev2016-11-261-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://gist.github.com/sergey-alekseev/946657ebdb5e58d1bee115714056ec96
* | | | | | | Clear available connections immediatelyMatthew Draper2016-11-271-0/+2
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It'll be re-cleared when it's rebuilt in with_new_connections_blocked's ensure, but we still need to clear it inside this synchronize -- we've disconnected connections that may be available in the queue, and while other threads are not allowed to make *new* connections, they are still allowed to take existing ones from there. This was incorrectly removed in d314646c965b045724e6bdb9d61dcecfabc0ba8f.
* | | | | | We're not calling hooks here since 9e4c41c903e8e58721f2c41776a8c60ddba7a0a9Akira Matsuda2016-11-251-1/+0
| | | | | |
* | | | | | Merge pull request #27165 from ↵Rafael França2016-11-251-5/+15
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | prathamesh-sonpatki/followup-uuid-extension-change Followup of UUID default extension in the docs
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-07 05:35:28 +0000