Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | explain listener does not care about time, so use evented listener | Aaron Patterson | 2012-06-20 | 1 | -2/+5 |
| | |||||
* | Merge pull request #6798 from kennyj/db-rake-structure-load | Carlos Antonio da Silva | 2012-06-20 | 5 | -19/+26 |
|\ | | | | | Refactor db:structure:load task. | ||||
| * | Refactor db:structure:load task. | kennyj | 2012-06-21 | 5 | -19/+26 |
| | | |||||
* | | Merge pull request #4396 from kennyj/fix_4259 | Rafael Mendonça França | 2012-06-20 | 1 | -4/+8 |
|\ \ | |/ |/| | | | Fix GH #4259. When we execute schema dumper, we must remove table_name_prefix and table_name_suffix. | ||||
| * | Fix GH #4259. We must remove table_name_prefix and table_name_suffix, when ↵ | kennyj | 2012-01-10 | 1 | -4/+8 |
| | | | | | | | | we execute schema dumper. | ||||
* | | Remove unneeded code since pluck is respecting joins now | Rafael Mendonça França | 2012-06-19 | 1 | -12/+1 |
| | | |||||
* | | Extract conditional to a method to avoid duplication | Rafael Mendonça França | 2012-06-19 | 1 | -15/+19 |
| | | | | | | | | Also use if/else block to not use short circuit return | ||||
* | | handle joins/includes correctly for pluck and calculation. | Andrey Deryabin | 2012-06-19 | 1 | -1/+6 |
| | | | | | | | | Fix #5990 | ||||
* | | Refactor db:structure:dump task. | kennyj | 2012-06-20 | 5 | -13/+41 |
| | | |||||
* | | Refactor db:charset task | Simon Jefford | 2012-06-19 | 5 | -17/+25 |
| | | | | | | | | | | In a similar vein to Pat's work on create, drop etc, the db:charset task is now a one liner in databases.rake | ||||
* | | Refactor the conditionals | Rafael Mendonça França | 2012-06-19 | 1 | -7/+7 |
| | | |||||
* | | Validates_numericality_of is skipped when changing 0 to to non-empty string | Angelo capilleri | 2012-06-19 | 1 | -5/+15 |
| | | | | | | | | | | | | | | | | | | | | This happens when A has_many many B and A accepts_nested_attributes B that has a numeric colum with initial 0 value. So a.update_attributes({:b_attributes => { :id => b.id, :numeric => 'foo' }}) passes the validation test but, the value of :numeric doesn't change. his commit forces that the update fails with the above conditions. Fixes #6393 Fixes #2331 | ||||
* | | Refactor and use class_attribute | Carlos Antonio da Silva | 2012-06-18 | 1 | -3/+5 |
| | | |||||
* | | Remember the stored attributes in a config attribute. | Joost Baaij | 2012-06-18 | 1 | -0/+12 |
| | | | | | | | | | | | | This allows you to retrieve the list of attributes you've defined. Usable for e.g. selects in the view, or interators based on the attributes you wish to store in the serialized column. | ||||
* | | Refactor Relation#update a bit to avoid an extra Enumerator instance | Carlos Antonio da Silva | 2012-06-18 | 1 | -1/+1 |
| | | |||||
* | | Make DatabaseTasks a module with real private methods | Carlos Antonio da Silva | 2012-06-18 | 1 | -13/+14 |
| | | |||||
* | | Removing composed_of from ActiveRecord. | Steve Klabnik | 2012-06-18 | 10 | -343/+9 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This feature adds a lot of complication to ActiveRecord for dubious value. Let's talk about what it does currently: class Customer < ActiveRecord::Base composed_of :balance, :class_name => "Money", :mapping => %w(balance amount) end Instead, you can do something like this: def balance @balance ||= Money.new(value, currency) end def balance=(balance) self[:value] = balance.value self[:currency] = balance.currency @balance = balance end Since that's fairly easy code to write, and doesn't need anything extra from the framework, if you use composed_of today, you'll have to add accessors/mutators like that. Closes #1436 Closes #2084 Closes #3807 | ||||
* | | Change minimum (default) log level in PostgreSQL to warning. | kennyj | 2012-06-18 | 1 | -1/+1 |
| | | |||||
* | | Merge branch 'dp_docs' | Carlos Antonio da Silva | 2012-06-18 | 1 | -0/+92 |
|\ \ | | | | | | | | | | Closes #6697 | ||||
| * | | Documentation for where and where! methods on relations. | David Paschich | 2012-06-18 | 1 | -0/+92 |
| | | | | | | | | | | | | Based on examples seen in the Rails test suite. [ci skip] | ||||
* | | | fix invalid syntax and sqlite rake failing tests | Francesco Rodriguez | 2012-06-18 | 1 | -2/+3 |
| | | | |||||
* | | | add :nodoc: to AR::Tasks and update to follow the coding conventions | Francesco Rodriguez | 2012-06-18 | 4 | -208/+226 |
| | | | |||||
* | | | check if sqlite3 file exists before remove | Francesco Rodriguez | 2012-06-18 | 1 | -3/+3 |
| | | | |||||
* | | | Merge pull request #6761 from freelancing-god/db-rake | Jon Leighton | 2012-06-17 | 6 | -156/+268 |
|\ \ \ | | | | | | | | | Get logic out of db rake tasks, and into classes and objects | ||||
| * | | | Rails is the default (but now override able) source for environment and path. | Pat Allan | 2012-06-17 | 2 | -15/+25 |
| | | | | |||||
| * | | | Cleaning up after some warnings, adding slightly higher-level tests. | Pat Allan | 2012-06-17 | 4 | -7/+13 |
| | | | | |||||
| * | | | One line db:create/db:drop tasks. | Pat Allan | 2012-06-17 | 2 | -55/+50 |
| | | | | | | | | | | | | | | | | | | | | | | | | Now isn't that better? And yes, I know that private has no impact on class methods - it's a visual distinction, not a technical one. | ||||
| * | | | db:drop and some of db:test:purge. | Pat Allan | 2012-06-17 | 5 | -50/+63 |
| | | | | |||||
| * | | | db:create for PostgreSQL pulled out into a class. | Pat Allan | 2012-06-17 | 5 | -36/+42 |
| | | | | |||||
| * | | | db:create for MySQL now much cleaner. | Pat Allan | 2012-06-17 | 5 | -37/+110 |
| | | | | |||||
| * | | | A beginning of sorts. | Pat Allan | 2012-06-17 | 3 | -12/+21 |
| | | | | | | | | | | | | | | | | Minimal implementation that supports db:create SQLite replacement | ||||
* | | | | Merge pull request #6759 from dylanahsmith/only-catch-standard-error | Santiago Pastorino | 2012-06-17 | 3 | -6/+6 |
|\ \ \ \ | | | | | | | | | | | Avoid unnecessary catching of Exception instead of StandardError. | ||||
| * | | | | Avoid unnecessary catching of Exception instead of StandardError. | Dylan Smith | 2012-06-17 | 3 | -6/+6 |
| | | | | | |||||
* | | | | | Adding `load_config` task as dependency. | Cairo Noleto | 2012-06-16 | 1 | -14/+14 |
|/ / / / | | | | | | | | | | | | | Without this, some tasks won't load configurations like custom engines. | ||||
* | | | | Don't read csv file during executing db:fixtures:load. | kennyj | 2012-06-17 | 1 | -1/+1 |
| | | | | |||||
* | | | | no need to define methods in included hook | Jon Leighton | 2012-06-15 | 1 | -13/+13 |
| | | | | |||||
* | | | | Fix deprecation warnings when using ↵ | Jon Leighton | 2012-06-15 | 1 | -3/+8 |
| | | | | | | | | | | | | | | | | config.active_record.mass_assignment_sanitizer= | ||||
* | | | | Fix observers with AR::Model | Jon Leighton | 2012-06-15 | 3 | -3/+6 |
| | | | | |||||
* | | | | Fix config.active_record.whitelist_attributes with AR::Model | Jon Leighton | 2012-06-15 | 2 | -3/+13 |
| | | | | |||||
* | | | | Simplify AR configuration code. | Jon Leighton | 2012-06-15 | 21 | -260/+343 |
| | | | | | | | | | | | | | | | | | | | | Get rid of ActiveModel::Configuration, make better use of ActiveSupport::Concern + class_attribute, etc. | ||||
* | | | | refactor | Jon Leighton | 2012-06-15 | 1 | -11/+5 |
| |/ / |/| | | |||||
* | | | Merge pull request #6713 from etehtsea/activerecord-uuid | Rafael Mendonça França | 2012-06-14 | 2 | -3/+8 |
|\ \ \ | | | | | | | | | | | | | Add uuid datatype support to PostgreSQL adapter | ||||
| * | | | Add uuid type support to PostgreSQL adapter | Konstantin Shabanov | 2012-06-14 | 2 | -3/+8 |
| | | | | |||||
* | | | | Merge pull request #6738 from steveklabnik/master | Xavier Noria | 2012-06-14 | 3 | -21/+6 |
|\ \ \ \ | | | | | | | | | | | Remove update_attribute. | ||||
| * | | | | Remove update_attribute. | Steve Klabnik | 2012-06-14 | 3 | -21/+6 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Historically, update_attribute and update_attributes are similar, but with one big difference: update_attribute does not run validations. These two methods are really easy to confuse given their similar names. Therefore, update_attribute is being removed in favor of update_column. See the thread on rails-core here: https://groups.google.com/forum/?fromgroups#!topic/rubyonrails-core/BWPUTK7WvYA | ||||
* | | | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-06-14 | 1 | -1/+1 |
|\ \ \ \ \ | |/ / / / |/| | | | | |||||
| * | | | | Fixed typo. | chrismcc | 2012-06-11 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | Merge pull request #6676 from aurelian/master | Rafael Mendonça França | 2012-06-12 | 1 | -1/+1 |
|\ \ \ \ \ | |_|/ / / |/| | | | | Don't assign the attributes if the list is empty | ||||
| * | | | | Don't assign the attributes if the list is empty. | Aurelian Oancea | 2012-06-08 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | Merge pull request #6492 from pmahoney/fair-connection-pool2 | Rafael Mendonça França | 2012-06-11 | 1 | -37/+174 |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fair connection pool2 Conflicts: activerecord/test/cases/associations/eager_test.rb |