| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
This reverts commit abba61e2bbe320894ba8449ebdf778a1d2af545b.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
* adds password_digest attribute to the migration
* adds has_secure_password to the model
* adds password and password_confirmation password_fields to _form.html
* omits password entirely from index.html and show.html
* adds password and password_confirmation to the controller
* adds unencrypted password and password_confirmation to the controller test
* adds encrypted password_digest to the fixture
|
|
|
| |
A patch was committed recently which quoted the extension name in the SQL for `enable_extension`. But the same wasn't done for `disable_extension`.
|
|\
| |
| | |
dependent: :destroy should call destroy_all
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Commit https://github.com/rails/rails/pull/9668 shows warning
when `delete_all` is invoked with `:dependent` option
`:destroy`.
Unfortunately invoking `Post.destroy_all` invokes
`post.comments.delete_all` as part of `has_many` callbacks.
This commit ensures that instead `post.comments.destroy_all` is
invoked and in the process no warning is generated.
See issue #9567 for details .
|
| |
| |
| |
| | |
To make quote escape binary data correctly it needs the column passed in.
|
|/ |
|
| |
|
| |
|
| |
|
|\
| |
| | |
Show warning message if delete_all is firing callbacks
|
| |
| |
| |
| |
| |
| | |
`post.comments.delete_all` will fire callbacks if :dependent option is
:destroy . It will be fixed in Rails 4.1 . In the meantime display
a warning . Look at #9567 for details .
|
|/ |
|
|
|
|
|
|
| |
Closes #9643.
The logic was introduced with 46492949
|
|
|
|
| |
Take the opportunity to showcase where.not.
|
|\
| |
| |
| |
| |
| | |
Uniqueness validation uses a proc to specify the `:conditions` option.
This is a follow up to #5321 and follows the general direction in
AR to make things lazy evaluated.
|
| |
| |
| |
| |
| | |
This is a follow up to #5321 and follows the general direction in
AR to make things lazy evaluated.
|
|\ \
| |/
|/|
| |
| |
| | |
Bugfix for enable_extension in postgresql_adapter.
The use of quotations is required to install extensions with certain
characters in them (e.g. uuid-ossp).
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The use of quotations is required to install extensions with certain
characters in them (e.g. uuid-ossp).
removes CHANGELOG entry
Deemed unnecessary.
|
| |
| |
| |
| |
| | |
This allows end-users to have a `connection` method on their models
without clashing with ActiveRecord internals.
|
|\ \
| | |
| | | |
Update documentation for collection<< to reflect behavior for new parent objects.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
collection<< does not automatically fire update sql unless the parent object
is not a new record (and thus has a primary key).
eg:
p = Post.new
p.comments << Comment.new
does not call update sql until:
p.save
at which point it saves the parent object and then the collection object.
changes that to the
|
|\ \ \
| |/ /
|/| | |
|
| | | |
|
| |/
|/|
| |
| |
| | |
During insertion of "# This migration comes from ... " comment at the beginning of
a migration, presence of magic comment was not considered.
|
| |
| |
| |
| | |
which make it clearer about what's going on.
|
| |
| |
| |
| | |
[ci skip]
|
| |
| |
| |
| | |
Thanks @neerajdotname for noticing this bug.
|
| | |
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Fix ActiveRecord `subclass_from_attrs` when eager_load is false.
Conflicts:
activerecord/CHANGELOG.md
|
| | |
| | |
| | |
| | |
| | | |
It cannot find subclass because all classes are loaded automatically
when it needs.
|
| | |
| | |
| | |
| | |
| | |
| | | |
I've also added a proper acceptance test which reproduced the issue.
Closes #9513, #9515.
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Use the index name explicitly provided in a migration when reverting.
Fixes #8868
Conflicts:
activerecord/CHANGELOG.md
|
| | | |
| | | |
| | | |
| | | | |
schema_statements uses the column name by default to construct the index name, and then raises an exception if it doesn't exist, even if the name option is specified, which causes #8858. this commit makes index_name_for_remove fall back to constructing the index name to remove based on the name option.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
cfabianski/disable_prepared_statement_when_preparing_a_query
Unprepared Visitor + unprepared_statement
Conflicts:
activerecord/CHANGELOG.md
|
| |/ / / |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Introduced in f1082b8588a9144eedb34d511f0074031f692d98.
Full changelog in 9f007d7fe5f90257c71baa2c4e7c76fb44512986.
[ci skip]
|