diff options
author | Rafael Mendonça França <rafaelmfranca@gmail.com> | 2013-03-08 11:59:29 -0300 |
---|---|---|
committer | Rafael Mendonça França <rafaelmfranca@gmail.com> | 2013-03-08 11:59:29 -0300 |
commit | 74d24ea1fe4f83bb7ae7c7b5aa1af82a1592c841 (patch) | |
tree | ac01f0d7c70d54a2b45a68bb228f42b8be19bb66 /activerecord/lib | |
parent | dd1d309fa9c158607a35fee2c18b477728811ad8 (diff) | |
parent | b04051d4e0c8066ec79cd4978606e4728dfa6ffa (diff) | |
download | rails-74d24ea1fe4f83bb7ae7c7b5aa1af82a1592c841.tar.gz rails-74d24ea1fe4f83bb7ae7c7b5aa1af82a1592c841.tar.bz2 rails-74d24ea1fe4f83bb7ae7c7b5aa1af82a1592c841.zip |
Merge pull request #9497 from route/subclass_from_attrs
Fix ActiveRecord `subclass_from_attrs` when eager_load is false.
Conflicts:
activerecord/CHANGELOG.md
Diffstat (limited to 'activerecord/lib')
-rw-r--r-- | activerecord/lib/active_record/inheritance.rb | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/inheritance.rb b/activerecord/lib/active_record/inheritance.rb index 13a8352f13..faef5a9527 100644 --- a/activerecord/lib/active_record/inheritance.rb +++ b/activerecord/lib/active_record/inheritance.rb @@ -170,8 +170,9 @@ module ActiveRecord # this will ignore the inheritance column and return nil def subclass_from_attrs(attrs) subclass_name = attrs.with_indifferent_access[inheritance_column] - return nil if subclass_name.blank? || subclass_name == self.name - unless subclass = subclasses.detect { |sub| sub.name == subclass_name } + return if subclass_name.blank? || subclass_name == self.name + subclass = subclass_name.safe_constantize + unless subclasses.include?(subclass) raise ActiveRecord::SubclassNotFound.new("Invalid single-table inheritance type: #{subclass_name} is not a subclass of #{name}") end subclass |