Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | | | Use the correct pk field from the reflected class to find the old record | Carlos Antonio da Silva | 2013-04-04 | 1 | -1/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The implementation was using the source class foreign key field instead of the reflected primary key one to find the old record. For instance, for this scenario class Bulb < ActiveRecord::Base belongs_to :car, :touch => true end class Car < ActiveRecord::Base has_many :bulbs end the current implementation was trying to do this query: Car.where(car_id: X).first where we should be doing this query: Car.where(id: X).first This should hopefully fix the build. | |||||
| * | | | | | Use inspect when writing the foreign key from the reflection | Andrew White | 2013-04-05 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we don't use inspect inside the class_eval block then the foreign key is written without quotes causing us to fetch the foreign key value and not the column name. | |||||
| * | | | | | Use a space after the comment sign when showing the result of commands | Carlos Antonio da Silva | 2013-04-04 | 1 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://guides.rubyonrails.org/api_documentation_guidelines.html#example-code [ci skip] | |||||
| * | | | | | Merge pull request #10094 from neerajdotname/fix2 | Carlos Antonio da Silva | 2013-04-04 | 2 | -3/+21 | |
| |\ \ \ \ \ | | | | | | | | | | | | | | | Collection of small fixes. Check individual commits for background. | |||||
| | * | | | | | use | to have more intent revealing code | Neeraj Singh | 2013-04-04 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | thanks to @egilburg for suggestion | |||||
| | * | | | | | expanded rdoc for chain and reflection_names | Neeraj Singh | 2013-04-04 | 1 | -2/+20 | |
| | | | | | | | ||||||
| * | | | | | | stop depending on callbacks | Aaron Patterson | 2013-04-04 | 1 | -6/+12 | |
| |/ / / / / | ||||||
| * | | | | | Merge pull request #10087 from neerajdotname/10016 | Carlos Antonio da Silva | 2013-04-04 | 1 | -0/+1 | |
| |\ \ \ \ \ | | | | | | | | | | | | | | | has_many through obeys order on through association | |||||
| | * | | | | | has_many through obeys order on through association | Neeraj Singh | 2013-04-04 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixes #10016 | |||||
| * | | | | | | Merge pull request #10088 from neerajdotname/fixes1 | Rafael Mendonça França | 2013-04-04 | 3 | -5/+15 | |
| |\ \ \ \ \ \ | | |/ / / / / | |/| | | | | | minor fixes including variable name change and expanded rdoc | |||||
| | * | | | | | expanded rdoc on source_reflection method | Neeraj Singh | 2013-04-04 | 1 | -0/+10 | |
| | | | | | | | ||||||
| | * | | | | | show name of the klass that has missing association | Neeraj Singh | 2013-04-02 | 1 | -1/+1 | |
| | | | | | | | ||||||
| | * | | | | | not a relation. it's an arel select manager | Neeraj Singh | 2013-04-02 | 1 | -4/+4 | |
| | | | | | | | ||||||
| * | | | | | | Merge pull request #9141 from adamgamble/issue-9091 | David Heinemeier Hansson | 2013-04-03 | 1 | -0/+10 | |
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | belongs_to :touch should touch old record when transitioning. | |||||
| | * | | | | | | Modifies belong_to touch callback to touch old associations also #9091 | Adam Gamble | 2013-03-14 | 1 | -0/+10 | |
| | | | | | | | | ||||||
* | | | | | | | | just check pending migrations in the current environment | Aaron Patterson | 2013-04-05 | 1 | -2/+2 | |
| | | | | | | | | ||||||
* | | | | | | | | check pending migrations against the test db | Aaron Patterson | 2013-04-03 | 1 | -11/+3 | |
| | | | | | | | | ||||||
* | | | | | | | | ensure the schema checking is done in the dev connection | Aaron Patterson | 2013-04-03 | 1 | -0/+8 | |
|/ / / / / / / | ||||||
* | | | | | | | Merge pull request #10049 from vipulnsward/optimize_around_merge_v1 | Rafael Mendonça França | 2013-04-03 | 1 | -1/+1 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | optimize some code around merge | |||||
| * | | | | | | | optimize some code around merge | Vipul A M | 2013-04-03 | 1 | -1/+1 | |
| | | | | | | | | ||||||
* | | | | | | | | Move alias method near to the aliased one in collection proxy | Carlos Antonio da Silva | 2013-04-03 | 1 | -2/+1 | |
| | | | | | | | | ||||||
* | | | | | | | | Merge pull request #10063 from SamSaffron/master | Santiago Pastorino | 2013-04-02 | 1 | -4/+4 | |
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | Per #9999 revert blank? to empty? | |||||
| * | | | | | | | | Per #9999 revert the revert changing so columns are only tested for empty? ↵ | Sam | 2013-04-03 | 1 | -4/+4 | |
| | |_|_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | as opposed to blank? This is both faster and more correct, added tests to make sure this is not reverted again. | |||||
* / | | | | | | | true/false => truthy falsy | Steve Klabnik | 2013-04-02 | 1 | -2/+2 | |
|/ / / / / / / | ||||||
* | | / / / / | Prefer find_by over dynamic finders in rdoc | Sam Ruby | 2013-04-02 | 5 | -11/+11 | |
| |_|/ / / / |/| | | | | | ||||||
* | | | | | | Merge pull request #9975 from ↵ | Aaron Patterson | 2013-04-02 | 1 | -12/+8 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | mmangino/raise_when_attributes_cant_be_unserialized Unserializing YAML attributes can silently fail in development mode | |||||
| * | | | | | | Remove all error masking when decoding serialized data fails? | Mike Mangino | 2013-04-02 | 1 | -13/+8 | |
| | | | | | | | ||||||
| * | | | | | | Raise an exception when unserialization fails due to a missing class | Mike Mangino | 2013-03-28 | 1 | -1/+2 | |
| | | | | | | | ||||||
* | | | | | | | Fix tiny problem: change method order for consistency and fix wrong method name. | kennyj | 2013-04-03 | 1 | -1/+1 | |
| | | | | | | | ||||||
* | | | | | | | Add deprecation message on Firebird / Sqlserver / Oracle database tasks. | kennyj | 2013-04-03 | 3 | -0/+3 | |
| | | | | | | | ||||||
* | | | | | | | Extract Oracle database tasks. | kennyj | 2013-04-03 | 4 | -31/+54 | |
| | | | | | | | ||||||
* | | | | | | | Extract Sqlserver database tasks. | kennyj | 2013-04-03 | 4 | -11/+51 | |
| | | | | | | | ||||||
* | | | | | | | Extract Firebird database tasks. | kennyj | 2013-04-03 | 4 | -20/+58 | |
| | | | | | | | ||||||
* | | | | | | | no need to invoke to_s before applying intern | Neeraj Singh | 2013-04-02 | 1 | -1/+1 | |
| | | | | | | | ||||||
* | | | | | | | Fix #new with an STI object with complex inheritance | Nate Berkopec | 2013-04-02 | 1 | -1/+1 | |
| | | | | | | | ||||||
* | | | | | | | Updated the error message for +find+ on an inverse_of association | wangjohn | 2013-04-01 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | so that it is consistent with the error thrown for +find+ without an inverse_of association. | |||||
* | | | | | | | Throwing a RecordNotFound exception when a record is scanned using the | wangjohn | 2013-04-01 | 2 | -12/+37 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | inverse_of option. I've also refactored the code for raising a RecordNotFound exception when searching for records with ids. | |||||
* | | | | | | | :uniq is still a valid relation option since it was only silently | Rafael Mendonça França | 2013-04-01 | 1 | -1/+1 | |
| |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | deprecated Fixes activerecord-deprecated_finders build. https://travis-ci.org/rails/activerecord-deprecated_finders/builds/5964703 | |||||
* | | | | | | Merge pull request #10010 from pwnall/fix_ref_index_true | Rafael Mendonça França | 2013-04-01 | 1 | -1/+1 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Make references with index:true pass Hash options to add_index | |||||
| * | | | | | | Make references with index:true pass Hash options to add_index. | Victor Costan | 2013-04-01 | 1 | -1/+1 | |
| | | | | | | | ||||||
* | | | | | | | fix detect column type of enum | masarakki | 2013-04-01 | 1 | -2/+2 | |
|/ / / / / / | | | | | | | | | | | | | | | | | | | enum includes text or blob or ... hooked by wrong regex | |||||
* | | | | | | Refactor index algorithm lookup so that it only builds the available options ↵ | Carlos Antonio da Silva | 2013-03-30 | 1 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | once This way the available options are only built for actually fetching the algorithm in case the option is given. The options are going to be necessary a second time only in case the option is given but does not exist, which is supposed to be due to a typo or something like that, so no problem. | |||||
* | | | | | | Minor doc improvement about index algorithms [ci skip] | Carlos Antonio da Silva | 2013-03-30 | 1 | -3/+2 | |
| | | | | | | ||||||
* | | | | | | Do not calculate values if they are not going to be used | Carlos Antonio da Silva | 2013-03-30 | 1 | -7/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When building the indexes list in PostgreSQL, IndexDefinition objects are only created if the query for the related attributes really returns something matching the attributes. In case it does not, the variables for building the definition objects were being created but not used. | |||||
* | | | | | | Make docs a little bit more consistent with colons [ci skip] | Carlos Antonio da Silva | 2013-03-30 | 1 | -9/+9 | |
| | | | | | | ||||||
* | | | | | | Fix code examples indent in new index options docs [ci skip] | Carlos Antonio da Silva | 2013-03-30 | 1 | -3/+3 | |
| | | | | | | ||||||
* | | | | | | Use new hash style in doc examples [ci skip] | Carlos Antonio da Silva | 2013-03-30 | 1 | -2/+2 | |
| |_|_|_|/ |/| | | | | ||||||
* | | | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-03-30 | 9 | -35/+60 | |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb activerecord/test/cases/adapter_test.rb guides/source/testing.md [ci skip] | |||||
| * | | | | | explain method invertible_for [ci skip] | Neeraj Singh | 2013-03-29 | 1 | -1/+2 | |
| | | | | | | ||||||
| * | | | | | Fix typo | Carson McDonald | 2013-03-22 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] |