aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
diff options
context:
space:
mode:
authorMike Mangino <mmangino@elevatedrails.com>2013-04-02 11:45:14 -0400
committerMike Mangino <mmangino@elevatedrails.com>2013-04-02 11:45:14 -0400
commit1bf6b53aa4de9267dcca42382d841cf96e98b55f (patch)
treeee41fe697ec160226486bbcae7233107c3bd6300 /activerecord/lib
parenta4743960a09139c3bd4d72a8f3a72ade8f4add2f (diff)
downloadrails-1bf6b53aa4de9267dcca42382d841cf96e98b55f.tar.gz
rails-1bf6b53aa4de9267dcca42382d841cf96e98b55f.tar.bz2
rails-1bf6b53aa4de9267dcca42382d841cf96e98b55f.zip
Remove all error masking when decoding serialized data fails?
Diffstat (limited to 'activerecord/lib')
-rw-r--r--activerecord/lib/active_record/coders/yaml_column.rb21
1 files changed, 8 insertions, 13 deletions
diff --git a/activerecord/lib/active_record/coders/yaml_column.rb b/activerecord/lib/active_record/coders/yaml_column.rb
index 1aa82f20d6..d3d7396c91 100644
--- a/activerecord/lib/active_record/coders/yaml_column.rb
+++ b/activerecord/lib/active_record/coders/yaml_column.rb
@@ -23,20 +23,15 @@ module ActiveRecord
def load(yaml)
return object_class.new if object_class != Object && yaml.nil?
return yaml unless yaml.is_a?(String) && yaml =~ /^---/
- begin
- obj = YAML.load(yaml)
-
- unless obj.is_a?(object_class) || obj.nil?
- raise SerializationTypeMismatch,
- "Attribute was supposed to be a #{object_class}, but was a #{obj.class}"
- end
- obj ||= object_class.new if object_class != Object
-
- obj
- rescue ArgumentError , Psych::SyntaxError => e
- raise if e.to_s =~ /undefined class/
- yaml
+ obj = YAML.load(yaml)
+
+ unless obj.is_a?(object_class) || obj.nil?
+ raise SerializationTypeMismatch,
+ "Attribute was supposed to be a #{object_class}, but was a #{obj.class}"
end
+ obj ||= object_class.new if object_class != Object
+
+ obj
end
end
end