aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Call `YAML.load` correctlyeileencodes2018-02-211-1/+1
| | | | | | | | | | | | | | | | | | | | We should call methods with `.method_name` not `::method_name`. Fix two instances of `YAML::load` I found in favor of `YAML.load`.
* | | | Merge pull request #32075 from eileencodes/delete-default-configurationEileen M. Uchitelle2018-02-211-4/+0
|\ \ \ \ | |_|_|/ |/| | | Delete default configuration
| * | | Delete default configurationeileencodes2018-02-211-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Because of this default configuration we're constantly checking if the database exists when looping through configurations. This is unnecessary and we should just delete it before we need to loop through configurations.
* | | | Use the query cache when connection is already connectedyuuji.yaginuma2018-02-191-6/+6
| |/ / |/| | | | | | | | Fixes #32021.
* | | Association scope's own order should be prioritized over through scope's orderRyuta Kamizono2018-02-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3acc5d6 was changed the order of scope evaluation from through scope to the association's own scope to be prioritized over the through scope. But the sorting order will be prioritized that is evaluated first. It is unintentional effect, association scope's sorting order should be prioritized as well. Fixes #32008.
* | | Revert "Delegate `uniq` to `records`"Ryuta Kamizono2018-02-181-1/+1
| | | | | | | | | | | | | | | | | | This reverts commit cf4f05a7d4a2051cf3593bc7c3a6a216e74e797a. Since Rails 6 requires Ruby 2.4.1+.
* | | Rails 6 requires Ruby 2.4.1+Jeremy Daer2018-02-171-1/+0
| | | | | | | | | | | | | | | | | | Skipping over 2.4.0 to sidestep the `"symbol_from_string".to_sym.dup` bug. References #32028
* | | Deprecate update_attributes and update_attributes!Eddie Lebow2018-02-172-1/+3
| | | | | | | | | | | | Closes #31998
* | | Partly revert 1e526788e6b1d3f42f4d8fdca20e588d42838c80bogdanvlviv2018-02-171-1/+3
| | | | | | | | | | | | | | | | | | Some attr_readers should be `protected` instead of `private` See https://travis-ci.org/rails/rails/builds/342800276
* | | Rails 6 requires Ruby 2.3+Jeremy Daer2018-02-1713-96/+44
| | |
* | | Fix frozen string concatenation by indicating that it's mutableRafael Mendonça França2018-02-161-2/+2
| | | | | | | | | | | | References 89bcca5
* | | Fix frozen string concatenation by indicating that it's mutableJeremy Daer2018-02-161-1/+1
| | | | | | | | | | | | References 89bcca59e91fa9da941de890012872e8288e77b0
* | | Remove usage of strip_heredoc in the framework in favor of <<~Rafael Mendonça França2018-02-167-18/+14
| | | | | | | | | | | | | | | Some places we can't remove because Ruby still don't have a method equivalent to strip_heredoc to be called in an already existent string.
* | | Add test parallelization to Railseileencodes2018-02-153-2/+42
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Provides both a forked process and threaded parallelization options. To use add `parallelize` to your test suite. Takes a `workers` argument that controls how many times the process is forked. For each process a new database will be created suffixed with the worker number; test-database-0 and test-database-1 respectively. If `ENV["PARALLEL_WORKERS"]` is set the workers argument will be ignored and the environment variable will be used instead. This is useful for CI environments, or other environments where you may need more workers than you do for local testing. If the number of workers is set to `1` or fewer, the tests will not be parallelized. The default parallelization method is to fork processes. If you'd like to use threads instead you can pass `with: :threads` to the `parallelize` method. Note the threaded parallelization does not create multiple database and will not work with system tests at this time. parallelize(workers: 2, with: :threads) The threaded parallelization uses Minitest's parallel exector directly. The processes paralleliztion uses a Ruby Drb server. For parallelization via threads a setup hook and cleanup hook are provided. ``` class ActiveSupport::TestCase parallelize_setup do |worker| # setup databases end parallelize_teardown do |worker| # cleanup database end parallelize(workers: 2) end ``` [Eileen M. Uchitelle, Aaron Patterson]
* | Add #create_or_find_by to lean on unique constraints (#31989)David Heinemeier Hansson2018-02-142-13/+43
| | | | | | Add #create_or_find_by to lean on unique constraints
* | Rdoc formatting fix: <b> instead of MD-style asterisksT.J. Schuck2018-02-141-1/+1
| | | | | | | | [ci skip]
* | Merge pull request #31133 from ↵Matthew Draper2018-02-111-0/+1
|\ \ | | | | | | | | | | | | mohsen-alizadeh/sanitize_empty_and_nil_parameters_passed_to_select sanitize empty and nil parameters to select #31059
| * | sanitize empty and nil parameters to selectMohsen Alizadeh2017-11-121-0/+1
| | |
* | | Fix formatting of `pick` [ci skip]yuuji.yaginuma2018-02-101-1/+1
| | |
* | | Add Relation#pick as short-hand for single-value plucks (#31941)David Heinemeier Hansson2018-02-091-0/+18
| | | | | | | | | * Add Relation#pick as short-hand for single-value plucks
* | | Fix marshaling of models with `has_many :through` associationsfatkodima2018-02-081-2/+2
| | |
* | | Revert "✂️"Ryuta Kamizono2018-02-071-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 487a1061cc496455dfe5ee84d1e49d509c1675b5. This `#--` is necessary for the doc of `distinct`. [ci skip]
* | | ✂️schneems2018-02-061-2/+1
| | |
* | | Invoke `load_schema` in `_default_attributes`Ryuta Kamizono2018-02-061-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently `_default_attributes` doesn't work unless `load_schema` is called before. The `MissingAttributeError` is caused by `reload_schema_from_cache` is invoked by `serialize`. I added `load_schema` in `_default_attributes` to `_default_attributes` works without any dependency like `attribute_types` etc. Closes #31905.
* | | Don't output information on drop if not verboseeileencodes2018-02-051-1/+1
| | | | | | | | | | | | | | | Followup to b988ecb, when I cherry-picked from my parallel testing branch I didn't realize `drop` wasn't part of the commit.
* | | Add ability to turn off verbose for database taskseileencodes2018-02-051-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | You could use the `VERBOSE` env var to turn off output for migrations tasks but you couldn't use it for other tasks. This change moves the `verbose?` check to a method so we can also use it in create and drop respectively. tenderlove and I noticed this as part of the ongoing work in parallel testing. When the parallel tests boot the app needs to create new databases for each worker. The output from these is unnecessary but there was previously no way to turn it off. Now if `VERBOSE=false` is passes to `bin/rails db:create` the text "Created blah blah db" will no longer be output.
* | | Prefer `@connection.abandon_results!` than `@connection.next_result while ↵Ryuta Kamizono2018-02-041-1/+1
| | | | | | | | | | | | @connection.more_results?`
* | | Add nodoc to `migrations_paths` and `migration_context` in `AbstractAdapter`Ryuta Kamizono2018-02-041-2/+2
| | | | | | | | | | | | | | | | | | These are internally used only. [ci skip]
* | | Fix `Unknown migration version "6.0"`Yuji Yaginuma2018-01-311-1/+4
| | |
* | | Start Rails 6.0 development!!!Rafael Mendonça França2018-01-301-3/+3
| | | | | | | | | | | | :tada::tada::tada:
* | | Remove unused `require "active_record/tasks/database_tasks"`Ryuta Kamizono2018-01-301-1/+0
| | |
* | | Merge pull request #31814 from fatkodima/index-nulls-orderRafael França2018-01-291-2/+6
|\ \ \ | | | | | | | | Dump correctly index nulls order for PostgreSQL
| * | | Dump correctly index nulls order for postgresqlfatkodima2018-01-281-2/+6
| | | |
* | | | Merge pull request #31821 from composerinteralia/extra-to_sGeorge Claghorn2018-01-298-9/+9
|\ \ \ \ | | | | | | | | | | Avoid extra calls to to_s
| * | | | Avoid extra calls to to_sDaniel Colson2018-01-298-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With #31615 `type_for_attribute` accepts either a symbol as well as a string. `has_attribute?` and `attribute_alias` also accept either. Since these methods call `to_s` on the argument, we no longer need to do that at the call site.
* | | | | Deprecate `expand_hash_conditions_for_aggregates`Ryuta Kamizono2018-01-291-0/+1
|/ / / / | | | | | | | | | | | | | | | | This can not expand an array of aggregated objects correctly, and is no longer used internally since 159b21b5.
* | | | Fix the example of 'finding records by a value object' (#31818)Bogdan2018-01-291-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This example was added in abdf546ad6d02ecb95766e73cd3c645a48c954de but was inconsistent with `composed_of :balance` definition in the 'Customer'. [Ryuta Kamizono & bogdanvlviv] [ci skip]
* | | | Extract `discard_remaining_results` for mysql2 adapterRyuta Kamizono2018-01-292-4/+6
| | | |
* | | | Revert "Merge pull request #23256 from pauloancheta/master"Ryuta Kamizono2018-01-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 755f7b58953c25790eea0574ff8928033ded2d88, reversing changes made to 35db4603095e8ccc0a92d925a42d4b3d9462580f. Originally `mapping: %w(balance amount)` is correct mapping example. Closes #31346. [Ryuta Kamizono & bogdanvlviv] [ci skip]
* | | | Remove unused/missing `to_money` converter in the test/docRyuta Kamizono2018-01-291-2/+1
| | | |
* | | | Merge pull request #31615 from cben/type_for_attribute-symbolRyuta Kamizono2018-01-291-1/+2
|\ \ \ \ | | | | | | | | | | Allow type_for_attribute(:symbol)
| * | | | Allow type_for_attribute(:symbol)Beni Cherniavsky-Paskin2018-01-011-1/+2
| | | | | | | | | | | | | | | | | | | | Closes #31611.
* | | | | Fix expanding an array of `composed_of` objects which have multiple mappingsRyuta Kamizono2018-01-293-1/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up of #31724. If `composed_of` objects have multiple mappings, array predicate handler can not correctly handle the expanded condition. We need to handle it like polymorphic association objects.
* | | | | Merge pull request #31724 from orekyuu/fix-expand-composed-object-arrayRyuta Kamizono2018-01-291-3/+5
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Fix not expanded problem when passing an Array object as argument to the where method using composed_of column.
| * | | | | Allow expanding an array of `composed_of` objectsRyuta Kamizono2018-01-291-6/+4
| | | | | |
| * | | | | Fix not expanded problem when passing an Array object as argument to the ↵orekyuu2018-01-261-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | where method using composed_of column. Fixes #31723 ``` david_balance = customers(:david).balance Customer.where(balance: [david_balance]).to_sql # Before: WHERE `customers`.`balance` = NULL # After : WHERE `customers`.`balance` = 50 ```
* | | | | | Define `supports_foreign_tables?` in AbstractAdapterYasuo Honda2018-01-281-0/+5
| |_|/ / / |/| | | |
* | | | | Use assert_predicate and assert_not_predicateDaniel Colson2018-01-251-3/+3
| | | | |
* | | | | Bring back ability to insert zero value on primary key for fixtures (#31795)Ryuta Kamizono2018-01-263-22/+8
|/ / / / | | | | | | | | | | | | | | | | | | | | Since #29504, mysql2 adapter lost ability to insert zero value on primary key due to enforce `NO_AUTO_VALUE_ON_ZERO` disabled. That is for using `DEFAULT` on auto increment column, but we can use `NULL` instead in that case.
* | | | Update note on MySQL index order support [ci skip]Eugene Kenny2018-01-261-1/+1
| | | | | | | | | | | | | | | | | | | | MySQL supports descending indexes from 8.0.1 onwards: https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-1.html
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 06:55:24 +0000