diff options
author | Eddie Lebow <elebow@users.noreply.github.com> | 2018-02-14 21:33:02 -0500 |
---|---|---|
committer | Jeremy Daer <jeremydaer@gmail.com> | 2018-02-17 13:58:54 -0800 |
commit | 5645149d3a27054450bd1130ff5715504638a5f5 (patch) | |
tree | 86605ba3daab883939eda991d6f975c07cdff681 /activerecord/lib | |
parent | 56278a7a1e2efcf080259459f4f0ab40f29b1fca (diff) | |
download | rails-5645149d3a27054450bd1130ff5715504638a5f5.tar.gz rails-5645149d3a27054450bd1130ff5715504638a5f5.tar.bz2 rails-5645149d3a27054450bd1130ff5715504638a5f5.zip |
Deprecate update_attributes and update_attributes!
Closes #31998
Diffstat (limited to 'activerecord/lib')
-rw-r--r-- | activerecord/lib/active_record/internal_metadata.rb | 2 | ||||
-rw-r--r-- | activerecord/lib/active_record/persistence.rb | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/internal_metadata.rb b/activerecord/lib/active_record/internal_metadata.rb index 5a65edf27e..3626a13d7c 100644 --- a/activerecord/lib/active_record/internal_metadata.rb +++ b/activerecord/lib/active_record/internal_metadata.rb @@ -17,7 +17,7 @@ module ActiveRecord end def []=(key, value) - find_or_initialize_by(key: key).update_attributes!(value: value) + find_or_initialize_by(key: key).update!(value: value) end def [](key) diff --git a/activerecord/lib/active_record/persistence.rb b/activerecord/lib/active_record/persistence.rb index a45d011d75..88b971327b 100644 --- a/activerecord/lib/active_record/persistence.rb +++ b/activerecord/lib/active_record/persistence.rb @@ -418,6 +418,7 @@ module ActiveRecord end alias update_attributes update + deprecate :update_attributes # Updates its receiver just like #update but calls #save! instead # of +save+, so an exception is raised if the record is invalid and saving will fail. @@ -431,6 +432,7 @@ module ActiveRecord end alias update_attributes! update! + deprecate :update_attributes! # Equivalent to <code>update_columns(name => value)</code>. def update_column(name, value) |