aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record
Commit message (Collapse)AuthorAgeFilesLines
* Break conditional branches into separate methodseileencodes2014-09-011-35/+52
| | | | | | | | | | | | | | | | | | This breaks the two branches of the `if reflection.last` and `else` to clearer see where the two methods can be refactored. Eventually we hope to remove the need for these separated methods altogether. Move the first branch outside the loop This code doesn't need to be in the loop because it it always affects the last chain. `get_bind_values` and `add_constraints` must match in this context because `get_bind_values` is the caching of `add_constraints` Use each_cons to remove need for `chain[i + 1]` The `chain[i + 1]` is confusing because it's not immediately obvious what it's trying to achieve. The use of `each_cons` makes it clear we need to get the `next_reflection`.
* Merge pull request #16704 from ankit1910/use-existing-methodRafael Mendonça França2014-09-011-1/+1
|\ | | | | use self instead of #read_attribute
| * use self instead of #read_attributeankit19102014-08-261-1/+1
| |
* | MySQL: set connection collation along with the charsetJeremy Kemper2014-08-301-1/+5
| | | | | | | | | | | | | | | | | | | | Sets the connection collation to the database collation configured in database.yml. Otherwise, `SET NAMES utf8mb4` will use the default collation for that charset (utf8mb4_general_ci) when you may have chosen a different collation, like utf8mb4_unicode_ci. This only applies to literal string comparisons, not column values, so it is unlikely to affect you.
* | Refer to the library name instead of the constantRobin Dupret2014-08-301-1/+1
| | | | | | | | | | | | | | | | | | When we are loading a component and we want to know its version, we are actually not speaking about the constant but the library itself. [ci skip] [Godfrey Chan & Xavier Noria]
* | Forgot to set Migration.verbose at f8d9a51949d6f6cfcab7cc7d501e137836eb88dc ↵Akira Matsuda2014-08-301-1/+1
| | | | | | | | :bomb:
* | Merge branch 'master' of github.com:rails/railsDavid Heinemeier Hansson2014-08-2921-110/+201
|\ \
| * | Don't allow AR::Tasks::DatabaseTasks.migrate to mutate Migration.verbose valueAkira Matsuda2014-08-301-1/+3
| | | | | | | | | | | | This fixes random test failure in migrator_test.rb
| * | [ci skip] Fix example code of ActiveRecord::FixtureSet.context_classyuuji.yaginuma2014-08-291-1/+1
| | |
| * | Avoid using heredoc for user warningsGodfrey Chan2014-08-2810-61/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using heredoc would enforce line wrapping to whatever column width we decided to use in the code, making it difficult for the users to read on some consoles. This does make the source code read slightly worse and a bit more error-prone, but this seems like a fair price to pay since the primary purpose for these messages are for the users to read and the code will not stick around for too long.
| * | make it easy to copy & paste the config from deprecation warning.Yves Senn2014-08-281-2/+3
| | | | | | | | | | | | [ci skip]
| * | Merge pull request #16702 from sgrif/sg-binary-serializedRafael Mendonça França2014-08-272-0/+15
| |\ \ | | | | | | | | Correctly detect mutation on serialized columns mapping to binary
| | * | Correctly detect mutation on serialized columns mapping to binarySean Griffin2014-08-272-0/+15
| | | | | | | | | | | | | | | | Fixes #16701
| * | | [ci skip] Updated documentation syntax of other parameter for rdocTom Kadwill2014-08-271-1/+1
| | | |
| * | | Merge pull request #16705 from tomkadwill/documented_many_block_paramZachary Scott2014-08-261-1/+1
| |\ \ \ | | | | | | | | | | [ci skip] Updated documentation syntax of block parameter for rdoc
| | * | | [ci skip] Updated documentation syntax of block parameter for rdoc Tom Kadwill2014-08-261-1/+1
| | | | |
| * | | | [ci skip] Updated include to reference record parameter for rdocTom Kadwill2014-08-261-1/+1
| |/ / /
| * / / [ci skip] Updated documentation syntax of block parameter for rdocTom Kadwill2014-08-261-1/+1
| |/ /
| * | [ci skip] Added documentation for has_and_belongs_to_many extension parameterTom Kadwill2014-08-261-0/+15
| | |
| * | Merge pull request #16646 from sgrif/sg-perf-regressionJeremy Kemper2014-08-251-1/+20
| |\ \ | | | | | | | | Cache the value of `changed_attributes` when calling `changes_applied`
| | * | Cache the value of `changed_attributes` when calling `changes_applied`Sean Griffin2014-08-221-1/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | `changes_applied` calles `changes`, which will call `changed_attributes` multiple times in a loop. This method actually performs work now, so we should cache the results while looping over it when we know it cannot change.
| * | | Override #find_by! in core to enable AST cachingGodfrey Chan2014-08-251-0/+4
| | | |
| * | | Fixed find_by("sql fragment without bindings") on masterGodfrey Chan2014-08-251-1/+1
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Also duplicated find_by tests from relations_test.rb to finder_test.rb now that we have a completely different implementation on the class (in core.rb with AST caching stuff). * Also removed a (failing) test that used mocks. Now that we have tests for the behavior, there's no point having another test that tests the implementation (that it delegates). Further, what the test was implying is nolonger true with the current implementation, because Class.find_by is a real method now.
| * | pg, `default_sequence_name` needs to return a string.Yves Senn2014-08-251-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is a reacon to https://github.com/rails/rails/commit/d6c1205584b1ba597db4071b168681678b1e9875#commitcomment-7502487 This backwards incompatibility was introduced with d6c12055 to fix #7516. However both `connection.default_sequence_name` and `model.sequence_name` are public API. The PostgreSQL adapter should honor the interface and return strings. /cc @matthewd @chancancode
| * | Fix a few typos [ci skip]Robin Dupret2014-08-241-1/+1
| | |
| * | Merge pull request #16675 from tomkadwill/has_many_documenting_extension_paramSantiago Pastorino2014-08-241-0/+14
| |\ \ | | | | | | | | [ci skip] Added documentation for has_many extension parameter
| | * | [ci skip] Added documentation for has_many extension parameterTom Kadwill2014-08-241-0/+14
| | | |
| * | | CHANGELOG & improvements to #16649Godfrey Chan2014-08-231-2/+2
| | | | | | | | | | | | | | | | | | | | * Require either FIRST or LAST qualifier for "NULLS ..." * Require whitespace before "NULLS ..."
| * | | Don't trim excess whitespace in pg #columns_for_distinctAgis-2014-08-241-1/+2
| | |/ | |/| | | | | | | Fixes #16623 introduced by https://github.com/rails/rails/commit/3d5a2019bcccc6fb01bee4811ca669f4383edb51
| * | Merge pull request #15932 from joseluistorres/issue-11957-uuidsRafael Mendonça França2014-08-221-0/+2
| |\ \ | | | | | | | | adding the exception RecordNotFound to UUID find #11957
| | * | adding the exception RecordNotFound to UUID findJoseLuis Torres2014-08-211-0/+2
| | | |
| * | | Don't calculate in-place changes twiceSean Griffin2014-08-221-8/+0
| | |/ | |/| | | | | | | | | | | | | Now that `changed_attributes` includes in place changes, we don't need to override these methods in Active Record. Partially fixes the performance regression caused by #16189
| * | [ci skip] Added documentation for has_and_belongs_to_many scope parameterTom Kadwill2014-08-221-0/+12
| | |
| * | Merge pull request #16204 from jonatack/patch-7Vijay Dev2014-08-211-12/+14
| |\ \ | | | | | | | | Fix minor typos and improve grammar and code formatting
| | * | Grammar passJon Atack2014-08-191-12/+14
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip] Add improvements from @eileencodes [skip ci]
| * | | [ci skip] Added documentation for has_one scope parameterTom Kadwill2014-08-211-0/+11
| | |/ | |/|
| * | Merge pull request #16593 from aditya-kapoor/add-doc-for-stepZachary Scott2014-08-201-3/+6
| |\ \ | | | | | | | | [ci skip] add doc for STEP in migration
| | * | [ci skip] add doc for STEP in migrationAditya Kapoor2014-08-211-3/+6
| | | |
| * | | Merge pull request #16575 from tomkadwill/added_has_many_scope_documentationZachary Scott2014-08-201-0/+11
| |\ \ \ | | |/ / | |/| | [ci skip] Added documentation for has_many scope parameter
| | * | [ci skip] Added documentation for has_many scope parameterTom Kadwill2014-08-201-0/+11
| | | |
| * | | [ci skip] correct docs about the migration generationAditya Kapoor2014-08-211-9/+2
| | | |
| * | | Merge pull request #16172 from Agis-/hmt_scope_arityRafael Mendonça França2014-08-201-1/+5
| |\ \ \ | | | | | | | | | | has_many :through with dynamic condition merging
| | * | | Only merge scopes with zero arity in has_many throughAgis-2014-08-201-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with dynamic conditions. Fixes #16128 This bug was introduced in https://github.com/rails/rails/commit/c35e438620f2d56562251571377995359546393d so it's present from 4.1.2-rc1 and after. https://github.com/rails/rails/commit/c35e438620f2d56562251571377995359546393d merges any relation scopes passed as proc objects to the relation, but does *not* take into account the arity of the lambda. To reproduce: https://gist.github.com/Agis-/5f1f0d664d2cd08dfb9b
| * | | | Merge pull request #16145 from phoet/patch-2Rafael Mendonça França2014-08-201-5/+5
| |\ \ \ \ | | |_|/ / | |/| | | don't log errors when all is fine
| | * | | don't log errors when all is finePeter Schröder2014-07-171-5/+5
| | | | |
| * | | | [ci skip] "..enables interrorgating of [thing].." would be correctZachary Scott2014-08-191-1/+1
| | |/ / | |/| |
* / | | Preparing for 4.2.0.beta1 releaseDavid Heinemeier Hansson2014-08-191-1/+1
|/ / /
* | | Merge pull request #16475 from tomkadwill/has_many_scope_documentationZachary Scott2014-08-191-0/+11
|\ \ \ | | | | | | | | [ci skip] Added documentation for belongs_to scope parameter
| * | | [ci skip] Added documentation for belongs_to scope parameterTom Kadwill2014-08-191-0/+11
| | | |
* | | | Merge pull request #16349 from jmcnevin/masterRafael Mendonça França2014-08-191-9/+8
|\ \ \ \ | | | | | | | | | | Correctly determine if migration is needed.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-03 04:18:26 +0000