aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record
diff options
context:
space:
mode:
authorAgis- <corestudiosinc@gmail.com>2014-08-23 00:26:16 +0300
committerAgis- <corestudiosinc@gmail.com>2014-08-24 04:35:05 +0300
commit291fece47a954eb986816a89164bda599d54db46 (patch)
treea31fdefdf8b02c81eb29cc82ccaf198084ed3d6d /activerecord/lib/active_record
parent33c05363e2ed52aa8bdbf5ebf9ee5226ab85ecbc (diff)
downloadrails-291fece47a954eb986816a89164bda599d54db46.tar.gz
rails-291fece47a954eb986816a89164bda599d54db46.tar.bz2
rails-291fece47a954eb986816a89164bda599d54db46.zip
Don't trim excess whitespace in pg #columns_for_distinct
Fixes #16623 introduced by https://github.com/rails/rails/commit/3d5a2019bcccc6fb01bee4811ca669f4383edb51
Diffstat (limited to 'activerecord/lib/active_record')
-rw-r--r--activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb3
1 files changed, 2 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb b/activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb
index 7042817672..6d5270cfc6 100644
--- a/activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb
+++ b/activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb
@@ -549,7 +549,8 @@ module ActiveRecord
# Convert Arel node to string
s = s.to_sql unless s.is_a?(String)
# Remove any ASC/DESC modifiers
- s.gsub(/\s+(?:ASC|DESC)?\s*(?:NULLS\s+(?:FIRST|LAST)\s*)?/i, '')
+ s.gsub(/\s+(?:ASC|DESC)\s*/i, '')
+ .gsub(/\s*NULLS\s+(?:FIRST|LAST)?\s*/i, '')
}.reject(&:blank?).map.with_index { |column, i| "#{column} AS alias_#{i}" }
[super, *order_columns].join(', ')