Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | CollectionProxy < Relation | Jon Leighton | 2012-05-11 | 3 | -28/+33 |
| | | | | | | | | | | | | | | | | | | | | | This helps bring the interfaces of CollectionProxy and Relation closer together, and reduces the delegation backflips we need to perform. For example, first_or_create is defined thus: class ActiveRecord::Relation def first_or_create(...) first || create(...) end end If CollectionProxy < Relation, then post.comments.first_or_create will hit the association's #create method which will actually add the new record to the association, just as post.comments.create would. With the previous delegation, post.comments.first_or_create expands to post.comments.scoped.first_or_create, where post.comments.scoped has no knowledge of the association. | ||||
* | Return false for exists? with new records - fixes #6199. | Andrew White | 2012-05-10 | 1 | -2/+1 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-08 | 1 | -2/+2 |
|\ | |||||
| * | SpawnMethods#merge returns the intersection when passed an array, and not ↵ | Mitch Crowe | 2012-05-05 | 1 | -2/+2 |
| | | | | | | | | the union. Update the documentation to reflect this. | ||||
* | | Use `take` instead of `first` to avoid unwanted implicit ordering (fixes #6147) | Marcelo Silveira | 2012-05-05 | 1 | -4/+4 |
|/ | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-04 | 1 | -1/+1 |
|\ | |||||
| * | Lowercase. | Ben Pickles | 2012-05-01 | 1 | -1/+1 |
| | | |||||
* | | clean up implementation of dynamic methods. use method compilation etc. | Jon Leighton | 2012-05-04 | 1 | -41/+0 |
| | | |||||
* | | Use arel nodes instead of raw sql | Marcelo Silveira | 2012-05-02 | 1 | -3/+3 |
| | | |||||
* | | Use Array#first instead of Array#[0] | Marcelo Silveira | 2012-05-02 | 1 | -5/+5 |
| | | |||||
* | | Introducing `take` as a replacement to the old behavior of `first` | Marcelo Silveira | 2012-05-02 | 1 | -0/+27 |
| | | |||||
* | | Document `last`, check for primary key on default order and use quoted table ↵ | Marcelo Silveira | 2012-05-02 | 1 | -2/+5 |
| | | | | | | | | and column names | ||||
* | | Made `first` finder consistent among database engines by adding a | Marcelo Silveira | 2012-05-02 | 1 | -2/+18 |
|/ | | | | default order clause (fixes #5103) | ||||
* | return value of block is returned | Aaron Patterson | 2012-04-30 | 1 | -2/+5 |
| | |||||
* | only yield to finder block if something is found | Aaron Patterson | 2012-04-30 | 1 | -1/+1 |
| | |||||
* | Add ActiveRecord::Base#ids | twinturbo | 2012-04-30 | 1 | -0/+10 |
| | |||||
* | fix interpolation for hash merging | Jon Leighton | 2012-04-25 | 2 | -20/+26 |
| | |||||
* | allow merging a single where value | Jon Leighton | 2012-04-25 | 1 | -1/+1 |
| | |||||
* | Add documentation to the SpawnMethods#merge method. | Mitch Crowe | 2012-04-17 | 1 | -0/+14 |
| | |||||
* | extract deprecated code for #find, #first, #last, #all | Jon Leighton | 2012-04-13 | 1 | -105/+36 |
| | |||||
* | extract deprecated #calculate code | Jon Leighton | 2012-04-13 | 1 | -83/+25 |
| | |||||
* | move code out to active_record_deprecated_finders | Jon Leighton | 2012-04-13 | 1 | -7/+2 |
| | |||||
* | now we can just manipulate the values hash in #only and #except | Jon Leighton | 2012-04-13 | 2 | -32/+5 |
| | |||||
* | use a hash to store relation values | Jon Leighton | 2012-04-13 | 3 | -30/+55 |
| | |||||
* | doesn't make sense for select! to take a block | Jon Leighton | 2012-04-13 | 1 | -8/+3 |
| | |||||
* | remove apply_finder_options call from AssociationScope | Jon Leighton | 2012-04-13 | 2 | -2/+2 |
| | |||||
* | Make Relation#extending work like other value methods | Jon Leighton | 2012-04-13 | 3 | -16/+9 |
| | |||||
* | Add Relation#merge! | Jon Leighton | 2012-04-13 | 1 | -9/+12 |
| | |||||
* | assert valid keys | Jon Leighton | 2012-04-13 | 1 | -0/+5 |
| | |||||
* | Allow Relation#merge to take a hash | Jon Leighton | 2012-04-13 | 2 | -46/+74 |
| | |||||
* | we have no need for the ASSOCIATION_METHODS constant | Jon Leighton | 2012-04-13 | 2 | -3/+3 |
| | |||||
* | refactoring | Jon Leighton | 2012-04-13 | 1 | -36/+45 |
| | |||||
* | Extract clusterfuck method for surgery | Jon Leighton | 2012-04-13 | 2 | -71/+92 |
| | |||||
* | mention that coercion only happens when the primary key is an integer and ↵ | Reg Braithwaite | 2012-04-12 | 1 | -2/+2 |
| | | | | use +to_i+ formatting | ||||
* | Documents that ActiveRecord's find by id uses to_i to coerce its arguments ↵ | Reg Braithwaite | 2012-04-12 | 1 | -1/+3 |
| | | | | to integers | ||||
* | Add bang versions of relation query methods. | Jon Leighton | 2012-04-12 | 1 | -84/+135 |
| | | | | | The main reason for this is that I want to separate the code that does the mutating from the code that does the cloning. | ||||
* | move apply_finder_options to active_record_deprecated_finders | Jon Leighton | 2012-04-12 | 1 | -22/+0 |
| | |||||
* | Add Relation#find_by and Relation#find_by! | Jon Leighton | 2012-03-30 | 1 | -0/+19 |
| | |||||
* | Remove Arel::Relation constant from PredicateBuilder. | Juanjo Bazán | 2012-03-27 | 1 | -2/+2 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-03-27 | 1 | -1/+1 |
|\ | |||||
| * | Missing generated query for pluck method. | Juanjo Bazán | 2012-03-27 | 1 | -1/+1 |
| | | | | | | (and changed the use of true for a more database agnostic example). | ||||
* | | Remove 'needless boolean casting'. | Jack Chen (chendo) | 2012-03-26 | 1 | -1/+1 |
|/ | | | | | "Predicates in Rails rely on standard Ruby semantics for boolean values and guarantee no singletons whatsoever." - @fxn | ||||
* | Remove IdentityMap | Carlos Antonio da Silva | 2012-03-13 | 1 | -10/+0 |
| | |||||
* | Add dynamic find_or_create_by_{attribute}! method. | Andrew White | 2012-03-12 | 1 | -1/+1 |
| | |||||
* | fix activerecord query_method regression with offset into Fixnum | Denis Jean | 2012-03-12 | 1 | -1/+1 |
| | | | | | | add test to show offset query_methods on mysql & mysql2 change test to cover public API | ||||
* | Merge pull request #5255 from carlosantoniodasilva/active-record-review | Piotr Sarnacki | 2012-03-03 | 1 | -14/+13 |
|\ | | | | | Refactor and cleanup in some ActiveRecord modules | ||||
| * | Refactor and cleanup in some ActiveRecord modules | Carlos Antonio da Silva | 2012-03-03 | 1 | -14/+13 |
| | | | | | | | | | | | | | | | | | | | | | | * Avoid double hash lookups in AR::Reflection when reflecting associations/aggregations * Minor cleanups: use elsif, do..end, if..else instead of unless..else * Simplify DynamicMatchers#respond_to? * Use "where" instead of scoped with conditions hash * Extract `scoped_by` method pattern regexp to constant * Extract noisy class_eval from method_missing in dynamic matchers * Extract readonly check, avoid calling column#to_s twice in persistence * Refactor predicate builder, remove some variables | ||||
* | | Merge pull request #4984 from raghunadhd/change_orderhash | Vijay Dev | 2012-03-03 | 1 | -1/+1 |
|\ \ | |/ |/| | Refactored code | ||||
| * | Refactored code | Raghunadh | 2012-02-10 | 1 | -1/+1 |
| | | |||||
* | | use bind values for join columns | Aaron Patterson | 2012-02-27 | 3 | -6/+10 |
| | |