diff options
| author | Jon Leighton <j@jonathanleighton.com> | 2012-04-13 13:15:23 +0100 |
|---|---|---|
| committer | Jon Leighton <j@jonathanleighton.com> | 2012-04-13 13:17:43 +0100 |
| commit | 7e0b6b25288c753071c0d36eea1772776b2fcc2a (patch) | |
| tree | 41a5eb615b1cf618cd6dc42d9fe90bfc8c8eae22 /activerecord/lib/active_record/relation | |
| parent | be89e9a35162b3015e2aee53300fdf04752652ce (diff) | |
| download | rails-7e0b6b25288c753071c0d36eea1772776b2fcc2a.tar.gz rails-7e0b6b25288c753071c0d36eea1772776b2fcc2a.tar.bz2 rails-7e0b6b25288c753071c0d36eea1772776b2fcc2a.zip | |
doesn't make sense for select! to take a block
Diffstat (limited to 'activerecord/lib/active_record/relation')
| -rw-r--r-- | activerecord/lib/active_record/relation/query_methods.rb | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/activerecord/lib/active_record/relation/query_methods.rb b/activerecord/lib/active_record/relation/query_methods.rb index ffca88f69f..6b7e03f9f7 100644 --- a/activerecord/lib/active_record/relation/query_methods.rb +++ b/activerecord/lib/active_record/relation/query_methods.rb @@ -99,14 +99,9 @@ module ActiveRecord end end - def select!(value = Proc.new) - if block_given? - # TODO: test - to_a.select! { |*block_args| value.call(*block_args) } - else - self.select_values += Array.wrap(value) - self - end + def select!(value) + self.select_values += Array.wrap(value) + self end def group(*args) |