Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | rescue from all exceptions in `ConnectionManagement#call` | Vipul A M | 2013-07-22 | 1 | -1/+1 |
| | | | | | | | | | Fixes #11497 As `ActiveRecord::ConnectionAdapters::ConnectionManagement` middleware does not rescue from Exception (but only from StandardError), the Connection Pool quickly runs out of connections when multiple erroneous Requests come in right after each other. Recueing from all exceptions and not just StandardError, fixes this behaviour. | ||||
* | Revert "Merge pull request #11120 from awilliams/ar_mysql2_boolean_quoting" | Yves Senn | 2013-07-17 | 2 | -6/+6 |
| | | | | | This reverts commit cb1d07e43926bcec95cb8b4a663ca9889173395a, reversing changes made to 754a373e301d2df0b12a11083405252722bc8366. | ||||
* | Move initializing process for query cache to ↵ | kennyj | 2013-07-16 | 2 | -2/+6 |
| | | | | ActiveRecord::ConnectionAdapters::QueryCache module. | ||||
* | Unifies mysql and mysql2 casting of booleans | awilliams | 2013-07-16 | 2 | -6/+6 |
| | | | | | Using the mysql2 adapter, boolean values were sometimes being incorrectly cast to 't' or 'f'. This changes the cast to match the mysql adapter behavior, ie 1 and 0. | ||||
* | `change_column` for PG adapter respects `:array` option. | Yves Senn | 2013-07-16 | 1 | -2/+3 |
| | |||||
* | Merge pull request #11174 from vipulnsward/remove_column_passing | Rafael Mendonça França | 2013-07-09 | 1 | -2/+2 |
|\ | | | | | Stop sending column info to `substitute_at` as it doesn't get utilized. | ||||
| * | Document where `column` param gets utilized in `substitute_at`. | Vipul A M | 2013-07-01 | 1 | -2/+2 |
| | | |||||
* | | Removed unsued deprecation require | Rashmi Yadav | 2013-07-04 | 1 | -1/+0 |
| | | |||||
* | | Remove deprecated nil-passing to `SchemaCache` methods. | Yves Senn | 2013-07-04 | 1 | -28/+8 |
| | | |||||
* | | Remove deprecated `transaction_joinable=` | Arun Agrawal | 2013-07-03 | 1 | -6/+0 |
| | | | | | | | | | | in favor of `begin_transaction` with `:joinable` option. | ||||
* | | Remove deprecated `decrement_open_transactions`. | Arun Agrawal | 2013-07-03 | 1 | -4/+0 |
| | | |||||
* | | removed deprecated increment_open_transactions | Arun Agrawal | 2013-07-03 | 1 | -4/+0 |
| | | |||||
* | | remove deprecated `PostgreSQLAdapter#outside_transaction?` method. | Yves Senn | 2013-07-03 | 1 | -7/+0 |
| | | |||||
* | | Removed deprecated method `columns_for_remove` | Neeraj Singh | 2013-07-03 | 1 | -6/+0 |
| | | |||||
* | | Remove deprecated SchemaStatements#distinct | Francesco Rodriguez | 2013-07-02 | 1 | -9/+0 |
| | | |||||
* | | Merge pull request #11230 from ↵ | Rafael Mendonça França | 2013-07-01 | 1 | -5/+0 |
|\ \ | | | | | | | | | | | | | frodsan/remove_deprecated_clear_stale_cached_connections_method Remove AR::Connection#clear_stale_cached_connections! deprecated method | ||||
| * | | Remove deprecated AR::Connection#clear_stale_cached_connections! method | Francesco Rodriguez | 2013-07-01 | 1 | -5/+0 |
| |/ | |||||
* / | Removed deprecated method type_cast_code from Column | Neeraj Singh | 2013-07-02 | 1 | -24/+0 |
|/ | |||||
* | Fix documents for create_join_table | Satoshi Ebisawa | 2013-06-21 | 1 | -2/+2 |
| | |||||
* | Merge pull request #10884 from dmarkow/pg_fix_default_quotes | Yves Senn | 2013-06-19 | 1 | -1/+1 |
|\ | | | | | Handle single quotes in PostgreSQL default column values | ||||
| * | Handle single quotes in PostgreSQL default column values | Dylan Markow | 2013-06-19 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | PostgreSQL escapes single quotes by using an additional single quote. When Rails queries the column information, PostgreSQL returns the default values with the escaped single quotes. #extract_value_from_default now converts these to one single quote each. Fixes #10881. | ||||
* | | regression test + mysql2 adapter raises correct error if conn is closed. | Yves Senn | 2013-06-15 | 1 | -3/+5 |
| | | |||||
* | | Merge pull request #10425 from ↵ | Rafael Mendonça França | 2013-06-13 | 4 | -38/+47 |
|\ \ | |/ |/| | | | | | ranjaykrishna/push_add_column_options_to_schema_creation Push add column options to schema creation | ||||
| * | Moving add_column_options! up to SchemaCreation | jeran | 2013-06-12 | 4 | -38/+47 |
| | | | | | | | | | | | | | | | | removed two instances of add_column_options! from abstract_mysql_adapter reworked rename_column_sql to remove add_column_options from schema_statements changed to use new hash syntax. | ||||
* | | Fixes #10432 add_column not creating array columns in PostgreSQL | Adam Anderson | 2013-06-04 | 1 | -0/+1 |
| | | | | | | | | | | | | When then PostgreSQL visitor was [added](https://github.com/rails/rails/commit/6b7fdf3bf3675a14eae74acc5241089308153a34) `add_column` was no longer receiving the column options directly. This caused the options to be lost along the way. | ||||
* | | Remove behavior that deals with a string as third argument of `add_index`, ↵ | kennyj | 2013-06-02 | 1 | -28/+14 |
| | | | | | | | | | | | | because this was deprecated. Some testcases is failed, so I replaced nil to empty hash in add_reference. | ||||
* | | Merge pull request #10619 from alno/top_level_array_in_postgres_json | Aaron Patterson | 2013-05-16 | 2 | -1/+3 |
|\ \ | | | | | | | Support array as root element in Postgresql JSON columns | ||||
| * | | Support array as root element in JSON | Alexey Noskov | 2013-05-14 | 2 | -1/+3 |
| | | | |||||
* | | | tiny types should only be integers when the length is <= 1. fixes #10620 | Aaron Patterson | 2013-05-15 | 1 | -3/+9 |
| | | | |||||
* | | | Also support extensions in PostgreSQL 9.1, because this has been supported ↵ | kennyj | 2013-05-15 | 1 | -4/+4 |
|/ / | | | | | | | since 9.1. | ||||
* | | Merge pull request #10556 from Empact/deprecate-schema-statements-distinct | Rafael Mendonça França | 2013-05-12 | 1 | -1/+2 |
| | | | | | | | | | | | | Deprecate SchemaStatements#distinct, and make SchemaStatements#columns_for_distinct nodoc. Conflicts: activerecord/CHANGELOG.md | ||||
* | | Merge pull request #10572 from nertzy/dont-modify-options-hash-in-primary-key | Rafael Mendonça França | 2013-05-11 | 1 | -2/+1 |
| | | | | | | | | Don't modify args in TableDefinition#primary_key | ||||
* | | Reject blank order_values within #columns_for_distinct, as the orders aren't ↵ | Ben Woosley | 2013-05-10 | 1 | -1/+1 |
| | | | | | | | | used at all on non-postgres adapters. | ||||
* | | Fix that #exists? can produce invalid SQL: "SELECT DISTINCT DISTINCT" | Ben Woosley | 2013-05-10 | 2 | -10/+13 |
| | | | | | | | | | | | | | | | | | | | | | | | | The combination of a :uniq => true association and the #distinct call in #construct_limited_ids_condition combine to create invalid SQL, because we're explicitly selecting DISTINCT, and also sending #distinct on to AREL, via the relation#distinct_value. Rather than build a select distinct clause in #construct_limited_ids_condition, I set #distinct! and pass just the columns into the select statement. This requires introducing a #columns_for_distinct method to return the select columns but not the statement itself. | ||||
* | | Revert "Merge pull request #10455 from ↵ | Aaron Patterson | 2013-05-07 | 1 | -6/+2 |
| | | | | | | | | | | | | | | patricksrobertson/bigserial_id_not_identifying_pk" This reverts commit 3043d45eefc3776d5f3a9e7d212a01f99d869ef8, reversing changes made to ca0275d36b395631725c4583db5a45c06443fdb9. | ||||
* | | Handle other pk types in PostgreSQL gracefully. | Patrick Robertson | 2013-05-07 | 1 | -2/+6 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | In #10410 it was noted that you can no longer create PK's with the type of bigserial in PostgreSQL in 4.0.0.rc1. This is mostly because the newer adapter is checking for column type with the id column instead of just letting it pass through like it did before. Side effects: You may just create a PK column of a type that you really don't want to be your PK. As far as I can tell this was allowed in 3.2.X and perhaps an exception should be raised if you try and do something extremely dumb. | ||||
* | | Changing method call according to coding conventions | Akshay Khole | 2013-05-05 | 1 | -1/+1 |
| | | |||||
* | | Make SchemaDumper emit "id: :uuid" when appropriate. Fixes #10451. | Brian Buchanan | 2013-05-03 | 1 | -1/+2 |
| | | |||||
* | | Add parameter :sslcompression to PostgreSQL adapter. | Lars Kanis | 2013-05-02 | 1 | -2/+2 |
| | | | | | | | | It is new in PostgreSQL-9.2 . | ||||
* | | Improve docs for postgresql with uuid primary keys [ci skip] | Carlos Antonio da Silva | 2013-05-01 | 1 | -8/+7 |
| | | | | | | | | Introduced in 09ac1776abc0d3482f491f2d49f47bcb3d9a4ad7. | ||||
* | | allow override of uuid_generate_v4() default by passing default: nil | Chad Moone | 2013-05-01 | 1 | -1/+30 |
| | | | | | | | | without this, it's not possible to use UUID primary keys without uuid-ossp installed and activated | ||||
* | | maintain return value for recreate_database | Aaron Patterson | 2013-04-30 | 1 | -1/+2 |
| | | |||||
* | | mysql needs to reconnect after recreate. Thanks @mperham | Aaron Patterson | 2013-04-30 | 1 | -0/+1 |
| | | |||||
* | | StatementInvalid takes WrappedDatabaseException's place | Jeremy Kemper | 2013-04-28 | 2 | -2/+2 |
| | | |||||
* | | Move method used only in the test to the test code itself | Ivan Kataitsev | 2013-04-25 | 1 | -8/+0 |
| | | |||||
* | | fix typos | Vipul A M | 2013-04-21 | 1 | -1/+1 |
| | | |||||
* | | Fix loading of fixtures when the column type is a postgres array of strings. | Chris Constantine | 2013-04-18 | 1 | -1/+1 |
| | | | | | | | | - A string in an array of strings that has a quote char (') needs to have that quote char escaped if the array is getting wrapped in quote chars. | ||||
* | | Revert "Merge pull request #10043 from cconstantine/master" | Rafael Mendonça França | 2013-04-18 | 1 | -15/+0 |
| | | | | | | | | | | | | | | This reverts commit 521035af530482d6d9ad2dae568eaeb0ab188e1c, reversing changes made to 222011dbee842bbc60d3aaaa3145356b90a30fd1. Reason: This broke the tests | ||||
* | | Merge pull request #10043 from cconstantine/master | Rafael Mendonça França | 2013-04-18 | 1 | -0/+15 |
|\ \ | | | | | | | DB with postgres string array column doesn't load fixtures well | ||||
| * | | Fix loading of string arrays in postgres | Chris Constantine | 2013-04-08 | 1 | -0/+15 |
| | | |