diff options
author | awilliams <pwnfactory@gmail.com> | 2013-06-26 14:47:50 +0200 |
---|---|---|
committer | awilliams <pwnfactory@gmail.com> | 2013-07-16 12:14:09 +0200 |
commit | 41bd94b7ef0db484268b8c81de528aedad5ae08d (patch) | |
tree | 0950817d31ee121bd6ca1eb019a0b1a4650d1593 /activerecord/lib/active_record/connection_adapters | |
parent | 754a373e301d2df0b12a11083405252722bc8366 (diff) | |
download | rails-41bd94b7ef0db484268b8c81de528aedad5ae08d.tar.gz rails-41bd94b7ef0db484268b8c81de528aedad5ae08d.tar.bz2 rails-41bd94b7ef0db484268b8c81de528aedad5ae08d.zip |
Unifies mysql and mysql2 casting of booleans
Using the mysql2 adapter, boolean values were sometimes being incorrectly cast
to 't' or 'f'. This changes the cast to match the mysql adapter behavior, ie 1 and 0.
Diffstat (limited to 'activerecord/lib/active_record/connection_adapters')
-rw-r--r-- | activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb | 6 | ||||
-rw-r--r-- | activerecord/lib/active_record/connection_adapters/mysql_adapter.rb | 6 |
2 files changed, 6 insertions, 6 deletions
diff --git a/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb b/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb index 5b25b26164..be42d7e3c6 100644 --- a/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb +++ b/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb @@ -272,6 +272,12 @@ module ActiveRecord QUOTED_FALSE end + def type_cast(value, column) + return super unless value == true || value == false + + value ? 1 : 0 + end + # REFERENTIAL INTEGRITY ==================================== def disable_referential_integrity(&block) #:nodoc: diff --git a/activerecord/lib/active_record/connection_adapters/mysql_adapter.rb b/activerecord/lib/active_record/connection_adapters/mysql_adapter.rb index 1826d88500..be0eb64efd 100644 --- a/activerecord/lib/active_record/connection_adapters/mysql_adapter.rb +++ b/activerecord/lib/active_record/connection_adapters/mysql_adapter.rb @@ -160,12 +160,6 @@ module ActiveRecord # QUOTING ================================================== - def type_cast(value, column) - return super unless value == true || value == false - - value ? 1 : 0 - end - def quote_string(string) #:nodoc: @connection.quote(string) end |