aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/connection_adapters
Commit message (Collapse)AuthorAgeFilesLines
* Use infinity constKonstantin Shabanov2013-08-221-2/+2
|
* Stop interpreting SQL 'string' columns as :string type.Ben Woosley2013-08-171-1/+1
| | | | | | | | SQL doesn't have a string type, and interpreting 'string' as text is contrary to at least SQLite3's behavior: "Note that a declared type of 'STRING' has an affinity of NUMERIC, not TEXT." http://www.sqlite.org/datatype3.html
* Rescue invalid ip address exceptions on assign.Paul Nikitochkin2013-08-141-1/+5
| | | | In order that set attribute should not be bang method
* Merge pull request #11838 from vipulnsward/drop_extra_varSteve Klabnik2013-08-121-2/+2
|\ | | | | drop extra variable
| * drop extra variableVipul A M2013-08-121-2/+2
| |
* | chmod -xAkira Matsuda2013-08-123-0/+0
|/
* Remove redundant `string_to_binary` from type-castingVipul A M2013-08-095-18/+4
|
* Merge pull request #11802 from ko1/fix_field_encoding_for_mysqlAaron Patterson2013-08-073-1/+14
|\ | | | | Set field encoding to client_encoding for mysql adapter.
| * Set field encoding to client_encoding for mysql adapter.Koichi Sasada2013-08-083-1/+14
| |
* | cast hstore values on write to be consistent with reading from the db.Yves Senn2013-08-082-4/+12
|/
* Merge pull request #11331 from vipulnsward/remove_conditionalAaron Patterson2013-08-071-8/+1
|\ | | | | Remove conditional, results are always an instance of `ActiveRecord::Result`
| * Remove conditional, since results are always an instance of ↵Vipul A M2013-07-061-8/+1
| | | | | | | | `ActiveRecord::Result`
* | Fix multidimensional PG arrays containing non-string itemsYves Senn2013-08-071-1/+9
| |
* | config[:database] should be a stringRafael Mendonça França2013-08-051-3/+3
| | | | | | | | | | This change was breaking the Railties tests. See https://travis-ci.org/rails/rails/jobs/9865969
* | Merge pull request #11762 from peterkovacs/patch-2Carlos Antonio da Silva2013-08-051-1/+1
|\ \ | | | | | | Free result_metadata directly instead of freeing 2nd, redundant call.
| * | Free result_metadata directly instead of freeing 2nd, redundant call.Peter Kovacs2013-08-051-1/+1
| | | | | | | | | `result_metadata` returns a new object each time it is called, so calling `result_metadata.free` is essentially a noop. Instead call `free` directly on the metadata when we're done with it.
* | | Create sqlite3 directory if not presentschneems2013-08-051-3/+5
|/ / | | | | | | | | | | | | | | | | | | | | If the `db/` directory is not present on a remote machine it will blow up in unexpected ways with error messages that do not indicate there is a missing directory: ``` SQLite3::CantOpenException: unable to open database file ``` This PR checks to see if a directory exists for the sqlite3 file and if not creates it for you. This PR is an alternative to #11692 as suggested by @josevalim
* | Merge pull request #11455 from antonio/fix_enable_extension_not_being_definedRafael Mendonça França2013-08-021-0/+8
|\ \ | | | | | | Define enable_extension method to prevent undefined method error
| * | Define enable_extension method to prevent undefined method errorAntonio Santos2013-08-021-0/+8
| | | | | | | | | | | | | | | | | | | | | When mixing postgresql and another adapter like sqlite3 (for dev and test respectively), the task `db:test:prepare` will fail due to the `enable_extension` method not being defined in the abstract adapter. This patch simply adds an empty definition to prevent it.
* | | Removed redundant xml override from pg adapterPaul Nikitochkin2013-08-021-7/+3
| | | | | | | | | | | | Closes: #11706
* | | Refactor `ArrayParser`Vipul A M2013-07-261-15/+22
| | | | | | | | | | | | | | | * Constantize parse token * Remove extra param passed to `parse_data`
* | | Fix indentation.kennyj2013-07-241-8/+8
| | |
* | | Simplify select_one method.kennyj2013-07-241-2/+1
| | | | | | | | | | | | | | | | | | The select_all method always returns ActiveRecord::Result instance, and the ActiveRecord::Result includes Enumerable mixin. If #empty?, #first method returns nil. Thus we can simplify this method.
* | | Uses mysql2 0.3.13 or laterkennyj2013-07-231-1/+1
| | |
* | | Defines the return type of select / select_all method.kennyj2013-07-232-6/+3
| | |
* | | rescue from all exceptions in `ConnectionManagement#call`Vipul A M2013-07-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #11497 As `ActiveRecord::ConnectionAdapters::ConnectionManagement` middleware does not rescue from Exception (but only from StandardError), the Connection Pool quickly runs out of connections when multiple erroneous Requests come in right after each other. Recueing from all exceptions and not just StandardError, fixes this behaviour.
* | | Revert "Merge pull request #11120 from awilliams/ar_mysql2_boolean_quoting"Yves Senn2013-07-172-6/+6
| | | | | | | | | | | | | | | This reverts commit cb1d07e43926bcec95cb8b4a663ca9889173395a, reversing changes made to 754a373e301d2df0b12a11083405252722bc8366.
* | | Move initializing process for query cache to ↵kennyj2013-07-162-2/+6
| | | | | | | | | | | | ActiveRecord::ConnectionAdapters::QueryCache module.
* | | Unifies mysql and mysql2 casting of booleansawilliams2013-07-162-6/+6
| | | | | | | | | | | | | | | Using the mysql2 adapter, boolean values were sometimes being incorrectly cast to 't' or 'f'. This changes the cast to match the mysql adapter behavior, ie 1 and 0.
* | | `change_column` for PG adapter respects `:array` option.Yves Senn2013-07-161-2/+3
|/ /
* | Merge pull request #11174 from vipulnsward/remove_column_passingRafael Mendonça França2013-07-091-2/+2
|\ \ | |/ |/| Stop sending column info to `substitute_at` as it doesn't get utilized.
| * Document where `column` param gets utilized in `substitute_at`.Vipul A M2013-07-011-2/+2
| |
* | Removed unsued deprecation requireRashmi Yadav2013-07-041-1/+0
| |
* | Remove deprecated nil-passing to `SchemaCache` methods.Yves Senn2013-07-041-28/+8
| |
* | Remove deprecated `transaction_joinable=`Arun Agrawal2013-07-031-6/+0
| | | | | | | | | | in favor of `begin_transaction` with `:joinable` option.
* | Remove deprecated `decrement_open_transactions`.Arun Agrawal2013-07-031-4/+0
| |
* | removed deprecated increment_open_transactionsArun Agrawal2013-07-031-4/+0
| |
* | remove deprecated `PostgreSQLAdapter#outside_transaction?` method.Yves Senn2013-07-031-7/+0
| |
* | Removed deprecated method `columns_for_remove`Neeraj Singh2013-07-031-6/+0
| |
* | Remove deprecated SchemaStatements#distinctFrancesco Rodriguez2013-07-021-9/+0
| |
* | Merge pull request #11230 from ↵Rafael Mendonça França2013-07-011-5/+0
|\ \ | | | | | | | | | | | | frodsan/remove_deprecated_clear_stale_cached_connections_method Remove AR::Connection#clear_stale_cached_connections! deprecated method
| * | Remove deprecated AR::Connection#clear_stale_cached_connections! methodFrancesco Rodriguez2013-07-011-5/+0
| |/
* / Removed deprecated method type_cast_code from ColumnNeeraj Singh2013-07-021-24/+0
|/
* Fix documents for create_join_tableSatoshi Ebisawa2013-06-211-2/+2
|
* Merge pull request #10884 from dmarkow/pg_fix_default_quotesYves Senn2013-06-191-1/+1
|\ | | | | Handle single quotes in PostgreSQL default column values
| * Handle single quotes in PostgreSQL default column valuesDylan Markow2013-06-191-1/+1
| | | | | | | | | | | | | | | | | | | | PostgreSQL escapes single quotes by using an additional single quote. When Rails queries the column information, PostgreSQL returns the default values with the escaped single quotes. #extract_value_from_default now converts these to one single quote each. Fixes #10881.
* | regression test + mysql2 adapter raises correct error if conn is closed.Yves Senn2013-06-151-3/+5
| |
* | Merge pull request #10425 from ↵Rafael Mendonça França2013-06-134-38/+47
|\ \ | |/ |/| | | | | ranjaykrishna/push_add_column_options_to_schema_creation Push add column options to schema creation
| * Moving add_column_options! up to SchemaCreationjeran2013-06-124-38/+47
| | | | | | | | | | | | | | | | removed two instances of add_column_options! from abstract_mysql_adapter reworked rename_column_sql to remove add_column_options from schema_statements changed to use new hash syntax.
* | Fixes #10432 add_column not creating array columns in PostgreSQLAdam Anderson2013-06-041-0/+1
| | | | | | | | | | | | When then PostgreSQL visitor was [added](https://github.com/rails/rails/commit/6b7fdf3bf3675a14eae74acc5241089308153a34) `add_column` was no longer receiving the column options directly. This caused the options to be lost along the way.