Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #11382 from kennyj/fix_10751-2 | Rafael Mendonça França | 2013-09-22 | 1 | -3/+6 |
|\ | | | | | | | | | | | | | Dump UUID default functions to schema.rb [2nd version]. Fixes #10751. Conflicts: activerecord/CHANGELOG.md | ||||
| * | Migration dump UUID default functions to schema.rb. Fixes #10751. | kennyj | 2013-07-10 | 1 | -3/+6 |
| | | |||||
* | | Disable prepared statements in the unprepared_statement block | Rafael Mendonça França | 2013-09-12 | 1 | -2/+3 |
| | | |||||
* | | Fix inverted conditional | Rafael Mendonça França | 2013-09-11 | 1 | -1/+1 |
| | | | | | | | | Oops, I should had run the tests | ||||
* | | Remove invalid comment | Rafael Mendonça França | 2013-09-11 | 1 | -4/+0 |
| | | | | | | | | This is not valid anymore after 08477a651648ba4417ded128aa37b9ae0dcbc9ce | ||||
* | | Check if the SQL is not a prepared statement | Rafael Mendonça França | 2013-09-11 | 8 | -7/+15 |
| | | | | | | | | | | | | | | | | | | When the adapter is with prepared statement disabled and the binds array is not empty the connection adapter will try to set the binds values and will fail. Now we are checking if the adapter has the prepared statement disabled. Fixes #12023 | ||||
* | | Revert "Do not dup the binds when visiting the AST" | Rafael Mendonça França + Kassio Borges | 2013-08-31 | 2 | -2/+3 |
| | | | | | | | | | | | | This reverts commit 71ff7d9c6592b93e2c810a1f464943dd7bd02c7f. Reason: I need to check with @jeremy if we can do this. | ||||
* | | Do not dup the binds when visiting the AST | Rafael Mendonça França | 2013-08-31 | 2 | -3/+2 |
| | | | | | | | | | | | | | | The visitor have to consume the bind parameters to make the statements work when the prepared statement option is disabled. Fixes #12023 | ||||
* | | Perf: fields in pg gem causes an allocation, cache it | Sam | 2013-08-27 | 1 | -2/+3 |
| | | |||||
* | | Merge pull request #11827 from vipulnsward/remove_extra_case | Santiago Pastorino | 2013-08-26 | 1 | -1/+0 |
|\ \ | | | | | | | Remove extra case. | ||||
| * | | Remove extra case. | Vipul A M | 2013-08-10 | 1 | -1/+0 |
| | | | |||||
* | | | PG adapter deals with negative money values formatted with parenthesis. | Yves Senn | 2013-08-26 | 1 | -0/+5 |
| | | | | | | | | | | | | Closes #11899. | ||||
* | | | Use infinity const | Konstantin Shabanov | 2013-08-22 | 1 | -2/+2 |
| | | | |||||
* | | | Stop interpreting SQL 'string' columns as :string type. | Ben Woosley | 2013-08-17 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | SQL doesn't have a string type, and interpreting 'string' as text is contrary to at least SQLite3's behavior: "Note that a declared type of 'STRING' has an affinity of NUMERIC, not TEXT." http://www.sqlite.org/datatype3.html | ||||
* | | | Rescue invalid ip address exceptions on assign. | Paul Nikitochkin | 2013-08-14 | 1 | -1/+5 |
| | | | | | | | | | | | | In order that set attribute should not be bang method | ||||
* | | | Merge pull request #11838 from vipulnsward/drop_extra_var | Steve Klabnik | 2013-08-12 | 1 | -2/+2 |
|\ \ \ | | | | | | | | | drop extra variable | ||||
| * | | | drop extra variable | Vipul A M | 2013-08-12 | 1 | -2/+2 |
| |/ / | |||||
* / / | chmod -x | Akira Matsuda | 2013-08-12 | 3 | -0/+0 |
|/ / | |||||
* | | Remove redundant `string_to_binary` from type-casting | Vipul A M | 2013-08-09 | 5 | -18/+4 |
| | | |||||
* | | Merge pull request #11802 from ko1/fix_field_encoding_for_mysql | Aaron Patterson | 2013-08-07 | 3 | -1/+14 |
|\ \ | | | | | | | Set field encoding to client_encoding for mysql adapter. | ||||
| * | | Set field encoding to client_encoding for mysql adapter. | Koichi Sasada | 2013-08-08 | 3 | -1/+14 |
| | | | |||||
* | | | cast hstore values on write to be consistent with reading from the db. | Yves Senn | 2013-08-08 | 2 | -4/+12 |
|/ / | |||||
* | | Merge pull request #11331 from vipulnsward/remove_conditional | Aaron Patterson | 2013-08-07 | 1 | -8/+1 |
|\ \ | | | | | | | Remove conditional, results are always an instance of `ActiveRecord::Result` | ||||
| * | | Remove conditional, since results are always an instance of ↵ | Vipul A M | 2013-07-06 | 1 | -8/+1 |
| | | | | | | | | | | | | `ActiveRecord::Result` | ||||
* | | | Fix multidimensional PG arrays containing non-string items | Yves Senn | 2013-08-07 | 1 | -1/+9 |
| | | | |||||
* | | | config[:database] should be a string | Rafael Mendonça França | 2013-08-05 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | This change was breaking the Railties tests. See https://travis-ci.org/rails/rails/jobs/9865969 | ||||
* | | | Merge pull request #11762 from peterkovacs/patch-2 | Carlos Antonio da Silva | 2013-08-05 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Free result_metadata directly instead of freeing 2nd, redundant call. | ||||
| * | | | Free result_metadata directly instead of freeing 2nd, redundant call. | Peter Kovacs | 2013-08-05 | 1 | -1/+1 |
| | | | | | | | | | | | | `result_metadata` returns a new object each time it is called, so calling `result_metadata.free` is essentially a noop. Instead call `free` directly on the metadata when we're done with it. | ||||
* | | | | Create sqlite3 directory if not present | schneems | 2013-08-05 | 1 | -3/+5 |
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the `db/` directory is not present on a remote machine it will blow up in unexpected ways with error messages that do not indicate there is a missing directory: ``` SQLite3::CantOpenException: unable to open database file ``` This PR checks to see if a directory exists for the sqlite3 file and if not creates it for you. This PR is an alternative to #11692 as suggested by @josevalim | ||||
* | | | Merge pull request #11455 from antonio/fix_enable_extension_not_being_defined | Rafael Mendonça França | 2013-08-02 | 1 | -0/+8 |
|\ \ \ | | | | | | | | | Define enable_extension method to prevent undefined method error | ||||
| * | | | Define enable_extension method to prevent undefined method error | Antonio Santos | 2013-08-02 | 1 | -0/+8 |
| | |/ | |/| | | | | | | | | | | | | | | | | When mixing postgresql and another adapter like sqlite3 (for dev and test respectively), the task `db:test:prepare` will fail due to the `enable_extension` method not being defined in the abstract adapter. This patch simply adds an empty definition to prevent it. | ||||
* | | | Removed redundant xml override from pg adapter | Paul Nikitochkin | 2013-08-02 | 1 | -7/+3 |
| | | | | | | | | | | | | Closes: #11706 | ||||
* | | | Refactor `ArrayParser` | Vipul A M | 2013-07-26 | 1 | -15/+22 |
| | | | | | | | | | | | | | | | * Constantize parse token * Remove extra param passed to `parse_data` | ||||
* | | | Fix indentation. | kennyj | 2013-07-24 | 1 | -8/+8 |
| | | | |||||
* | | | Simplify select_one method. | kennyj | 2013-07-24 | 1 | -2/+1 |
| | | | | | | | | | | | | | | | | | | The select_all method always returns ActiveRecord::Result instance, and the ActiveRecord::Result includes Enumerable mixin. If #empty?, #first method returns nil. Thus we can simplify this method. | ||||
* | | | Uses mysql2 0.3.13 or later | kennyj | 2013-07-23 | 1 | -1/+1 |
| | | | |||||
* | | | Defines the return type of select / select_all method. | kennyj | 2013-07-23 | 2 | -6/+3 |
| | | | |||||
* | | | rescue from all exceptions in `ConnectionManagement#call` | Vipul A M | 2013-07-22 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #11497 As `ActiveRecord::ConnectionAdapters::ConnectionManagement` middleware does not rescue from Exception (but only from StandardError), the Connection Pool quickly runs out of connections when multiple erroneous Requests come in right after each other. Recueing from all exceptions and not just StandardError, fixes this behaviour. | ||||
* | | | Revert "Merge pull request #11120 from awilliams/ar_mysql2_boolean_quoting" | Yves Senn | 2013-07-17 | 2 | -6/+6 |
| | | | | | | | | | | | | | | | This reverts commit cb1d07e43926bcec95cb8b4a663ca9889173395a, reversing changes made to 754a373e301d2df0b12a11083405252722bc8366. | ||||
* | | | Move initializing process for query cache to ↵ | kennyj | 2013-07-16 | 2 | -2/+6 |
| | | | | | | | | | | | | ActiveRecord::ConnectionAdapters::QueryCache module. | ||||
* | | | Unifies mysql and mysql2 casting of booleans | awilliams | 2013-07-16 | 2 | -6/+6 |
| | | | | | | | | | | | | | | | Using the mysql2 adapter, boolean values were sometimes being incorrectly cast to 't' or 'f'. This changes the cast to match the mysql adapter behavior, ie 1 and 0. | ||||
* | | | `change_column` for PG adapter respects `:array` option. | Yves Senn | 2013-07-16 | 1 | -2/+3 |
|/ / | |||||
* | | Merge pull request #11174 from vipulnsward/remove_column_passing | Rafael Mendonça França | 2013-07-09 | 1 | -2/+2 |
|\ \ | |/ |/| | Stop sending column info to `substitute_at` as it doesn't get utilized. | ||||
| * | Document where `column` param gets utilized in `substitute_at`. | Vipul A M | 2013-07-01 | 1 | -2/+2 |
| | | |||||
* | | Removed unsued deprecation require | Rashmi Yadav | 2013-07-04 | 1 | -1/+0 |
| | | |||||
* | | Remove deprecated nil-passing to `SchemaCache` methods. | Yves Senn | 2013-07-04 | 1 | -28/+8 |
| | | |||||
* | | Remove deprecated `transaction_joinable=` | Arun Agrawal | 2013-07-03 | 1 | -6/+0 |
| | | | | | | | | | | in favor of `begin_transaction` with `:joinable` option. | ||||
* | | Remove deprecated `decrement_open_transactions`. | Arun Agrawal | 2013-07-03 | 1 | -4/+0 |
| | | |||||
* | | removed deprecated increment_open_transactions | Arun Agrawal | 2013-07-03 | 1 | -4/+0 |
| | | |||||
* | | remove deprecated `PostgreSQLAdapter#outside_transaction?` method. | Yves Senn | 2013-07-03 | 1 | -7/+0 |
| | |