Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | `@quoted_{column,table}_names` should cache a frozen string | Ryuta Kamizono | 2016-07-28 | 1 | -1/+1 |
| | | | | | | | | | | | | | | Caching a mutable string causes the following issue. ``` Loading development environment (Rails 5.1.0.alpha) irb(main):001:0> ActiveRecord::Base.connection.quote_table_name('foo') << '!!' => "`foo`!!" irb(main):002:0> ActiveRecord::Base.connection.quote_table_name('foo') << '!!' => "`foo`!!!!" irb(main):003:0> ActiveRecord::Base.connection.quote_table_name('foo') << '!!' => "`foo`!!!!!!" ``` | ||||
* | Should keep quoting behaivor of a time column value in sqlite3 adapter | Ryuta Kamizono | 2016-04-15 | 1 | -0/+4 |
| | | | | | | | | | | | | | | | | | | | | Follow up to #24542. In MySQL and PostgreSQL, a time column value is saved as ignored the date part of it. But in SQLite3, a time column value is saved as a string. We should keep previous quoting behavior in sqlite3 adapter. ``` sqlite> CREATE TABLE "foos" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "start" time(0), "finish" time(4)); sqlite> INSERT INTO "foos" ("start", "finish") VALUES ('2000-01-01 12:30:00', '2000-01-01 12:30:00.999900'); sqlite> SELECT "foos".* FROM "foos"; 1|2000-01-01 12:30:00|2000-01-01 12:30:00.999900 sqlite> SELECT "foos".* FROM "foos" WHERE "foos"."start" = '2000-01-01 12:30:00' LIMIT 1; 1|2000-01-01 12:30:00|2000-01-01 12:30:00.999900 sqlite> SELECT "foos".* FROM "foos" WHERE "foos"."start" = '12:30:00' LIMIT 1; sqlite> ``` | ||||
* | Move `quoted_date`, `quote_string` and `quote_table_name_for_assignment` ↵ | Ryuta Kamizono | 2016-04-05 | 1 | -0/+8 |
| | | | | methods to `Quoting` module | ||||
* | Move `@quoted_{column|table}_names` cache up to the abstract adapter | Ryuta Kamizono | 2016-03-31 | 1 | -0/+4 |
| | |||||
* | Make to private the visibility of `_quote` and `_type_cast` | Ryuta Kamizono | 2016-03-30 | 1 | -0/+32 |