Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Revert "Roflscaling!" (for now) | Jon Leighton | 2011-12-02 | 1 | -6/+9 | |
| | | | | | | | | This reverts commit f6b5046305d43c5f64bcb6fed0e44f7bca99a603. Fear not, the roflscale will return when I have a bit more time and figure out a better way to do it. (In particular, a way that doesn't break the build.) | |||||
* | Fewer string allocations in attribute method | Jon Leighton | 2011-12-01 | 1 | -4/+4 | |
| | ||||||
* | Roflscaling! | Jon Leighton | 2011-12-01 | 1 | -9/+6 | |
| | | | | | Don't prefix the name with attribute_. Avoids a string allocation on read_attribute, which is a bit faster. | |||||
* | Create method with known identifier then alias into place. | Jon Leighton | 2011-12-01 | 1 | -25/+21 | |
| | | | | | | | | This means we never have to rely on define_method (which is slower and uses more memory), even when we have attributes containing characters that are not allowed in standard method names. (I am mainly changing this because the duplication annoys me, though.) | |||||
* | Remove some unnecessary code etc | Jon Leighton | 2011-12-01 | 1 | -7/+8 | |
| | ||||||
* | Add test for read_attribute(:id) with non-standard PK. | Jon Leighton | 2011-12-01 | 1 | -4/+4 | |
| | | | | | | | | Also make it actually work. It slows down all read_attribute accesses to map 'id' to whatever the PK actually is, inside read_attribute. So instead make sure the necessary methods are defined and that they redirect wherever they need to go. | |||||
* | Remove the need for type_cast_attribute. | Jon Leighton | 2011-12-01 | 1 | -31/+31 | |
| | | | | This is good because it reduces duplication. | |||||
* | Get rid of the underscore versions of attribute methods! | Jon Leighton | 2011-12-01 | 1 | -4/+0 | |
| | | | | This makes me happy! | |||||
* | Don't rely on underscore-prefixed attribute methods. | Jon Leighton | 2011-12-01 | 1 | -30/+61 | |
| | | | | | | Define singleton methods on the attributes module instead. This reduces method pollution on the actual model classes. It also seems to make something faster, I am unsure why! O_o | |||||
* | consistency | Jon Leighton | 2011-11-30 | 1 | -10/+10 | |
| | ||||||
* | Don't need second param | Jon Leighton | 2011-11-30 | 1 | -3/+3 | |
| | ||||||
* | No longer need to undef id as we are defining it ourselves | Jon Leighton | 2011-11-30 | 1 | -3/+0 | |
| | ||||||
* | Extract attribute serialization code into a separate module | Jon Leighton | 2011-11-30 | 1 | -28/+5 | |
| | ||||||
* | Use inheritance to avoid special-case code for the 'id' method | Jon Leighton | 2011-11-30 | 1 | -4/+0 | |
| | ||||||
* | Speed up attribute invocation by checking if both name and calls are compilable. | José Valim | 2011-11-14 | 1 | -1/+1 | |
| | ||||||
* | Revert "Raise error on unknown primary key." | Jon Leighton | 2011-10-05 | 1 | -3/+3 | |
| | | | | This reverts commit ee2be435b1e5c0e94a4ee93a1a310e0471a77d07. | |||||
* | Raise error on unknown primary key. | Jon Leighton | 2011-10-05 | 1 | -3/+3 | |
| | | | | | If we don't have a primary key when we ask for it, it's better to fail fast. Fixes GH #2307. | |||||
* | Add deprecation for doing `attribute_method_suffix ''` | Jon Leighton | 2011-09-13 | 1 | -2/+0 | |
| | ||||||
* | only calculate method name once | Aaron Patterson | 2011-06-30 | 1 | -2/+3 | |
| | ||||||
* | Remove extra white spaces on ActiveRecord docs. | Sebastian Martinez | 2011-05-23 | 1 | -1/+1 | |
| | ||||||
* | Avoid define_method if possible. | José Valim | 2011-04-19 | 1 | -1/+1 | |
| | ||||||
* | Return nil from read_attribute(:foo) if 'foo' is not present in the ↵ | Jon Leighton | 2011-04-15 | 1 | -1/+1 | |
| | | | | @attributes hash, but the _foo method has been defined. This brings the behaviour into line with the 3-0-stable branch and the master branch before 93641ed6c8c684f6b4db02b6c8a22fa9bc7f0eaf (there were previously no assertions about this which is why the change slipped through). Note that actually calling the 'foo' method will still raise an error if the attribute is not present. | |||||
* | Undo performances regressions I introduced in ↵ | Jon Leighton | 2011-04-15 | 1 | -5/+23 | |
| | | | | bbe0a507f287c20ab4ae8a244fbfc810665deda5 and add test for an edge case. Add comments to explain the intent of the code. | |||||
* | Remove unnecessary code from define_read_method and add assertion to make ↵ | Jon Leighton | 2011-04-15 | 1 | -7/+4 | |
| | | | | sure the underscored version is actually generated | |||||
* | Fixes performance issue introduced in 3.0.6 (issue #6695) | Stian Grytøyr | 2011-04-14 | 1 | -3/+5 | |
| | ||||||
* | use class_eval with a string when it's possible | Santiago Pastorino | 2011-03-22 | 1 | -3/+7 | |
| | ||||||
* | Allow to read and write AR attributes with non valid identifiers | Santiago Pastorino | 2011-03-22 | 1 | -1/+4 | |
| | ||||||
* | make sure de-serialization happens on object instantiation | Aaron Patterson | 2011-02-01 | 1 | -1/+1 | |
| | ||||||
* | move the coders to the serialized_attributes hash | Aaron Patterson | 2011-02-01 | 1 | -7/+3 | |
| | ||||||
* | use an identity conversion to avoid conditional codes | Aaron Patterson | 2011-01-28 | 1 | -2/+2 | |
| | ||||||
* | join the cult of cargo. reduce the number of NoMethodErrors in the system | Aaron Patterson | 2011-01-07 | 1 | -1/+1 | |
| | ||||||
* | no need for to_sym | Aaron Patterson | 2011-01-07 | 1 | -1/+1 | |
| | ||||||
* | String#insert() mutates the string, so no need for lasgn | Aaron Patterson | 2011-01-07 | 1 | -1/+1 | |
| | ||||||
* | fewer funcalls to the cached attributes variable | Aaron Patterson | 2011-01-07 | 1 | -1/+1 | |
| | ||||||
* | Ensure that boolean false is properly serialized [#6079 state:resolved] | Aditya Sanghi | 2010-12-08 | 1 | -1/+2 | |
| | ||||||
* | No need for parenthesis here | Santiago Pastorino | 2010-10-17 | 1 | -1/+1 | |
| | ||||||
* | no need to check for nil | Neeraj Singh | 2010-10-17 | 1 | -1/+1 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Cheaper attribute reads and respond_to?. Add underscore-prefixed method ↵ | Jeremy Kemper | 2010-09-09 | 1 | -3/+7 | |
| | | | | aliased to the attribute name so it can be overridden but still called internally. | |||||
* | Cache unserialized attributes | Jeremy Kemper | 2010-09-09 | 1 | -5/+9 | |
| | ||||||
* | Revert "Refactoring attributes/types" [#3348 state:open] | Pratik Naik | 2010-01-22 | 1 | -4/+45 | |
| | | | | | | | | | | | | | | | | | This reverts commit f936a1f100e75082081e782e5cceb272885c2df7. Conflicts: activerecord/lib/active_record.rb activerecord/lib/active_record/base.rb Revert "Fixed: #without_typecast should only disable typecasting on the duplicated attributes" [#3387 state:open] This reverts commit 2831996483c6a045f1f38d8030256eb58d9771c3. Reason : It's not generating attribute methods properly, making object.column 5x slower. | |||||
* | Refactoring attributes/types [#3348 state:resolved] | Eric Chapweske | 2009-10-17 | 1 | -45/+4 | |
| | | | | Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
* | Ruby 1.9.2: Object#id is gone now | Jeremy Kemper | 2009-08-07 | 1 | -1/+1 | |
| | ||||||
* | Extract generic attribute method generation to AMo | Joshua Peek | 2009-08-04 | 1 | -2/+2 | |
| | ||||||
* | Modified ActiveRecord::AttributeMethods to allow classes to specify ↵ | Paul Gillard | 2009-08-04 | 1 | -1/+1 | |
| | | | | | | attribute method prefixes and/or suffixes. Previously only suffixes were allowed. Signed-off-by: Joshua Peek <josh@joshpeek.com> | |||||
* | Track generated attribute methods in a separate module | Joshua Peek | 2009-08-02 | 1 | -2/+2 | |
| | ||||||
* | Move attribute_types_cached_by_default into attribute methods reading concern | Joshua Peek | 2009-07-30 | 1 | -0/+11 | |
| | ||||||
* | Don't need to pass attr_name to evaluate_attribute_method anymore | Joshua Peek | 2009-07-30 | 1 | -2/+2 | |
| | ||||||
* | Undefine id and let it automatically be generated | Joshua Peek | 2009-07-30 | 1 | -11/+2 | |
| | ||||||
* | Redirect method missing for primary key to read_attribute | Joshua Peek | 2009-07-30 | 1 | -2/+2 | |
| | ||||||
* | Move id attribute methods into their related concern | Joshua Peek | 2009-07-30 | 1 | -0/+11 | |
| |