diff options
author | Santiago Pastorino <santiago@wyeworks.com> | 2011-03-22 20:11:36 -0300 |
---|---|---|
committer | Santiago Pastorino <santiago@wyeworks.com> | 2011-03-22 20:11:36 -0300 |
commit | 450f7cf01b855b536416fc048a92c4309da2492e (patch) | |
tree | 701225bdeb082efb37e4c5d75e6f0d9e12452183 /activerecord/lib/active_record/attribute_methods/read.rb | |
parent | baa237c974fee8023dd704a4efb418ff0e963de0 (diff) | |
download | rails-450f7cf01b855b536416fc048a92c4309da2492e.tar.gz rails-450f7cf01b855b536416fc048a92c4309da2492e.tar.bz2 rails-450f7cf01b855b536416fc048a92c4309da2492e.zip |
use class_eval with a string when it's possible
Diffstat (limited to 'activerecord/lib/active_record/attribute_methods/read.rb')
-rw-r--r-- | activerecord/lib/active_record/attribute_methods/read.rb | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/activerecord/lib/active_record/attribute_methods/read.rb b/activerecord/lib/active_record/attribute_methods/read.rb index affe2d7f53..69d5cd83f1 100644 --- a/activerecord/lib/active_record/attribute_methods/read.rb +++ b/activerecord/lib/active_record/attribute_methods/read.rb @@ -70,9 +70,13 @@ module ActiveRecord if cache_attribute?(attr_name) access_code = "@attributes_cache['#{attr_name}'] ||= (#{access_code})" end - generated_attribute_methods.module_eval do - define_method("_#{symbol}") { eval(access_code) } - alias_method(symbol, "_#{symbol}") + if symbol =~ /^[a-zA-Z_]\w*[!?=]?$/ + generated_attribute_methods.module_eval("def _#{symbol}; #{access_code}; end; alias #{symbol} _#{symbol}", __FILE__, __LINE__) + else + generated_attribute_methods.module_eval do + define_method("_#{symbol}") { eval(access_code) } + alias_method(symbol, "_#{symbol}") + end end end end |