Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | minor rdoc syntax fix [ci skip] | Gourav Tiwari | 2015-05-08 | 1 | -2/+2 | |
| | | | ||||||
* | | | Adds/Corrects use case for adding an error message | Zamith | 2015-05-04 | 2 | -1/+7 | |
|/ / | | | | | | | | | I believe this is a use case that was supposed to be supported, and it's a small fix. | |||||
* | | ensure `method_missing` called for non-existing methods passed to | Jay Elaraj | 2015-04-28 | 3 | -10/+22 | |
| | | | | | | | | `ActiveModel::Serialization#serializable_hash` | |||||
* | | Don't document private internal constant [ci skip] | Zachary Scott | 2015-04-26 | 1 | -0/+1 | |
| | | ||||||
* | | Fix grammar/style: assigns/declares -> assignments/declarations. | Tim Wade | 2015-04-24 | 1 | -3/+3 | |
| | | | | | | | | [ci skip] | |||||
* | | Fix grammar/style: use (v) fall back (on). | Tim Wade | 2015-04-24 | 1 | -1/+1 | |
| | | | | | | | | [ci skip] | |||||
* | | Fix grammar/style: break up long sentence. | Tim Wade | 2015-04-24 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | A conjunction was needed to make these sentences correct. Breaking them up seemed like a better option. [ci skip] | |||||
* | | Fix grammar/style: pluralize 'each of its method' | Tim Wade | 2015-04-24 | 1 | -1/+1 | |
| | | | | | | | | [ci skip] | |||||
* | | pass over CHANGELOGs. [ci skip] | Yves Senn | 2015-04-22 | 1 | -1/+1 | |
| | | ||||||
* | | Add `ActiveModel::Dirty#[attr_name]_previously_changed?` and | Fernando Tapia Rico | 2015-04-21 | 3 | -2/+43 | |
| | | | | | | | | | | | | | | | | `ActiveModel::Dirty#[attr_name]_previous_change` to improve access to recorded changes after the model has been saved. It makes the dirty-attributes query methods consistent before and after saving. | |||||
* | | Merge pull request #19753 from jonatack/use-ruby-2-2-2 | Guillermo Iguaran | 2015-04-13 | 1 | -1/+1 | |
|\ \ | | | | | | | Upgrade to Ruby 2.2.2 | |||||
| * | | Upgrade to Ruby 2.2.2 | Jon Atack | 2015-04-14 | 1 | -1/+1 | |
| | | | | | | | | | | | | and fix the grammar in the ruby_version_check.rb user message. | |||||
* | | | Merge pull request #19448 from tgxworld/fix_activesupport_callbacks_clash_on_run | Rafael Mendonça França | 2015-04-06 | 2 | -2/+2 | |
|\ \ \ | | | | | | | | | Fix AS::Callbacks raising an error when `:run` callback is defined. | |||||
| * | | | Revert "Reduce allocations when running AR callbacks." | Guo Xiang Tan | 2015-03-22 | 2 | -2/+2 | |
| | | | | | | | | | | | | | | | | This reverts commit 796cab45561fce268aa74e6587cdb9cae3bb243e. | |||||
* | | | | fix typo in deprecation message. [Robin Dupret] | Yves Senn | 2015-04-05 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Fix a few typos [ci skip] | Robin Dupret | 2015-04-05 | 1 | -4/+4 | |
| |/ / |/| | | ||||||
* | | | Merge pull request #19594 from radar/require-module-delegation | Guillermo Iguaran | 2015-03-30 | 1 | -0/+1 | |
|\ \ \ | | | | | | | | | Require Module#delegate core ext in ActiveModel::Naming | |||||
| * | | | Require Module#delegate core ext in ActiveModel::Naming | Ryan Bigg | 2015-03-31 | 1 | -0/+1 | |
| | | | | ||||||
* | | | | Merge pull request #19021 from morgoth/activemodel-errors-refactoring | Rafael Mendonça França | 2015-03-30 | 2 | -24/+10 | |
|\ \ \ \ | | | | | | | | | | | Simplify and alias ActiveModel::Errors methods where possible | |||||
| * | | | | Simplify and alias ActiveModel::Errors methods where possible | Wojciech Wnętrzak | 2015-02-20 | 2 | -24/+10 | |
| | | | | | ||||||
* | | | | | Deprecate the `:tokenizer` option to `validates_length_of` | Sean Griffin | 2015-03-29 | 3 | -12/+51 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As demonstrated by #19570, this option is severely limited, and satisfies an extremely specific use case. Realistically, there's not much reason for this option to exist. Its functionality can be trivially replicated with a normal Ruby method. Let's deprecate this option, in favor of the simpler solution. | |||||
* | | | | | Fix arguments order on assertion | Carlos Antonio da Silva | 2015-03-22 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | The expected value comes first. Related to #19465. | |||||
* | | | | | Fix ActiveModel::Errors#delete return value to stay backward compatible | Radan Skoric | 2015-03-22 | 2 | -7/+13 | |
| |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails 5.0 changes to ActiveModel::Errors include addition of `details` that also accidentally changed the return value of `delete`. Since there was no test for that behavior it went unnoticed. This commit adds a test and fixes the regression. Small improvements to comments have also been made. Since `get` is getting deprecated it is better to use `[]` in other methods' code examples. Also, in the module usage example, `def Person.method` was replaced with a more commonly used `def self.method` code style. | |||||
* | | | | Fix ActiveModel::Errors deprecation messages failing when used on its own | Radan Skoric | 2015-03-21 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Deprecation messages in ActiveModel::Errors are using String#squish from ActiveSupport but were not explicitly requiring it, causing failures when used outside rails. | |||||
* | | | | Target Ruby 2.2.1 in gemspecs | Peter Suschlik | 2015-03-09 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | This is a follow-up to #19257 | |||||
* | | | | Revert "For now, we will keep sorting the tests." | Matthew Draper | 2015-03-06 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | This reverts commit 7025d7769dc53f0a3ffab8b537727ef3fee367fc. | |||||
* | | | | Revert "Leave all our tests as order_dependent! for now" | Matthew Draper | 2015-03-06 | 1 | -5/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2f52f969885b2834198de0045748436a4651a94e. Conflicts: actionmailer/test/abstract_unit.rb actionview/test/abstract_unit.rb activemodel/test/cases/helper.rb activerecord/test/cases/helper.rb activesupport/test/abstract_unit.rb railties/test/abstract_unit.rb | |||||
* | | | | Fix spelling error in has_secure_password documentation [ci skip] | Melanie Gilman | 2015-03-03 | 1 | -1/+1 | |
| |/ / |/| | | ||||||
* | | | Merge pull request #19173 from robin850/rbx-build | Rafael Mendonça França | 2015-03-02 | 2 | -0/+11 | |
|\ \ \ | | | | | | | | | Improve the Rubinius build | |||||
| * | | | Skip the failing tests on Rubinius for now | Robin Dupret | 2015-03-02 | 1 | -0/+2 | |
| | | | | ||||||
| * | | | Add the platform-specific skip helpers to ActiveModel | Robin Dupret | 2015-03-02 | 1 | -0/+9 | |
| | | | | ||||||
* | | | | Merge pull request #19077 from robin850/unknown-attribute-error | Sean Griffin | 2015-03-02 | 5 | -14/+15 | |
|\ \ \ \ | |/ / / |/| | | | Move `UnknownAttributeError` to a more sane namespace | |||||
| * | | | Follow-up to #10776 | Robin Dupret | 2015-02-26 | 5 | -14/+15 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The name `ActiveModel::AttributeAssignment::UnknownAttributeError` is too implementation specific so let's move the constant directly under the ActiveModel namespace. Also since this constant used to be under the ActiveRecord namespace, to make the upgrade path easier, let's avoid raising the former constant when we deal with this error on the Active Record side. | |||||
* | | | | Removed non-standard and unused require 'active_support/deprecation' from ↵ | Vipul A M | 2015-02-27 | 1 | -1/+0 | |
|/ / / | | | | | | | | | | parts out of active_support. | |||||
* | | | activemodel: make .model_name json encodable | Ian Ker-Seymer | 2015-02-24 | 2 | -1/+5 | |
| | | | | | | | | | | | | | | | | | | Previously, calling `User.model_name.to_json` would result in an infinite recursion as `.model_name` inherited its `.as_json` behavior from Object. This patch fixes that unexpected behavior by delegating `.as_json` to :name. | |||||
* | | | some indenting and punctuation fixes. [ci skip] | Yves Senn | 2015-02-23 | 1 | -1/+1 | |
| | | | ||||||
* | | | Change the deprecation messages to show the preferred way to work with | Rafael Mendonça França | 2015-02-20 | 3 | -11/+11 | |
|/ / | | | | | | | ActiveModel::Errors | |||||
* | | Move the `validate!` method to `ActiveModel::Validations`. | Lucas Mazza | 2015-02-20 | 3 | -0/+53 | |
| | | ||||||
* | | Merge pull request #17144 from skojin/patch-doc-validation-format-z-regexp | Rafael Mendonça França | 2015-02-20 | 1 | -1/+1 | |
|\ \ | | | | | | | fix mistype in doc about \z regexp | |||||
| * | | fix mistype in doc about \z regexp | Sergey Kojin | 2014-10-02 | 1 | -1/+1 | |
| | | | | | | | | | | | | replace \Z with regular \z | |||||
* | | | use `messages` instead of deprecated `ActiveModel::Errors#[]=` method [ci skip] | yuuji.yaginuma | 2015-02-20 | 2 | -2/+2 | |
| | | | ||||||
* | | | Merge pull request #18996 from morgoth/deprecate-more-errors-methods | Yves Senn | 2015-02-19 | 4 | -8/+43 | |
|\ \ \ | | | | | | | | | | | | | Deprecate `ActiveModel::Errors` `add_on_empty` and `add_on_blank` methods | |||||
| * | | | Deprecate `ActiveModel::Errors` `add_on_empty` and `add_on_blank` methods | Wojciech Wnętrzak | 2015-02-19 | 4 | -8/+41 | |
|/ / / | | | | | | | | | | without replacement. | |||||
* | | | Merge pull request #18634 from morgoth/deprecate-some-errors-methods | Rafael Mendonça França | 2015-02-18 | 3 | -24/+54 | |
|\ \ \ | | | | | | | | | | | | | Deprecate `ActiveModel::Errors` `get`, `set` and `[]=` methods. | |||||
| * | | | Deprecate `ActiveModel::Errors` `get`, `set` and `[]=` methods. | Wojciech Wnętrzak | 2015-02-01 | 3 | -24/+54 | |
| | | | | | | | | | | | | | | | | They have inconsistent behaviour currently. | |||||
* | | | | Tiny documentation edits [ci skip] | Robin Dupret | 2015-02-15 | 1 | -4/+6 | |
| | | | | ||||||
* | | | | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2015-02-14 | 2 | -9/+10 | |
|\ \ \ \ | ||||||
| * | | | | AM#Dirty doc fixes | Vipul A M | 2015-02-01 | 1 | -8/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Grammar fixes - Add doc for changes_include? - implemntations => implementations | |||||
| * | | | | Fix description for AM::Callbacks | Vipul A M | 2015-01-31 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | Merge pull request #16381 from kakipo/validate-length-tokenizer | Rafael Mendonça França | 2015-02-13 | 4 | -7/+32 | |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | Allow symbol as values for `tokenizer` of `LengthValidator` |