aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel
diff options
context:
space:
mode:
authorIan Ker-Seymer <i.kerseymer@gmail.com>2015-02-23 18:45:46 -0700
committerIan Ker-Seymer <i.kerseymer@gmail.com>2015-02-24 11:00:32 -0700
commitc5d62cb86d958aaa68a4057b3c2578329044e674 (patch)
treebe03541b30100c8b38651decb1813fcd43d8f4b1 /activemodel
parentf6a31f532167eaffe0709af50c2d2190f2f76219 (diff)
downloadrails-c5d62cb86d958aaa68a4057b3c2578329044e674.tar.gz
rails-c5d62cb86d958aaa68a4057b3c2578329044e674.tar.bz2
rails-c5d62cb86d958aaa68a4057b3c2578329044e674.zip
activemodel: make .model_name json encodable
Previously, calling `User.model_name.to_json` would result in an infinite recursion as `.model_name` inherited its `.as_json` behavior from Object. This patch fixes that unexpected behavior by delegating `.as_json` to :name.
Diffstat (limited to 'activemodel')
-rw-r--r--activemodel/lib/active_model/naming.rb2
-rw-r--r--activemodel/test/cases/serializers/json_serialization_test.rb4
2 files changed, 5 insertions, 1 deletions
diff --git a/activemodel/lib/active_model/naming.rb b/activemodel/lib/active_model/naming.rb
index 2bc3eeaa19..22010b517c 100644
--- a/activemodel/lib/active_model/naming.rb
+++ b/activemodel/lib/active_model/naming.rb
@@ -130,7 +130,7 @@ module ActiveModel
#
# Equivalent to +to_s+.
delegate :==, :===, :<=>, :=~, :"!~", :eql?, :to_s,
- :to_str, to: :name
+ :to_str, :as_json, to: :name
# Returns a new ActiveModel::Name instance. By default, the +namespace+
# and +name+ option will take the namespace and name of the given class
diff --git a/activemodel/test/cases/serializers/json_serialization_test.rb b/activemodel/test/cases/serializers/json_serialization_test.rb
index e2eb91eeb0..d765a47636 100644
--- a/activemodel/test/cases/serializers/json_serialization_test.rb
+++ b/activemodel/test/cases/serializers/json_serialization_test.rb
@@ -195,4 +195,8 @@ class JsonSerializationTest < ActiveModel::TestCase
assert_no_match %r{"awesome":}, json
assert_no_match %r{"preferences":}, json
end
+
+ test "Class.model_name should be json encodable" do
+ assert_match %r{"Contact"}, Contact.model_name.to_json
+ end
end