aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Stub logger for testsAndrey Koleshko2013-06-061-0/+4
| | |
* | | Fix regression in has_secure_password.Phil Calvin2013-05-301-0/+9
|/ / | | | | | | If the confirmation was blank, but the password wasn't, it would still save.
* | deprecate Validator#setup (to get rid of a respond_to call). validators do ↵Nick Sutterer2013-05-232-23/+22
| | | | | | | | their setup in their constructor now.
* | Merge pull request #10527 from zenspider/squishy_minitest5Aaron Patterson2013-05-161-1/+0
|\ \ | | | | | | Squishy minitest5
| * | Updates to make rails 4 happy with minitest 5:Ryan Davis2013-05-061-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | + Namespace changes, overhaul of runners. + Internal ivar name changes - Removed a logger globally applied to tests that spew everywhere?!? + Override Minitest#__run to sort tests by name. + Reworked testing isolation to work with the new cleaner architecture. - Removed a bunch of tests that just test minitest straight up. I think these changes were all merged to minitest 4 a long time ago. - Minor report output differences.
* | | callbacks are wrapped with lambdasAaron Patterson2013-05-101-1/+1
|/ /
* | Convert ActiveModel to 1.9 hash syntax.Patrick Robertson2013-05-0125-309/+311
| | | | | | | | | | I also attempted to fix other styleguide violations such as { a: :b } over {a: :b} and foo(b: 'bar') over foo( b: 'bar' ).
* | Merge pull request #10286 from ↵Carlos Antonio da Silva2013-04-211-2/+2
|\ \ | | | | | | | | | | | | neerajdotname/fix-wrong-test-name-and-failure-message fix wrong test description and failure message
| * | fix wrong test description and failure messageNeeraj Singh2013-04-211-2/+2
| | |
* | | Added tests for if condition in Active Model callbacksNeeraj Singh2013-04-211-0/+21
|/ /
* | Removed unused setupAnupam Choudhury2013-04-091-4/+0
| |
* | Review some tests from AMo::Errors to remove "should" usageCarlos Antonio da Silva2013-03-301-55/+35
| | | | | | | | | | Also remove duplicated tests for Errors#as_json and minor improvements in some tests.
* | Merge pull request #8527 from shockone/patch-1Rafael Mendonça França2013-03-251-0/+20
|\ \ | | | | | | Add a method full_messages_for to the Errors class
| * | Add a method full_messages_for to the Errors classshock_one2013-03-241-0/+20
| | |
* | | Add Error#full_message test; Fix typosVipul A M2013-03-221-0/+1
|/ / | | | | | | | | Introduce test on Error#full_message for attribute with underscores; Fix some typos
* | fix some typos found in activemodelVipul A M2013-03-183-4/+4
| |
* | Small typos here and there.Vipul A M2013-03-153-4/+4
| |
* | `has_secure_password` is not invalid when assigning empty Strings.Yves Senn2013-03-041-0/+6
| | | | | | | | | | | | | | | | | | | | Closes #9535. With 692b3b6 the `password=` setter does no longer set blank passwords. This triggered validation errors when assigning empty Strings to `password` and `password_confirmation`. This patch only sets the confirmation if it is not `blank?`.
* | `validates_confirmation_of` does not override writer methods.Yves Senn2013-03-041-0/+31
| |
* | added more accurate test for add_on_emptyAngelo capilleri2013-02-191-0/+7
| | | | | | | | | | with the current tests, if delete the assignment of is_empty in add_on_empty method the tests not fail. With this test, if we delete is_empty, the test fails
* | Take care of whitespaces and changing the hash syntaxRafael Mendonça França2013-02-041-57/+56
| |
* | test for issue 8931David2013-02-021-0/+8
| |
* | Adding the route_key and param_key testsAttila Domokos2013-01-221-0/+8
| | | | | | This way all the tests are testing the same fields
* | Merge pull request #8940 from adomokos/adding_tests_for_changed_attributesCarlos Antonio da Silva2013-01-151-1/+12
|\ \ | | | | | | Cleaning up ActiveModel::Dirty tests
| * | Cleaning up ActiveModel::Dirty testsAttila Domokos2013-01-151-1/+12
| | | | | | | | | | | | | | | | | | | | | * Clarifying what the #changed method returns * Adding tests to describe what the #changed_attributes returns * Updating test name based on pull request comment * Moving the test lower in the file per pull request comment
* | | test for ActiveModel::Conversion#to_partial_path and namespaced modelsYves Senn2013-01-142-0/+8
|/ /
* | Adding tests for ActiveModel::ModelAttila Domokos2013-01-121-0/+6
| | | | | | | | | | | | * Verifying persisted? is false when Model initialized * Passing nil to Model should not blow up * Changing test name to the one suggested in pull request comment
* | Covering untested methods for ActiveModel::ErrorsAttila Domokos2013-01-101-0/+53
|/
* Add active_support/testing/autorunRafael Mendonça França2012-12-311-1/+1
| | | | | minitest/autorun load minitest/spec polluting the global namespace with the DSL that we don't want on Rails
* Add CHANGELOG entry for #8622Rafael Mendonça França2012-12-261-2/+2
|
* Revert the change at ActiveModel::Errors#add_on_blank and fix in theRafael Mendonça França2012-12-261-5/+5
| | | | | | | | | | | right place. The EachValidator#validate already handle :allow_blank and :allow_nil, correctly. Closes #8622. Fix #8621.
* Tests and fix for validates_presence of :allow_nil, :allow_blankColin Kelley2012-12-261-0/+34
| | | | | Conflicts: activemodel/lib/active_model/errors.rb
* chmod -x from non-script filesAkira Matsuda2012-12-241-0/+0
|
* Add `ActiveModel::Validations::AbsenceValidator`, a validator to check the ↵Roberto Vasquez Angel2012-12-151-0/+67
| | | | | | absence of attributes. Add `ActiveModel::Errors#add_on_present` method. Adds error messages to present attributes.
* Actually test that ActiveModel::Errors#add defaults to :invalid.Renato Mascarenhas2012-12-011-1/+1
|
* Call `full_messages` instead of `to_a` in its spec.Renato Mascarenhas2012-12-011-2/+1
|
* Reset attributes should not report changes.Renato Mascarenhas2012-12-011-2/+1
| | | | | | | | | | | When resetting an attribute, you expect it to return to the state it was before any changes. Namely, this fixes this unexpected behavior: ~~~ruby model.name = "Bob" model.reset_name! model.name_changed? #=> true ~~~
* Simplify keys order test for as_json in Active ModelCarlos Antonio da Silva2012-11-301-4/+1
|
* Remove observers and sweepersRafael Mendonça França2012-11-283-428/+0
| | | | | | | | They was extracted from a plugin. See https://github.com/rails/rails-observers [Rafael Mendonça França + Steve Klabnik]
* Specify type of singular association during serializationSteve Klabnik2012-11-281-2/+10
| | | | | | | | | | | | When serialising a class, specify the type of any singular associations, if necessary. Rails already correctly specifies the :type of any enumerable association (e.g. a has_many association), but made no attempt to do so for non-enumerables (e.g. a has_one association). We must specify the :type of any STI association. A has_one association to a class which uses single-table inheritance is an example of this type of association. Fixes #7471
* Merge pull request #7282 from xHire/validates_length_of_fixRafael Mendonça França2012-11-261-0/+39
|\ | | | | | | | | | | | | Length validation handles correctly nil. Fix #7180 Conflicts: activemodel/CHANGELOG.md
| * Length validation handles correctly nil. Fix #7180Michal Zima2012-11-261-0/+39
| | | | | | | | When nil or empty string are not allowed, they are not valid.
* | Merge pull request #8320 from senny/active_model_log_folderCarlos Antonio da Silva2012-11-261-0/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Log output from activemodel's railtie_test directly to STDOUT. There's no logging going on here, but since we initialize the app, the logger is set and the folder is automatically created. With this change, the default logger is not created, so there is no logging folder anymore. Conflicts: activemodel/test/cases/railtie_test.rb
| * | log output from activemodel's railtie_test directly to STDOUTYves Senn2012-11-261-0/+1
| |/ | | | | | | | | after this patch, running the tests in activemodel will no longer create an untracked log/ folder inside of activemodel
* / Require active_model/railtie directly instead of rails/allCarlos Antonio da Silva2012-11-261-3/+3
|/ | | | Use Class.new with a block instead of tap to configure it.
* Use secure password min cost option in its own tests for a speed upCarlos Antonio da Silva2012-11-211-2/+10
| | | | Around 0.564359s => 0.092244s speed up in my machine.
* Use BCrypt's MIN_COST in the test environment for speedier testsTrevor Turk2012-11-142-1/+40
|
* use Array() instead flattenVasiliy Ermolovich2012-11-052-21/+39
| | | | | * move ActiveModel::Errors tests to errors_test.rb * add spec coverage for add_on_empty and add_on_blank
* Raise ArgumentError when no attribute is given to AMo::EachValidatorCarlos Antonio da Silva2012-11-041-1/+1
| | | | ArgumentError is better suited than RuntimeError for this.
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-11-032-13/+13
|\ | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/mime_responds.rb activerecord/lib/active_record/attribute_methods.rb guides/source/working_with_javascript_in_rails.md