aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel/lib/active_model
Commit message (Collapse)AuthorAgeFilesLines
* Fix secure_password password_confirmation validationsVladimir Kiselev2013-07-241-2/+8
|
* bcrypt-ruby stable is 3.1Burkhard Vogel-Kreykenbohm2013-07-171-3/+3
|
* it's xml, not jsonJohn Gesimondo2013-07-131-1/+1
| | | change docs for xml serializer to talk about xml
* eagerly initialize the attributes module to avoid check-then-set race conditionsAaron Patterson2013-07-021-1/+4
|
* remove wrong documentation from a :nodoc:'d methodAaron Patterson2013-07-021-1/+0
|
* the data structure used to store attribute aliases should not be exposedAaron Patterson2013-07-011-0/+10
|
* fix typo in ActiveModel::Error docs [ci skip]Steven Yang2013-06-301-1/+1
|
* remove evals from AM::Validations::CallbacksSteven Yang2013-06-301-1/+3
| | | | follow the same refactor at a63a964a5d1ed02cf0df1b1a33a96ed2a9fa987b
* provide a more sementicthe local variables name for ↵Steven Yang2013-06-291-8/+8
| | | | | | | ActiveModel::Validations::Clusivity#include? method the original name `exclusion` is a bit confusing when using with the method `inclusion_method` rename it to a more logic neutral name.
* Remove deprecation warning from AttributeMethodsMatcherPaul Nikitochkin2013-06-281-8/+0
|
* Remove deprecated attr_protected/accessibleŁukasz Strzałkowski2013-06-271-21/+0
| | | | Rails 4.0 has removed attr_protected and attr_accessible feature in favor of Strong Parameters.
* Merge pull request #11054 from senny/11048_make_default_value_explicitCarlos Antonio da Silva2013-06-271-4/+2
|\ | | | | make default value for `:message` on `AM::Errors` explicit.
| * make default value for `:message` on `AM::Errors` explicit.Yves Senn2013-06-221-4/+2
| |
* | Merge pull request #10774 from ↵Carlos Antonio da Silva2013-06-252-4/+5
|\ \ | | | | | | | | | | | | | | | | | | | | | chuckbergeron/validates-inclusion-of-accuracy-for-non-numeric-ranges Greater accuracy for validates_inclusion_of on non-numeric ranges Closes #10774, fixes #10593
| * | Use Range#cover? for Numeric ranges (tests via endpoints) and use ↵Charles Bergeron2013-05-272-4/+5
| | | | | | | | | | | | | | | | | | Range#include? for non-numeric ranges added changelog message
* | | Fixing Issue #11083Akshay Khole2013-06-251-1/+1
| | | | | | | | | | | | Removing other occurrences of `the` appearing twice
* | | Revert "Merge pull request #11053 from yangchenyun/mine"José Valim2013-06-221-2/+0
| |/ |/| | | | | | | | | | | | | | | | | | | Those two files are required by active_support/rails.rb loaded in active_model.rb It is common to require common dependencies on the root files to avoid boilerplate in each file. This reverts commit 763635e30f17800ebc0a8ae98d780edc8ebfb4e5, reversing changes made to 4f46ef36aaef217834f3f96d3689d32f6a6761ea.
* | Merge pull request #11053 from yangchenyun/mineYves Senn2013-06-221-0/+2
|\ \ | | | | | | Add explicit dependencies of ActiveSupport to enable independent usage of ActiveModel::Name
| * | add explicit AS dependencies for ActiveModel::NamingSteven Yang2013-06-221-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | There are two missing ActiveSupport dependencies to use ActiveModel::Name class or ActiveModel::Naming module independently. Missing dependencies for Module#delegate defined in `active_support/core_ext/module/delegation`, used at [L148](https://github.com/rails/rails/blob/master/activemodel/lib/active_model/naming.rb#L148) Missing dependencies for Object#blank? defined in `active_support/core_ext/object/blank`, used at [L131](https://github.com/rails/rails/blob/master/activemodel/lib/active_model/naming.rb#L131)
* | | ActiveModel::Model inclusion chain backward compatibilityFred Wu2013-06-201-1/+1
| | |
* | | Fixes AciveModel::Model with no ancestors, fixes #11004Fred Wu2013-06-191-1/+1
| | | | | | | | | | | | Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
* | | Fixed ActiveModel::Model's inclusion chainFred Wu2013-06-191-0/+2
|/ /
* | expose a few attribute changed methodsAaron Patterson2013-06-111-10/+10
| |
* | remove some evals from callback conditionalsAaron Patterson2013-06-112-2/+7
| |
* | fix ActiveModel::Validations.validators_on docDaichi Arai2013-06-101-1/+0
| |
* | Docfix: Use public interface instead of setting instance variablesRichard Livsey2013-06-071-1/+1
| | | | | | Dynamically setting instance variables based on user input probably isn't a great idea. Better to go through the setter methods provided by attr_accessor.
* | Fix regression in has_secure_password.Phil Calvin2013-05-301-4/+3
|/ | | | If the confirmation was blank, but the password wasn't, it would still save.
* deprecate Validator#setup (to get rid of a respond_to call). validators do ↵Nick Sutterer2013-05-234-12/+35
| | | | their setup in their constructor now.
* deprecating string based terminatorsAaron Patterson2013-05-142-2/+5
|
* respond_to -> respond to in a message from AM::LintXavier Noria2013-05-121-1/+1
| | | | | | | | The error message uses English to say that the object should respond to a certain method. You check that with respond_to, but that's not English. This makes this error message also consistent with the rest.
* Using define method instead of class eval when defining model callbacks.wangjohn2013-05-081-18/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Based on my benchmark results, this change improves performance substantially when defining callbacks. This benchmark (https://gist.github.com/wangjohn/5542610) was run using the current master and also using my experimental branch which replaced class_eval with define_single_method. Using class_eval (current master): user system total real 10 trials 0.000000 0.000000 0.000000 ( 0.001568) 50 trials 0.020000 0.000000 0.020000 ( 0.021715) 500 trials 0.110000 0.000000 0.110000 ( 0.115357) 1000 trials 0.250000 0.000000 0.250000 ( 0.260025) 10000 trials 2.560000 0.000000 2.560000 ( 2.568408) 50000 trials 12.800000 0.010000 12.810000 ( 12.886871) Using define_single_method (experimental branch): user system total real 10 trials 0.000000 0.000000 0.000000 ( 0.000790) 50 trials 0.000000 0.000000 0.000000 ( 0.002960) 500 trials 0.050000 0.010000 0.060000 ( 0.055690) 1000 trials 0.100000 0.000000 0.100000 ( 0.094073) 10000 trials 0.890000 0.000000 0.890000 ( 0.900364) 50000 trials 4.650000 0.000000 4.650000 ( 4.686127)
* Convert ActiveModel to 1.9 hash syntax.Patrick Robertson2013-05-0118-40/+40
| | | | | I also attempted to fix other styleguide violations such as { a: :b } over {a: :b} and foo(b: 'bar') over foo( b: 'bar' ).
* rails/master is now 4.1.0.betaRafael Mendonça França2013-04-291-1/+1
|
* Bump version to rc1David Heinemeier Hansson2013-04-291-1/+1
|
* pass over the code commentsXavier Noria2013-04-281-28/+32
| | | | | | * Highlights the requirement of an attributes method. * Removes some details that depend on the implementation of the class including the module. * Applies guidelines here and there.
* Prefer find_by over dynamic finders in rdocSam Ruby2013-04-022-8/+8
|
* Improve changelog entry for ActiveModel::Errors#full_messages_for [ci skip]Carlos Antonio da Silva2013-03-301-2/+0
| | | | Add a working example of how to use this new method.
* Add a method full_messages_for to the Errors classshock_one2013-03-241-0/+14
|
* Merge pull request #8501 from charliesome/version-to-sRafael Mendonça França2013-03-231-6/+7
|\ | | | | Add #to_s method to VERSION modules
| * Add version method to top level modulesCharlie Somerville2013-03-211-6/+7
| |
* | Remove exception variable from rescue blockCarlos Antonio da Silva2013-03-221-2/+2
| | | | | | | | | | Just raising from the rescue block will re-raise the exception, so the variable is not necessary.
* | Change Standard error when is required bcrypt-ruby and failsrobertomiranda2013-03-211-2/+7
| |
* | Tidying up some require : removing useless sort and homogenizing with the ↵Intrepidd2013-03-201-4/+1
|/ | | | rest of the code the wat the includes are done
* The repair_validations helper was not working correctly before becausewangjohn2013-03-191-0/+43
| | | | | | it only cleared the validations that created :validate callbacks. This didn't include the validates created by validates_with, so I've added a method to clear all validations.
* Merge pull request #9545 from senny/9535_secure_password_blankRafael Mendonça França2013-03-072-3/+13
|\ | | | | `has_secure_password` is not invalid when assigning empty Strings
| * `has_secure_password` is not invalid when assigning empty Strings.Yves Senn2013-03-041-2/+8
| | | | | | | | | | | | | | | | | | | | Closes #9535. With 692b3b6 the `password=` setter does no longer set blank passwords. This triggered validation errors when assigning empty Strings to `password` and `password_confirmation`. This patch only sets the confirmation if it is not `blank?`.
| * `validates_confirmation_of` does not override writer methods.Yves Senn2013-03-041-1/+5
| |
* | Small TypoLebin Sebastian F2013-03-041-1/+1
|/
* Preparing for 4.0.0.beta1 releaseDavid Heinemeier Hansson2013-02-251-1/+1
|
* Clarify ActiveModel::Validator initialization in docs.Henrik Nyh2013-02-091-0/+3
| | | As discussed with @josevalim on Ruby Rogues Parley.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 15:06:40 +0000