diff options
| author | Richard Livsey <richard@livsey.org> | 2013-06-07 12:41:05 +0200 |
|---|---|---|
| committer | Richard Livsey <richard@livsey.org> | 2013-06-07 12:41:05 +0200 |
| commit | 9906eb135575ea6dd154257b8c977321c4b1adb2 (patch) | |
| tree | e8683440885450ec754e909274f1688bb1ffdb3e /activemodel/lib/active_model | |
| parent | a68c6cccf05310546e82c4c81fe70818a454bf4e (diff) | |
| download | rails-9906eb135575ea6dd154257b8c977321c4b1adb2.tar.gz rails-9906eb135575ea6dd154257b8c977321c4b1adb2.tar.bz2 rails-9906eb135575ea6dd154257b8c977321c4b1adb2.zip | |
Docfix: Use public interface instead of setting instance variables
Dynamically setting instance variables based on user input probably isn't a great idea. Better to go through the setter methods provided by attr_accessor.
Diffstat (limited to 'activemodel/lib/active_model')
| -rw-r--r-- | activemodel/lib/active_model/serializers/json.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/activemodel/lib/active_model/serializers/json.rb b/activemodel/lib/active_model/serializers/json.rb index 9d984b7a18..05e2e089e5 100644 --- a/activemodel/lib/active_model/serializers/json.rb +++ b/activemodel/lib/active_model/serializers/json.rb @@ -109,7 +109,7 @@ module ActiveModel # # def attributes=(hash) # hash.each do |key, value| - # instance_variable_set("@#{key}", value) + # send("#{key}=", value) # end # end # |