aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel/CHANGELOG.md
Commit message (Collapse)AuthorAgeFilesLines
* Fix year value when casting a multiparameter time hashAndrew White2019-01-211-0/+28
| | | | | | | | | | | | | | | | | | | | | | | When assigning a hash to a time attribute that's missing a year component (e.g. a `time_select` with `:ignore_date` set to `true`) then the year defaults to 1970 instead of the expected 2000. This results in the attribute changing as a result of the save. Before: event = Event.new(start_time: { 4 => 20, 5 => 30 }) event.start_time # => 1970-01-01 20:30:00 UTC event.save event.reload event.start_time # => 2000-01-01 20:30:00 UTC After: event = Event.new(start_time: { 4 => 20, 5 => 30 }) event.start_time # => 2000-01-01 20:30:00 UTC event.save event.reload event.start_time # => 2000-01-01 20:30:00 UTC
* Preparing for 6.0.0.beta1 releaseRafael Mendonça França2019-01-181-0/+2
|
* Add `ActiveModel::Errors#of_kind?`bogdanvlviv2019-01-041-0/+4
| | | | Related to https://github.com/rails/rails/pull/34817#issuecomment-451508668
* Require Ruby 2.5 for Rails 6.Kasper Timm Hansen2018-12-191-2/+2
| | | | | | | | | | Generally followed the pattern for https://github.com/rails/rails/pull/32034 * Removes needless CI configs for 2.4 * Targets 2.5 in rubocop * Updates existing CHANGELOG entries for fewer merge conflicts * Removes Hash#slice extension as that's inlined on Ruby 2.5. * Removes the need for send on define_method in MethodCallAssertions.
* Fix numericality equality validation on floatsGannon McGibbon2018-12-121-0/+5
|
* Add slice! method to ActiveModel::ErrorsDaniel Lopez Prat2018-11-211-0/+4
|
* Formatting CHANGELOGs [ci skip]Ryuta Kamizono2018-09-071-12/+13
| | | | Fixing code block rendering, indentation, backticks, etc.
* Fix numericality validator to still use value before type cast except Active ↵Ryuta Kamizono2018-08-241-0/+6
| | | | | | | | | | | | | | | | | | | Record The purpose of fe9547b is to work type casting to value from database. But that was caused not to use the value before type cast even except Active Record. There we never guarantees that the value before type cast was going to the used in this validation, but we should not change the behavior unless there is some particular reason. To restore original behavior, still use the value before type cast if `came_from_user?` is undefined (i.e. except Active Record). Fixes #33651. Fixes #33686.
* Add changelog entry for #31503 [ci skip]bogdanvlviv2018-08-121-0/+16
| | | | Related to #31503
* has_secure_password: use `recovery_password` instead of `activation_token`bogdanvlviv2018-07-081-4/+4
| | | | | | Since we have `has_secure_token`, it is too confusing to use `_token` suffix with `has_secure_password`. Context https://github.com/rails/rails/pull/33307#discussion_r200807185
* Merge pull request #26764 from choncou/improve_has_secure_passwordRafael Mendonça França2018-06-281-0/+18
|\ | | | | | | Allow configurable attribute name on `#has_secure_password`
| * Remove method for regenerating a token, and update `#authenticate`.Unathi Chonco2016-10-121-10/+7
| | | | | | | | | | | | | | This change now creates a method `#authenticate_XXX` where XXX is the configured attribute name on `#has_secure_password`. `#authenticate` is now an alias to this method when the attribute name is the default 'password'
| * This addition will now allow configuring an attribute name for theUnathi Chonco2016-10-121-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | existing `#has_secure_password`. This can be useful when one would like to store some secure field as a digest, just like a password. The method still defaults to `password`. It now also allows using the same `#authenticate` method which now accepts a second argument for specifying the attribute to be authenticated, or will default to 'password`. A new method is also added for generating a new token for an attribute by calling `#regenerate_XXXX` where `XXXX` is the attribute name.
* | Add changelog for #32956 [ci skip]bogdanvlviv2018-06-121-0/+6
| | | | | | | | Add mention about default value of `config.active_model.i18n_full_message`.
* | Remove changelog header for unreleased versionRafael Mendonça França2018-03-131-2/+0
| | | | | | | | | | | | We only add the header when releasing to avoid some conflicts. [ci skip]
* | Remove CHANGELOG entries which were backported to 5-2-stableRyuta Kamizono2018-02-281-4/+0
| |
* | Merge pull request #28270 from mmangino/dont_ignore_seralization_optionsRyuta Kamizono2018-02-271-0/+4
|\ \ | | | | | | | | | Don't accidentally lose includes in serialization
| * | Don't accidentally lose includes in serializationMike Mangino2017-03-031-0/+3
| | |
* | | Rails 6 requires Ruby 2.4.1+Jeremy Daer2018-02-171-0/+5
| | | | | | | | | | | | | | | | | | Skipping over 2.4.0 to sidestep the `"symbol_from_string".to_sym.dup` bug. References #32028
* | | Start Rails 6.0 development!!!Rafael Mendonça França2018-01-301-65/+1
| | | | | | | | | | | | :tada::tada::tada:
* | | Allow attributes with a proc default to be marshalledSean Griffin2018-01-231-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't implement much custom marshalling logic for these objects, but the proc default case needs to be handled separately. Unfortunately there's no way to just say "do what you would have done but with this value for one ivar", so we have to manually implement `marshal_load` as well. The test case is a little bit funky, but I'd really like an equality test in there, and there's no easy way to add one now that this is out of AR (since the `attributes` method isn't here) Fixes #31216
* | | Fix validation callbacks on multiple contextYoshiyuki Hirano2017-12-201-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I found a bug that validation callbacks don't fire on multiple context. So I've fixed it. Example: ```ruby class Dog include ActiveModel::Validations include ActiveModel::Validations::Callbacks attr_accessor :history def initialize @history = [] end before_validation :set_before_validation_on_a, on: :a before_validation :set_before_validation_on_b, on: :b after_validation :set_after_validation_on_a, on: :a after_validation :set_after_validation_on_b, on: :b def set_before_validation_on_a; history << "before_validation on a"; end def set_before_validation_on_b; history << "before_validation on b"; end def set_after_validation_on_a; history << "after_validation on a" ; end def set_after_validation_on_b; history << "after_validation on b" ; end end ``` Before: ``` d = Dog.new d.valid?([:a, :b]) d.history # [] ``` After: ``` d = Dog.new d.valid?([:a, :b]) d.history # ["before_validation on a", "before_validation on b", "after_validation on a", "after_validation on b"] ```
* | | Preparing for 5.2.0.beta2 releaseRafael Mendonça França2017-11-281-0/+5
| | |
* | | Preparing for 5.2.0.beta1 releaseRafael Mendonça França2017-11-271-0/+2
| | |
* | | Execute `ConfirmationValidator` validation when `_confirmation`'s value is ↵bogdanvlviv2017-11-051-0/+4
| | | | | | | | | | | | `false`
* | | Allow passing a Proc or Symbol as an argument to length validator valuesMatt Rohrer2017-10-261-0/+4
| | | | | | | | | | | | | | | This brings the Length validator in line with the Numericality validator, which currently supports Proc & Symbol arguments
* | | Add ActiveModel::Errors#merge!Jahfer Husain2017-07-071-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveModel::Errors#merge! allows ActiveModel::Errors to append errors from a separate ActiveModel::Errors instance onto their own. Example: person = Person.new person.errors.add(:name, :blank) errors = ActiveModel::Errors.new(Person.new) errors.add(:name, :invalid) person.errors.merge!(errors) puts person.errors.messages # => { name: ["can't be blank", "is invalid"] }
* | | :scissors:Ryuta Kamizono2017-06-281-1/+1
| | | | | | | | | | | | [ci skip]
* | | Fix regression in Numericality validator where extra decimal places on Bradley Priest2017-05-271-0/+5
| | | | | | | | | a user input for a decimal column were ignored by numerically validations
* | | Cleanup CHANGELOGs [ci skip]Ryuta Kamizono2017-04-301-21/+21
| | | | | | | | | | | | | | | | | | * Remove trailing spaces. * Add backticks around method and command. * Fix indentation.
* | | Remove CHANGELOG.md entry that appears in 5-1-stableJon Moss2017-03-291-4/+0
| | | | | | | | | | | | | | | | | | | | | This CHANGELOG.md is a continuation of the 5-1-stable one, there shouldn't be any duplicate entries. [ci skip]
* | | Fix ActiveModel::Errors #keys, #valuesbogdanvlviv2017-03-281-0/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before: person.errors.keys # => [] person.errors.values # => [] person.errors[:name] # => [] person.errors.keys # => [:name] person.errors.values # => [[]] After: person.errors.keys # => [] person.errors.values # => [] person.errors[:name] # => [] person.errors.keys # => [] person.errors.values # => [] Related to #23468
* | | Merge pull request #28050 from namusyaka/avoid-converting-int-into-floatRafael Mendonça França2017-03-271-0/+5
|\ \ \ | | | | | | | | | | | | Avoid converting integer as a string into float
| * | | Avoid converting integer as a string into floatnamusyaka2017-02-181-0/+4
| | | |
* | | | Start Rails 5.2 developmentMatthew Draper2017-03-221-32/+1
| |/ / |/| |
* | | Preparing for 5.1.0.beta1 releaseRafael Mendonça França2017-02-231-0/+2
|/ /
* | Remove deprecated behavior that halts callbacks when the return is falseRafael Mendonça França2017-02-071-0/+4
| |
* | Remove `ActiveModel::TestCase` from libyuuji.yaginuma2017-02-071-0/+4
| | | | | | | | | | | | `ActiveModel::TestCase` is used only for the test of Active Model. Also, it is a private API and can not be used in applications. Therefore, it is not necessary to include it in lib.
* | Merge pull request #26696 from iainbeeston/only-ruby-types-in-activemodelSean Griffin2016-12-081-0/+4
|\ \ | | | | | | | | | Moved database-specific ActiveModel types into ActiveRecord
| * | Moved database-specific ActiveModel types into ActiveRecordIain Beeston2016-10-141-0/+4
| |/ | | | | | | ie. DecimalWithoutScale, Text and UnsignedInteger
* / Allow indifferent access in ActiveModel::ErrorsKenichi Kamiya2016-11-221-0/+6
|/ | | | | | `#[]` has already applied indifferent access, but some methods does not. `#include?`, `#has_key?`, `#key?`, `#delete` and `#full_messages_for`.
* Removed deprecated :tokenizer in the length validatorRafael Mendonça França2016-10-101-0/+4
|
* Removed deprecated methods in ActiveModel::ErrorsRafael Mendonça França2016-10-101-0/+6
| | | | `#get`, `#set`, `[]=`, `add_on_empty` and `add_on_blank`.
* Start Rails 5.1 development :tada:Rafael Mendonça França2016-05-101-155/+1
|
* Preparing for 5.0.0.rc1 releaseRafael Mendonça França2016-05-061-0/+5
|
* Active Model: Improve CHANGELOG and documentation for ↵Prathamesh Sonpatki2016-05-051-4/+6
| | | | | | | | | | | `validates_acceptance_of` [ci skip] - Improve CHANGELOG entry for #18439. - The documentation is updated as per changes in PR #18439 to the `accept` option. - The explanation about the virtual attribute is moved at the end so that the arity of `accept` option is explained first. - Added a note that `message` can also be passed to `validates_acceptance_of`.
* Prep Rails 5 beta 4eileencodes2016-04-271-0/+2
|
* Allow passing record being validated to error message generatorPrathamesh Sonpatki2016-04-051-0/+5
| | | | | | | | | - Pass object to I18n helper so that when calling message proc, it will pass that object as argument to the proc and we can generate custom error messages based on current record being validated. - Based on https://github.com/rails/rails/issues/856. [Łukasz Bandzarewicz, Prathamesh Sonpatki]
* Preparing for 5.0.0.beta3 releaseeileencodes2016-02-241-0/+5
| | | | Adds changelog headers for beta3 release
* Preparing for Rails 5.0.0.beta2Sean Griffin2016-02-011-0/+5
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-10 18:31:08 +0000