diff options
author | bogdanvlviv <bogdanvlviv@gmail.com> | 2017-03-28 12:05:14 +0300 |
---|---|---|
committer | bogdanvlviv <bogdanvlviv@gmail.com> | 2017-03-28 18:48:56 +0300 |
commit | 01269aede398f63e5ef68ebe0f0dafbc472c686e (patch) | |
tree | eeb2a2fc509cb384d012e7ef5147aa09329ecbcd /activemodel/CHANGELOG.md | |
parent | d28c48243521a978ba8d432092e11a4aafb2b154 (diff) | |
download | rails-01269aede398f63e5ef68ebe0f0dafbc472c686e.tar.gz rails-01269aede398f63e5ef68ebe0f0dafbc472c686e.tar.bz2 rails-01269aede398f63e5ef68ebe0f0dafbc472c686e.zip |
Fix ActiveModel::Errors #keys, #values
Before:
person.errors.keys # => []
person.errors.values # => []
person.errors[:name] # => []
person.errors.keys # => [:name]
person.errors.values # => [[]]
After:
person.errors.keys # => []
person.errors.values # => []
person.errors[:name] # => []
person.errors.keys # => []
person.errors.values # => []
Related to #23468
Diffstat (limited to 'activemodel/CHANGELOG.md')
-rw-r--r-- | activemodel/CHANGELOG.md | 30 |
1 files changed, 30 insertions, 0 deletions
diff --git a/activemodel/CHANGELOG.md b/activemodel/CHANGELOG.md index 6b9b3dd7ff..16b1b50cb3 100644 --- a/activemodel/CHANGELOG.md +++ b/activemodel/CHANGELOG.md @@ -1,3 +1,33 @@ +* Fix methods `#keys`, `#values` in `ActiveModel::Errors`. + + Change `#keys` to only return the keys that don't have empty messages. + + Change `#values` to only return the not empty values. + + Example: + + # Before + person = Person.new + person.errors.keys # => [] + person.errors.values # => [] + person.errors.messages # => {} + person.errors[:name] # => [] + person.errors.messages # => {:name => []} + person.errors.keys # => [:name] + person.errors.values # => [[]] + + # After + person = Person.new + person.errors.keys # => [] + person.errors.values # => [] + person.errors.messages # => {} + person.errors[:name] # => [] + person.errors.messages # => {:name => []} + person.errors.keys # => [] + person.errors.values # => [] + + *bogdanvlviv* + * Avoid converting integer as a string into float. *namusyaka* |