Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 1 | -5/+5 | |
| | ||||||
* | Privatize unneededly protected methods in Active Job tests | Akira Matsuda | 2016-12-24 | 2 | -2/+2 | |
| | ||||||
* | Remove warning in ActiveJob | Kir Shatrov | 2016-12-21 | 1 | -1/+1 | |
| | | | | | | | | Currently it causes: ``` activejob/Rakefile:5: warning: already initialized constant ACTIVEJOB_ADAPTERS ``` | |||||
* | Output adapter being tested. | utilum | 2016-12-12 | 1 | -0/+1 | |
| | ||||||
* | Avoid race condition in AJ integration tests | Matthew Draper | 2016-11-30 | 2 | -1/+3 | |
| | | | | Make sure the file doesn't exist until we've finished writing it. | |||||
* | remove Ruby warning from Active Job test helper methods | yuuji.yaginuma | 2016-11-18 | 1 | -4/+4 | |
| | | | | | | | | | This removes the following warnings. ``` /home/travis/build/rails/rails/activejob/lib/active_job/test_helper.rb:241: warning: shadowing outer local variable - job /home/travis/build/rails/rails/activejob/lib/active_job/test_helper.rb:265: warning: shadowing outer local variable - job ``` | |||||
* | Use named parameters instead of `assert_valid_keys` | Maxime Boisvert | 2016-11-16 | 1 | -8/+8 | |
| | ||||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 18 | -23/+23 | |
| | ||||||
* | removes requires already present in active_support/rails | Xavier Noria | 2016-10-27 | 2 | -2/+0 | |
| | ||||||
* | Uses queue adapter_method instead of ActiveJob::Base.queue_adapter | Gabi Stefanini | 2016-10-24 | 1 | -2/+2 | |
| | | | | Change ActiveJob::Base.queue_adapter to use queue_adapter method to make test code consistent. | |||||
* | Add examples of queue_adapter and perform_enqueued jobs to API Docs. | Gabi Stefanini | 2016-10-21 | 1 | -0/+24 | |
| | ||||||
* | add missing closing tag [ci skip] | yuuji.yaginuma | 2016-10-14 | 1 | -1/+1 | |
| | ||||||
* | Removed deprecated support to passing the adapter class to .queue_adapter | Rafael Mendonça França | 2016-10-10 | 3 | -23/+4 | |
| | ||||||
* | Removed deprecated #original_exception in ActiveJob::DeserializationError | Rafael Mendonça França | 2016-10-10 | 2 | -13/+5 | |
| | ||||||
* | Merge pull request #26740 from y-yagi/update_retry_on_example | Jon Moss | 2016-10-08 | 1 | -2/+2 | |
|\ | | | | | correct exception class in `retry_on` example [ci skip] | |||||
| * | correct exception class in `retry_on` example [ci skip] | yuuji.yaginuma | 2016-10-09 | 1 | -2/+2 | |
| | | | | | | | | | | If the deadlock has occurred `ActiveRecord::Deadlocked` will raise. Ref: #25107, #26059 | |||||
* | | Fixnum and Bignum are deprecated in Ruby trunk | Matthew Draper | 2016-10-08 | 1 | -2/+2 | |
|/ | | | | https://bugs.ruby-lang.org/issues/12739 | |||||
* | fix link to `resque` [ci skip] | yuuji.yaginuma | 2016-09-20 | 1 | -1/+1 | |
| | | | | | `1-x-stable` branch does not exist, `master` is 1.x branch. Ref: http://words.steveklabnik.com/rescuing-resque-again | |||||
* | use `descendants` to get class that inherited `ActiveJob::Base` | yuuji.yaginuma | 2016-09-05 | 4 | -1/+17 | |
| | | | | | | `subclasses` get only child classes. Therefore, if create a job common parent class as `ApplicationJob`, inherited class does not get properly. | |||||
* | fixes remaining RuboCop issues [Vipul A M, Xavier Noria] | Xavier Noria | 2016-09-01 | 3 | -3/+3 | |
| | ||||||
* | Add load hooks to all tests classes | Rafael Mendonça França | 2016-08-25 | 1 | -0/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | Usually users extends tests classes doing something like: ActionView::TestCase.include MyCustomTestHelpers This is bad because it will load the ActionView::TestCase right aways and this will load ActionController::Base making its on_load hooks to execute early than it should. One way to fix this is using the on_load hooks of the components like: ActiveSupport.on_load(:action_view) do ActionView::TestCase.include MyCustomTestHelpers end The problem with this approach is that the test extension will be only load when ActionView::Base is loaded and this may happen too late in the test. To fix this we are adding hooks to people extend the test classes that will be loaded exactly when the test classes are needed. | |||||
* | Merge pull request #26205 from pedaling-corp/fix/active-job-resque | Rafael Mendonça França | 2016-08-23 | 3 | -2/+16 | |
|\ | | | | | | | Add @queue variable to JobWrapper | |||||
| * | Added instance variable `@queue` to JobWrapper. | InJung Chung | 2016-08-19 | 3 | -0/+16 | |
| | | | | | | | | | | This will fix issues in [resque-scheduler](https://github.com/resque/resque-scheduler) `#job_to_hash` method, so we can use `#enqueue_delayed_selection`, `#remove_delayed` method in resque-scheduler smoothly. | |||||
* | | correct exception class in `retry_on` example [ci skip] | yuuji.yaginuma | 2016-08-20 | 1 | -2/+2 | |
|/ | | | | | If the deadlock has occurred `ActiveRecord::Deadlocked` will raise. Ref: #25107, #26059 | |||||
* | Yield the job instance so you have access to things like `job.arguments` on ↵ | David Heinemeier Hansson | 2016-08-16 | 4 | -6/+10 | |
| | | | | the custom logic after retries fail | |||||
* | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 2 | -9/+9 | |
| | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | |||||
* | Pass over changelogs [ci skip] | Vipul A M | 2016-08-10 | 1 | -1/+1 | |
| | ||||||
* | code gardening: removes redundant selfs | Xavier Noria | 2016-08-08 | 3 | -4/+4 | |
| | | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required. | |||||
* | Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty lines | Ryuta Kamizono | 2016-08-07 | 3 | -4/+0 | |
| | ||||||
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 5 | -5/+0 | |
| | ||||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 15 | -115/+109 | |
| | ||||||
* | remove redundant curlies from hash arguments | Xavier Noria | 2016-08-06 | 1 | -3/+2 | |
| | ||||||
* | modernizes hash syntax in activejob | Xavier Noria | 2016-08-06 | 3 | -12/+12 | |
| | ||||||
* | applies new string literal convention to the rest of the project | Xavier Noria | 2016-08-06 | 1 | -16/+16 | |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | |||||
* | applies new string literal convention in the gemspecs | Xavier Noria | 2016-08-06 | 1 | -13/+13 | |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | |||||
* | applies new string literal convention in activejob/test | Xavier Noria | 2016-08-06 | 47 | -279/+279 | |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | |||||
* | applies new string literal convention in activejob/lib | Xavier Noria | 2016-08-06 | 28 | -99/+99 | |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | |||||
* | Offer invitations to use retry_on/discard_on for common cases | David Heinemeier Hansson | 2016-08-04 | 1 | -0/+5 | |
| | ||||||
* | Guard against jobs that were persisted before we started counting executions ↵ | David Heinemeier Hansson | 2016-08-03 | 1 | -1/+3 | |
| | | | | by zeroing out nil counters | |||||
* | Amend the CHANGELOG | David Heinemeier Hansson | 2016-08-02 | 1 | -0/+21 | |
| | ||||||
* | Fix tests against ActiveSupport::Durations | David Heinemeier Hansson | 2016-08-02 | 3 | -32/+56 | |
| | ||||||
* | Please Rubocup | David Heinemeier Hansson | 2016-08-02 | 2 | -5/+5 | |
| | ||||||
* | Not needed | David Heinemeier Hansson | 2016-08-01 | 1 | -1/+0 | |
| | ||||||
* | Allow for custom handling of exceptions that persist beyond the retry attempts | David Heinemeier Hansson | 2016-08-01 | 3 | -4/+21 | |
| | ||||||
* | Add exponentially_longer and custom wait algorithms | David Heinemeier Hansson | 2016-08-01 | 3 | -3/+68 | |
| | ||||||
* | Use descriptive exception names | David Heinemeier Hansson | 2016-08-01 | 2 | -20/+20 | |
| | ||||||
* | Executions counting is not a serialization concern | David Heinemeier Hansson | 2016-08-01 | 2 | -1/+2 | |
| | | | | | Let’s do it when we actually execute instead. Then the tests dealing with comparable serializations won’t fail either! | |||||
* | Reraise instead of swallow exceptions that occur beyond the retry attempts | David Heinemeier Hansson | 2016-07-29 | 2 | -2/+3 | |
| | ||||||
* | Proper logging when we bail on retrying after X attempts | David Heinemeier Hansson | 2016-07-29 | 1 | -2/+6 | |
| | ||||||
* | Allow retries to happen with different priority and queue | David Heinemeier Hansson | 2016-07-29 | 1 | -2/+4 | |
| |