diff options
author | Rafael Mendonça França <rafaelmfranca@gmail.com> | 2016-08-25 04:22:48 -0300 |
---|---|---|
committer | Rafael Mendonça França <rafaelmfranca@gmail.com> | 2016-08-25 04:22:48 -0300 |
commit | 0510208dd1ff23baa619884c0abcae4d141fae53 (patch) | |
tree | 1c2fdc58d710af54ee07fdfbb2ca00a23e16c2be /activejob | |
parent | 804f5b3c2af90b69a51209c56739a077f3fb632b (diff) | |
download | rails-0510208dd1ff23baa619884c0abcae4d141fae53.tar.gz rails-0510208dd1ff23baa619884c0abcae4d141fae53.tar.bz2 rails-0510208dd1ff23baa619884c0abcae4d141fae53.zip |
Add load hooks to all tests classes
Usually users extends tests classes doing something like:
ActionView::TestCase.include MyCustomTestHelpers
This is bad because it will load the ActionView::TestCase right aways
and this will load ActionController::Base making its on_load hooks to
execute early than it should.
One way to fix this is using the on_load hooks of the components like:
ActiveSupport.on_load(:action_view) do
ActionView::TestCase.include MyCustomTestHelpers
end
The problem with this approach is that the test extension will be only
load when ActionView::Base is loaded and this may happen too late in the
test.
To fix this we are adding hooks to people extend the test classes that
will be loaded exactly when the test classes are needed.
Diffstat (limited to 'activejob')
-rw-r--r-- | activejob/lib/active_job/test_case.rb | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/activejob/lib/active_job/test_case.rb b/activejob/lib/active_job/test_case.rb index 0d97e00bfa..a5ec45e4a7 100644 --- a/activejob/lib/active_job/test_case.rb +++ b/activejob/lib/active_job/test_case.rb @@ -3,5 +3,7 @@ require "active_support/test_case" module ActiveJob class TestCase < ActiveSupport::TestCase include ActiveJob::TestHelper + + ActiveSupport.run_load_hooks(:active_job_test_case, self) end end |