aboutsummaryrefslogtreecommitdiffstats
path: root/activejob
Commit message (Collapse)AuthorAgeFilesLines
* bin/test for Active Job and Action Cable testsAkira Matsuda2017-02-021-0/+4
| | | | | | According to the commit comment on 54d84cbb77a7fbc6359eda4eb40cc7da29c426e1, AJ/bin/test was intentionally not added, but AJ tests doesn't actually do anything special other than specifying ENV['AJ_ADAPTER'], which can be easily done via command line environment variable.
* correctly set test adapter when configure the queue adapter on a per job ↵Yuji Yaginuma2017-01-315-10/+62
| | | | | | | | | | | | (#26690) The `ActiveJob::TestHelper` replace the adapter to test adapter in `before_setup`. It gets the target class using the `descendants`, but if the test target job class is not loaded, will not be a replacement of the adapter. Therefore, instead of replacing with `before_setup`, modified to replace when setting adapter. Fixes #26360
* Append skipped jobs to enqueued_jobsAlexander Pauly2017-01-313-7/+18
| | | | | | | | | | Refactored ActiveJob TestAdapter Updated ActiveJob changelog Fixed typo in changelog Fixed formatting issue in changelog
* make backburner integration test to workyuuji.yaginuma2017-01-281-2/+2
| | | | | | | | | | | | | Currently, backburner integration test is not running on CI. https://travis-ci.org/rails/rails/jobs/196005322#L610 Using `Backburner::Worker.connection` to check whether beanstalkd is running. But `Backburner::Worker.connection` was removed in backburner 1.2.0. https://github.com/nesquena/backburner/commit/81fde499c2263abe8dedee59a3d0e03e92d72627 Therefore, this check process always becomes false, so the test is no longer done. I fixed it so that check processing is done correctly.
* Merge pull request #27624 from elfassy/assert_enqueued_jobs_with_queue_levelGuillermo Iguaran2017-01-192-10/+45
|\ | | | | Specify the queue to be used with assert_enqueued_jobs
| * assert_enqueued_jobs with queue optionMichael Elfassy2017-01-182-10/+45
| |
* | s/perfomed/performed/Akira Matsuda2017-01-171-1/+1
| | | | | | | | [ci skip]
* | remove unused requireyuuji.yaginuma2017-01-151-1/+0
|/ | | | `InlineAdapter` is not used from 1f8558f.
* `self.` is not needed when calling its own instance methodAkira Matsuda2017-01-054-4/+4
| | | | Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby
* Revert "Merge pull request #27550 from ↵Rafael Mendonça França2017-01-031-1/+1
| | | | | | | | | mtsmfm/fix-generator-command-for-nested-rails-engine" This reverts commit 1e969bfb98b88799e2c759fce25a1d8cf00d7ce7, reversing changes made to a5041f267ded119c2d00b8786c2f2c1e3f93c8a1. Reason: It breaks the public API
* Fix generator command for nested (namespaced) rails engineFumiaki MATSUSHIMA2017-01-031-1/+1
| | | | | | | | | | | | | If we create nested (namespaced) rails engine such like bukkits-admin, `bin/rails g scaffold User name:string age:integer` will create `bukkits-admin/app/controllers/bukkits/users_controller.rb` but it should create `bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`. In #6643, we changed `namespaced_path` as root path because we supposed application_controller is always in root but nested rails engine's application_controller will not.
* Merge pull request #27508 from zzz6519003/patch-1Rafael França2017-01-011-2/+0
|\ | | | | remove useless import
| * remove useless importSnowmanzzz(Zhengzhong Zhao)2016-12-301-2/+0
| |
* | Bump license years for 2017Jon Moss2016-12-312-2/+2
|/ | | | | | | | Per https://www.timeanddate.com/counters/firstnewyear.html, it's already 2017 in a lot of places, so we should bump the Rails license years to 2017. [ci skip]
* Delayed job doesn't support Active Record 5.1 yetRafael Mendonça França2016-12-291-1/+2
|
* "Use assert_nil if expecting nil. This will fail in minitest 6."Akira Matsuda2016-12-252-3/+3
|
* Privatize unneededly protected method in Active JobAkira Matsuda2016-12-241-2/+2
|
* No need to nodoc private methodsAkira Matsuda2016-12-241-5/+5
|
* Privatize unneededly protected methods in Active Job testsAkira Matsuda2016-12-242-2/+2
|
* Remove warning in ActiveJobKir Shatrov2016-12-211-1/+1
| | | | | | | | Currently it causes: ``` activejob/Rakefile:5: warning: already initialized constant ACTIVEJOB_ADAPTERS ```
* Output adapter being tested.utilum2016-12-121-0/+1
|
* Avoid race condition in AJ integration testsMatthew Draper2016-11-302-1/+3
| | | | Make sure the file doesn't exist until we've finished writing it.
* remove Ruby warning from Active Job test helper methodsyuuji.yaginuma2016-11-181-4/+4
| | | | | | | | | This removes the following warnings. ``` /home/travis/build/rails/rails/activejob/lib/active_job/test_helper.rb:241: warning: shadowing outer local variable - job /home/travis/build/rails/rails/activejob/lib/active_job/test_helper.rb:265: warning: shadowing outer local variable - job ```
* Use named parameters instead of `assert_valid_keys`Maxime Boisvert2016-11-161-8/+8
|
* Add more rubocop rules about whitespacesRafael Mendonça França2016-10-2918-23/+23
|
* removes requires already present in active_support/railsXavier Noria2016-10-272-2/+0
|
* Uses queue adapter_method instead of ActiveJob::Base.queue_adapterGabi Stefanini2016-10-241-2/+2
| | | | Change ActiveJob::Base.queue_adapter to use queue_adapter method to make test code consistent.
* Add examples of queue_adapter and perform_enqueued jobs to API Docs.Gabi Stefanini2016-10-211-0/+24
|
* add missing closing tag [ci skip]yuuji.yaginuma2016-10-141-1/+1
|
* Removed deprecated support to passing the adapter class to .queue_adapterRafael Mendonça França2016-10-103-23/+4
|
* Removed deprecated #original_exception in ActiveJob::DeserializationErrorRafael Mendonça França2016-10-102-13/+5
|
* Merge pull request #26740 from y-yagi/update_retry_on_exampleJon Moss2016-10-081-2/+2
|\ | | | | correct exception class in `retry_on` example [ci skip]
| * correct exception class in `retry_on` example [ci skip]yuuji.yaginuma2016-10-091-2/+2
| | | | | | | | | | If the deadlock has occurred `ActiveRecord::Deadlocked` will raise. Ref: #25107, #26059
* | Fixnum and Bignum are deprecated in Ruby trunkMatthew Draper2016-10-081-2/+2
|/ | | | https://bugs.ruby-lang.org/issues/12739
* fix link to `resque` [ci skip]yuuji.yaginuma2016-09-201-1/+1
| | | | | `1-x-stable` branch does not exist, `master` is 1.x branch. Ref: http://words.steveklabnik.com/rescuing-resque-again
* use `descendants` to get class that inherited `ActiveJob::Base`yuuji.yaginuma2016-09-054-1/+17
| | | | | | `subclasses` get only child classes. Therefore, if create a job common parent class as `ApplicationJob`, inherited class does not get properly.
* fixes remaining RuboCop issues [Vipul A M, Xavier Noria]Xavier Noria2016-09-013-3/+3
|
* Add load hooks to all tests classesRafael Mendonça França2016-08-251-0/+2
| | | | | | | | | | | | | | | | | | | | | | | Usually users extends tests classes doing something like: ActionView::TestCase.include MyCustomTestHelpers This is bad because it will load the ActionView::TestCase right aways and this will load ActionController::Base making its on_load hooks to execute early than it should. One way to fix this is using the on_load hooks of the components like: ActiveSupport.on_load(:action_view) do ActionView::TestCase.include MyCustomTestHelpers end The problem with this approach is that the test extension will be only load when ActionView::Base is loaded and this may happen too late in the test. To fix this we are adding hooks to people extend the test classes that will be loaded exactly when the test classes are needed.
* Merge pull request #26205 from pedaling-corp/fix/active-job-resqueRafael Mendonça França2016-08-233-2/+16
|\ | | | | | | Add @queue variable to JobWrapper
| * Added instance variable `@queue` to JobWrapper.InJung Chung2016-08-193-0/+16
| | | | | | | | | | This will fix issues in [resque-scheduler](https://github.com/resque/resque-scheduler) `#job_to_hash` method, so we can use `#enqueue_delayed_selection`, `#remove_delayed` method in resque-scheduler smoothly.
* | correct exception class in `retry_on` example [ci skip]yuuji.yaginuma2016-08-201-2/+2
|/ | | | | If the deadlock has occurred `ActiveRecord::Deadlocked` will raise. Ref: #25107, #26059
* Yield the job instance so you have access to things like `job.arguments` on ↵David Heinemeier Hansson2016-08-164-6/+10
| | | | the custom logic after retries fail
* Add three new rubocop rulesRafael Mendonça França2016-08-162-9/+9
| | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* Pass over changelogs [ci skip]Vipul A M2016-08-101-1/+1
|
* code gardening: removes redundant selfsXavier Noria2016-08-083-4/+4
| | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required.
* Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty linesRyuta Kamizono2016-08-073-4/+0
|
* applies remaining conventions across the projectXavier Noria2016-08-065-5/+0
|
* normalizes indentation and whitespace across the projectXavier Noria2016-08-0615-115/+109
|
* remove redundant curlies from hash argumentsXavier Noria2016-08-061-3/+2
|
* modernizes hash syntax in activejobXavier Noria2016-08-063-12/+12
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 22:03:16 +0000