aboutsummaryrefslogtreecommitdiffstats
path: root/activejob
Commit message (Collapse)AuthorAgeFilesLines
* use `descendants` to get class that inherited `ActiveJob::Base`yuuji.yaginuma2016-09-054-1/+17
| | | | | | `subclasses` get only child classes. Therefore, if create a job common parent class as `ApplicationJob`, inherited class does not get properly.
* fixes remaining RuboCop issues [Vipul A M, Xavier Noria]Xavier Noria2016-09-013-3/+3
|
* Add load hooks to all tests classesRafael Mendonça França2016-08-251-0/+2
| | | | | | | | | | | | | | | | | | | | | | | Usually users extends tests classes doing something like: ActionView::TestCase.include MyCustomTestHelpers This is bad because it will load the ActionView::TestCase right aways and this will load ActionController::Base making its on_load hooks to execute early than it should. One way to fix this is using the on_load hooks of the components like: ActiveSupport.on_load(:action_view) do ActionView::TestCase.include MyCustomTestHelpers end The problem with this approach is that the test extension will be only load when ActionView::Base is loaded and this may happen too late in the test. To fix this we are adding hooks to people extend the test classes that will be loaded exactly when the test classes are needed.
* Merge pull request #26205 from pedaling-corp/fix/active-job-resqueRafael Mendonça França2016-08-233-2/+16
|\ | | | | | | Add @queue variable to JobWrapper
| * Added instance variable `@queue` to JobWrapper.InJung Chung2016-08-193-0/+16
| | | | | | | | | | This will fix issues in [resque-scheduler](https://github.com/resque/resque-scheduler) `#job_to_hash` method, so we can use `#enqueue_delayed_selection`, `#remove_delayed` method in resque-scheduler smoothly.
* | correct exception class in `retry_on` example [ci skip]yuuji.yaginuma2016-08-201-2/+2
|/ | | | | If the deadlock has occurred `ActiveRecord::Deadlocked` will raise. Ref: #25107, #26059
* Yield the job instance so you have access to things like `job.arguments` on ↵David Heinemeier Hansson2016-08-164-6/+10
| | | | the custom logic after retries fail
* Add three new rubocop rulesRafael Mendonça França2016-08-162-9/+9
| | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* Pass over changelogs [ci skip]Vipul A M2016-08-101-1/+1
|
* code gardening: removes redundant selfsXavier Noria2016-08-083-4/+4
| | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required.
* Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty linesRyuta Kamizono2016-08-073-4/+0
|
* applies remaining conventions across the projectXavier Noria2016-08-065-5/+0
|
* normalizes indentation and whitespace across the projectXavier Noria2016-08-0615-115/+109
|
* remove redundant curlies from hash argumentsXavier Noria2016-08-061-3/+2
|
* modernizes hash syntax in activejobXavier Noria2016-08-063-12/+12
|
* applies new string literal convention to the rest of the projectXavier Noria2016-08-061-16/+16
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* applies new string literal convention in the gemspecsXavier Noria2016-08-061-13/+13
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* applies new string literal convention in activejob/testXavier Noria2016-08-0647-279/+279
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* applies new string literal convention in activejob/libXavier Noria2016-08-0628-99/+99
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Offer invitations to use retry_on/discard_on for common casesDavid Heinemeier Hansson2016-08-041-0/+5
|
* Guard against jobs that were persisted before we started counting executions ↵David Heinemeier Hansson2016-08-031-1/+3
| | | | by zeroing out nil counters
* Amend the CHANGELOGDavid Heinemeier Hansson2016-08-021-0/+21
|
* Fix tests against ActiveSupport::DurationsDavid Heinemeier Hansson2016-08-023-32/+56
|
* Please RubocupDavid Heinemeier Hansson2016-08-022-5/+5
|
* Not neededDavid Heinemeier Hansson2016-08-011-1/+0
|
* Allow for custom handling of exceptions that persist beyond the retry attemptsDavid Heinemeier Hansson2016-08-013-4/+21
|
* Add exponentially_longer and custom wait algorithmsDavid Heinemeier Hansson2016-08-013-3/+68
|
* Use descriptive exception namesDavid Heinemeier Hansson2016-08-012-20/+20
|
* Executions counting is not a serialization concernDavid Heinemeier Hansson2016-08-012-1/+2
| | | | | Let’s do it when we actually execute instead. Then the tests dealing with comparable serializations won’t fail either!
* Reraise instead of swallow exceptions that occur beyond the retry attemptsDavid Heinemeier Hansson2016-07-292-2/+3
|
* Proper logging when we bail on retrying after X attemptsDavid Heinemeier Hansson2016-07-291-2/+6
|
* Allow retries to happen with different priority and queueDavid Heinemeier Hansson2016-07-291-2/+4
|
* Require time extension for 3.seconds defaultDavid Heinemeier Hansson2016-07-291-0/+2
|
* Mention defaultsDavid Heinemeier Hansson2016-07-291-2/+2
|
* Satisfy pedantic rubocop whitespace detectionDavid Heinemeier Hansson2016-07-292-6/+6
|
* Remove needless requireDavid Heinemeier Hansson2016-07-291-2/+0
|
* Add retry_on/discard_on for better exception handlingDavid Heinemeier Hansson2016-07-296-26/+155
|
* Fix accessing provider_job_id inside active jobs for sidekiq adapterAzzurrio2016-07-284-1/+18
|
* Fix AJ tests on ruby 2.4 being causes since classes are unified for Integer, ↵Vipul A M2016-07-091-1/+1
| | | | and we create test name nased on arg class. Append ar as well to the test name
* Fix jobs overriding AJ::Base#loggerJean Boussier2016-06-173-2/+16
|
* Provide the ability to override the queue adapter used by jobs underSteve Lounsbury2016-06-112-1/+26
| | | | | | | | | | | | | test. This PR adds a method called `queue_adapter_for_test` to `ActiveJob::TestHelper`. This method is expected to provide the queue adapter to be used for jobs under test. It maintains the current behaviour by defaulting to an instance of `ActiveJob::QueueAdapter::TestAdapter`. Tests that include `ActiveJob::TestHelper` or extend from `ActiveJob::TestCase` can provide a custom queue adapter by overriding `queue_adapter_for_test` in their class.
* Fix typo, `of of` -> `of` [ci skip]Jake Worth2016-06-091-1/+1
|
* [ci skip] Reword doc for around_enqueue callbackTim Wade2016-05-271-2/+2
| | | | | | Taken literally, the documentation suggests that the callback gets called twice (before and after enqueueing). By wording it similarly to that of around_perform this confusion is avoided.
* Remove package:clean taskJavan Makhmali2016-05-241-1/+0
| | | | Introduced in d6f2000a67cc63aa67414c75ce77de671824ec52 and was only used by Action Cable. Now handled by Action Cable’s assets:compile task.
* Support for unified Integer class in Ruby 2.4+Jeremy Daer2016-05-181-2/+3
| | | | | | | | Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005 * Forward compat with new unified Integer class in Ruby 2.4+. * Backward compat with separate Fixnum/Bignum in Ruby 2.2 & 2.3. * Drops needless Fixnum distinction in docs, preferring Integer.
* Action Mailer: Declarative exception handling with `rescue_from`.Jeremy Daer2016-05-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | Follows the same pattern as controllers and jobs. Exceptions raised in delivery jobs (enqueued by `#deliver_later`) are also delegated to the mailer's rescue_from handlers, so you can handle the DeserializationError raised by delivery jobs: ```ruby class MyMailer < ApplicationMailer rescue_from ActiveJob::DeserializationError do … end ``` ActiveSupport::Rescuable polish: * Add the `rescue_with_handler` class method so exceptions may be handled at the class level without requiring an instance. * Rationalize `exception.cause` handling. If no handler matches the exception, fall back to the handler that matches its cause. * Handle exceptions raised elsewhere. Pass `object: …` to execute the `rescue_from` handler (e.g. a method call or a block to instance_exec) against a different object. Defaults to `self`.
* Start Rails 5.1 development :tada:Rafael Mendonça França2016-05-103-186/+5
|
* Preparing for 5.0.0.rc1 releaseRafael Mendonça França2016-05-062-1/+6
|
* Chomp: prefer String#chomp where we can for a clarity boostlvl0nax2016-04-291-1/+3
| | | | | | Closes #24766, #24767 Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
* Active Job: Add note about ability to configure adapters on per job basis in ↵Prathamesh Sonpatki2016-04-291-0/+17
| | | | | | CHANGELOG and release notes. [ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 06:02:06 +0000