aboutsummaryrefslogtreecommitdiffstats
path: root/actionview
Commit message (Collapse)AuthorAgeFilesLines
* Tiny documentation fixes [ci skip]Robin Dupret2016-07-041-4/+9
| | | | | | Fix a link to use RDoc syntax and make sure that the titles' level match the section we are in since we are both documenting the new and the legacy syntax.
* `partial` option on the digest method is no more needed [ci skip]:Edouard CHIN2016-07-021-1/+0
| | | | - `partial` option is not used anymore, this was removed in https://github.com/rails/rails/pull/23724
* Merge pull request #25553 from vipulnsward/25543-docs-follow-upVipul A M2016-06-301-16/+7
|\ | | | | 25543 docs cleanup
| * - Tone down documentationVipul A M2016-06-281-16/+7
| | | | | | | | | | | | | | - Remove repetative docs - Fix grammar on sentences - Add escaping for literals [ci skip]
* | [ci skip] Update formatting in ActionView::Base documentationAlex Kitchens2016-06-291-6/+6
| |
* | - Added select tag test for verifying passing html options to f.select helperVipul A M2016-06-281-1/+10
| | | | | | | | - Renamed test to be more descriptive
* | Add dup leftover from 26710ab.Kasper Timm Hansen2016-06-281-1/+1
| |
* | Default to frozen string literals in TagHelper.Kasper Timm Hansen2016-06-281-5/+7
| | | | | | | | Removes littering `freeze` calls with Ruby 2.3's magic comment.
* | Merge pull request #25555 from vipulnsward/boolean-attributes-updateRafael França2016-06-284-14/+13
|\ \ | | | | | | Bring Boolean Attributes list for AV Tags helper upto speed with current spec
| * | Bring Boolean Attributes list for AV Tags helper upto speed with current spec.Vipul A M2016-06-284-14/+13
| |/ | | | | | | | | | | | | | | | | This is based on https://github.com/kangax/html-minifier/blob/6b2d4536d82819143b468b41a89c700b6c61631f/src/htmlminifier.js#L197 and spec from https://www.w3.org/TR/html51/single-page.html. Couple of other changes to tests due to support update: - autobuffer has been dropped in favour of preload attribute, ref: https://msdn.microsoft.com/en-us/library/ff974743(v=vs.85).aspx - pubdate attribute has been dropped from spec, ref: https://www.w3.org/html/wg/tracker/issues/185
* | Merge pull request #25551 from vipulnsward/25543-follow-upKasper Timm Hansen2016-06-281-1/+1
|\ \ | | | | | | Expand list of void elements to match spec
| * | Expand list of void elements to match spec from ↵Vipul A M2016-06-281-1/+1
| |/ | | | | | | https://html.spec.whatwg.org/multipage/syntax.html#void-elements
* / Freeze string for default content for tag_strings, which later goes on to ↵Vipul A M2016-06-281-1/+1
|/ | | | create new content. This should also be inline with content being passed should not be mutable
* Document `simple_format` handling of `\r`Derek Prior2016-06-271-4/+5
| | | | | | | `simple_format` handles `\r\n` and `\r` but previously did not document this behavior. The handling is done with a `gsub` in `split_paragraphs`. [ci skip]
* New syntax for tag helpers i.e. tag.br instead of tag(br) #25195Marek2016-06-276-63/+364
|
* Fix typo in exception class nameCédric Félizard2016-06-261-1/+1
|
* Merge pull request #25287 from marekkirejczyk/fix_25267Godfrey Chan2016-06-252-1/+8
|\ | | | | Make select_year work with include_position: true option, fix #25267
| * Make select_year work with include_position: true option, fix #25267Marek2016-06-052-1/+8
| |
* | English fixGeorge Millo2016-06-231-1/+1
| | | | | | --skip-ci
* | Merge pull request #25469 from ↵Rafael Mendonça França2016-06-226-139/+39
|\ \ | | | | | | | | | | | | | | | herminiotorres/update-datetime-to-datetime-local-by-html-specification Change datetime to datetime-local helper tag
| * | Change datetime to datetime-local helper tagHerminio Torres2016-06-216-139/+39
|/ / | | | | | | | | | | | | | | | | | | | | A change was made in the helper that renders the `datetime`, being now by default `datetime-local` and creating an alias of `datetime-local` for `datetime`, `datetime` tag and it passes to be an abstract class for all other tags that inherit from him. As a new specification of the HTML 5 the text field type `datetime` will no longer exist and will pass a `datetime-local`. Ref: https://html.spec.whatwg.org/multipage/forms.html#local-date-and-time-state-(type=datetime-local)
* | Revert "Merge pull request #17973 from maurogeorge/file_field_hidden_field"eileencodes2016-06-213-53/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | The reason we are reverting this commit is because it created breaking changes for file upload gems. For more information see discussion here: https://github.com/rails/rails/issues/17947#issuecomment-225154294 This reverts commit c455817804e4df64c46c17a0cdec0e5a1ca5ba2e, reversing changes made to 8b3cd74b8a09ef85a43d7631bb062a9ec7f57227. Conflicts: actionview/CHANGELOG.md actionview/lib/action_view/helpers/form_helper.rb
* | Change the raw template handler to render html-safe stringseileencodes2016-06-213-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In PR #24929 the changelog was updated to make note that while the new template handler was changed to raw this changed the behavior when outputting plain html or js files. Previously ERB would output the files unescaped. Changing the default handler to RAW meant that these same files would be rendered as escaped rather than as js or html. Because of this change in behavior and after the discussion #24949 in we decided to change the behavior of the Raw handler to output html_safe strings by default. Now files rendered with the default handler (raw) render the file unescaped.
* | Add test for nested html dependencies with same logical name as templates ↵Javan Makhmali2016-06-151-2/+6
| | | | | | | | for other formats
* | Move and rename testJavan Makhmali2016-06-151-7/+7
| |
* | Fix finding templates for digesting for */* requests that render a ↵Javan Makhmali2016-06-154-3/+30
| | | | | | | | non-default (html) template
* | Explicity find with the rendered format to handle searching multiple view ↵Javan Makhmali2016-06-153-4/+2
| | | | | | | | paths correctly
* | Fix digesting templates with identical logical names when requesting a ↵Javan Makhmali2016-06-153-4/+18
| | | | | | | | format other than the first default
* | Explicitly require `acts_like` in AVSean Griffin2016-06-131-0/+1
| | | | | | | | | | | | This method is used in `distance_of_time_in_words` Fixes #25357
* | remove deprecated `:prefix` option from doc [ci skip]yuuji.yaginuma2016-06-091-2/+0
| | | | | | | | The option was deprecated in #21191.
* | Merge pull request #25079 from jeffkreeftmeijer/send_file-halts-request-cycleSean Griffin2016-06-071-5/+0
|\ \ | | | | | | | | | Use `#performed?` to terminate controller callbacks
| * | Delete bad testSean Griffin2016-06-071-5/+0
| |/ | | | | | | | | | | | | | | | | | | | | | | This test was broken by f650e0324207e46ed5240380e60bdf1e2a5023a6. It was added by https://github.com/rails/rails/pull/17978, and is adequately tested elsewhere. The reason that this breaks is that `Controller#process` is not going to set a new response object, and we now terminate in callbacks if the response has been sent. The only reason that this test was calling `get` in the first place was because the controller under test blows up if `request` was `nil`. The point being that the failure is invalid, and I don't think we need to fix the test in this location.
* / Fix a typo in `time_field` [ci skip]Jake Worth2016-06-051-1/+1
|/
* Fix debug helper testRyuta Kamizono2016-06-031-1/+4
|
* Remove package:clean taskJavan Makhmali2016-05-241-1/+0
| | | | Introduced in d6f2000a67cc63aa67414c75ce77de671824ec52 and was only used by Action Cable. Now handled by Action Cable’s assets:compile task.
* Remove space, properly italicizeJon Moss2016-05-211-5/+5
| | | | | | Difference in rendering --> https://gist.github.com/maclover7/a50ff9231eb825c39c77cd5858af6d9a [ci skip]
* Confirm with the specification when generating emtpy option for select with ↵Vipul A M2016-05-213-6/+25
| | | | | | | | | | | | `include_blank: true` option. We now generate option with empty label, example: `<select id="places" name="places"><option value="" label=" "></option></select>` for include_blank: true. This is only done, if content is missing on the option, and we providing the value from this option. Fixes #24816
* Revert "Make sure the cache is always populated"Rafael Mendonça França2016-05-201-1/+1
| | | | | | This reverts commit 0ce7eae7418f1b9bb06b351c1f26d50c3674c0d0. Tests were broken https://travis-ci.org/rails/rails/jobs/131850726#L520
* Add more test coverage to layoutsRafael Mendonça França2016-05-201-4/+152
| | | | [Rafael Mendonça França + Nick Sutterer + thedarkone]
* Make sure the cache is always populatedAaron Patterson2016-05-201-1/+1
| | | | This way we don't have to make multiple calls on anonymous controllers
* Merge pull request #25041 from maclover7/jm-actionviewAaron Patterson2016-05-201-9/+3
|\ | | | | [Action View] Don't create middleman `DetailsKey` instance
| * [Action View] Don't create middleman `DetailsKey` instanceJon Moss2016-05-161-9/+3
| | | | | | | | | | All of this is `nodoc`'ed, so we shouldn't have to worry about breaking changes, if there are any -- all internal API :).
* | Support for unified Integer class in Ruby 2.4+Jeremy Daer2016-05-181-1/+1
| | | | | | | | | | | | | | | | Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005 * Forward compat with new unified Integer class in Ruby 2.4+. * Backward compat with separate Fixnum/Bignum in Ruby 2.2 & 2.3. * Drops needless Fixnum distinction in docs, preferring Integer.
* | `md5` --> `MD5`Jon Moss2016-05-171-3/+3
| | | | | | | | | | Sorry, I missed a few places in my last PR. This should be the last of 'em :grimacing:
* | keep layouts + locals from bloating the cacheAaron Patterson2016-05-173-3/+39
| | | | | | | | | | | | Using locals will cause layouts to be cached multiple times in the template cache. This commit removes locals from consideration when looking up the layout.
* | locals can be accessed from templates rendered in the controllerAaron Patterson2016-05-171-0/+16
|/
* Remove extranous spaces from assignment.Kasper Timm Hansen2016-05-161-1/+1
| | | | | Leftover from an earlier commit, chose to fix because I was just down in this file.
* Replace middleware with executor callback.Kasper Timm Hansen2016-05-162-8/+1
| | | | | | | | | | | | | Per request digest caches were added before we had hooks into different units of work that Rails performs. As such the most reliable way to prevent stale cache digests was with a middleware. The middleware prevented staleness in Action Controller requests. However, the executor is superior because it should also prevent staleness when running just Active Job jobs or broadcasting through Action Cable's server.
* Start Rails 5.1 development :tada:Rafael Mendonça França2016-05-102-344/+3
|
* Update rails-dom-testing gem to 2.0Connor Shea2016-05-091-1/+1
| | | | Resolves #24924.
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-30 23:07:36 +0000