| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Add missing spec and documentation for button_tag helper
|
| | |
|
|\ \
| | |
| | | |
Removed not needed includes, As record_tag_helper is moved to a gem we..
|
| |/
| |
| |
| | |
testing is completely here now. RenderErbUtils and AM::Conversion are not used
|
|\ \
| | |
| | | |
Add gotcha to RDoc of collection_check_boxes
|
| | |
| | |
| | |
| | | |
[ci skip]
|
|/ /
| |
| |
| | |
This reverts commit d345ce9630ce4c01bc81a09fb015e7bd935600ad.
|
|\ \
| | |
| | | |
use our own runner for Rails framework components `bin/test`
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This adds a script `bin/test` to most Rails framework components. The
script uses the rails minitest plugin to augment the runner.
See https://github.com/rails/rails/pull/19571 for details about the
plugin.
I did not yet add `bin/test` for activerecord, activejob and railties.
These components rely on specific setup performed in the rake-tasks.
|
|\ \ \
| | | |
| | | | |
add error log that notify 'file not found' when using cache_digest dependency rake
|
| | | |
| | | |
| | | |
| | | | |
cache_digests:dependency and cache_digests:nested_dependency tasks
|
| |/ /
|/| | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`Tags::Base#select_content_tag`.
Previously, passing a falsey value to `include_blank` would be ignored if the
field was required, and a blank line would still be inserted. The following will
now raise instead of quietly failing:
`select("post", "category", %w(a required field), { include_blank: false }, required: 'required')`
|
| | | |
|
|\ \ \ |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit a9d58c77da800bb0052c9bfa432828b02526022c, reversing
changes made to 041c2c879a3c4086ad3aa6d30fed1eede1d53c11.
Reason: The old behavior is how it was working in previous version of
Rails since 4.0.x so it is not safe to backport to a stable branch.
See https://github.com/rails/rails/issues/19626#issuecomment-89862258
and https://github.com/rails/rails/pull/15050#issuecomment-45333449
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Remove unused package tasks
|
| | | | |
| | | | |
| | | | |
| | | | | |
We are using `all:build` now.
|
|/ / / /
| | | |
| | | |
| | | | |
`head` method works similar to `render` method with `:nothing` option
|
|\ \ \ \
| | | | |
| | | | | |
Remove custom `lines` and use `/tools/line_statistics`
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove broken and unused release task
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | | |
- We do release with release.rb
- There is no `rake/gemcutter`
|
|/ / / /
| | | |
| | | |
| | | | |
https://travis-ci.org/rails/rails/jobs/63594316#L1982
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The patched test assumed the file system is case-sensitive, but that is not
necessarily the case. In particular, this test did not pass in the recommended
setup for the dev box, because the /vagrant shared folder is case-insensitive.
After looking at some gems that provide access to file system metadata I have
chosen to go with the check you can see in the patch because, albeit it's a bit
dirty creating a file, it is super easy to understand and clearly portable.
References https://github.com/rails/rails-dev-box/issues/102.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When one rendered a partial template without specifying an object
or a collection (e.g. <%= render partial: 'partial_name' %>), Rails
would make an object called :partial_name available in local_assigns.
I don't think this was the intended behavior, since no local variable
called 'partial_name' gets defined in the view.
|
|\ \ \ \
| | | | |
| | | | | |
remove redundant parenthesis.
|
| | | | | |
|
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I think we are better off leaving `sudo` outside of the documented
way of installing gems (`activerecord`, `actionpack`, …).
We don’t want newbies to think that `sudo` is required or, even worse, than
they actually have to type `[sudo] gem install`.
In most scenarios, `sudo` is not needed to install gems, and people who do
need it, probably already know about it.
What do you think? :grin:
|
| |/ /
|/| | |
|
|\ \ \ |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
In help text for method, dynamic value makes it hard to understand, so replaced with static value matching with example above
|
| |_|/
|/| |
| | |
| | | |
Should be ApplicationController not ApplicationController::Base
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Prompted by:
https://github.com/rails/rails/commit/e38dd7bfa4360e241eadf0cf44abdf86ea33a393#commitcomment-11011496
/cc @kuldeepaggarwal
|
| | |
| | |
| | |
| | | |
supported by I18n.
|
|\ \ \
| | | |
| | | | |
Handle raise flag in translate when both main and default translation is missing.
|
| | | |
| | | |
| | | |
| | | | |
missing. Fixes #19967
|
|\ \ \ \
| | | | |
| | | | | |
Actionview image tag size option override
|
| | | | | |
|
| |/ / /
|/| | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This illustrates the purpose of the block for `link_to_if` and
`link_to_unless` helper methods.
It should help to prevent further mistakes like #19844.
|