diff options
| author | Arthur Nogueira Neves <github@arthurnn.com> | 2015-06-15 22:55:58 +0200 |
|---|---|---|
| committer | Arthur Nogueira Neves <github@arthurnn.com> | 2015-06-15 22:55:58 +0200 |
| commit | e08d8c5b4ab8b2135c724dcf7a4c3bbd47978d0a (patch) | |
| tree | c9d373aceba0d02d3b5956a34275a84e42a4ba0a /actionview | |
| parent | c9f7350f63a95c9bb6f759cfde7b6983391c2953 (diff) | |
| parent | b5ae29de03cc64c8dc0448fd1b40d8ba69944236 (diff) | |
| download | rails-e08d8c5b4ab8b2135c724dcf7a4c3bbd47978d0a.tar.gz rails-e08d8c5b4ab8b2135c724dcf7a4c3bbd47978d0a.tar.bz2 rails-e08d8c5b4ab8b2135c724dcf7a4c3bbd47978d0a.zip | |
Merge pull request #20108 from akshay-vishnoi/button-tag
Add missing spec and documentation for button_tag helper
Diffstat (limited to 'actionview')
| -rw-r--r-- | actionview/lib/action_view/helpers/form_tag_helper.rb | 17 | ||||
| -rw-r--r-- | actionview/test/template/form_tag_helper_test.rb | 7 |
2 files changed, 22 insertions, 2 deletions
diff --git a/actionview/lib/action_view/helpers/form_tag_helper.rb b/actionview/lib/action_view/helpers/form_tag_helper.rb index 1f76f40138..896020bc15 100644 --- a/actionview/lib/action_view/helpers/form_tag_helper.rb +++ b/actionview/lib/action_view/helpers/form_tag_helper.rb @@ -448,8 +448,9 @@ module ActionView # <tt>reset</tt>button or a generic button which can be used in # JavaScript, for example. You can use the button tag as a regular # submit tag but it isn't supported in legacy browsers. However, - # the button tag allows richer labels such as images and emphasis, - # so this helper will also accept a block. + # the button tag does allow for richer labels such as images and emphasis, + # so this helper will also accept a block. By default, it will create + # a button tag with type `submit`, if type is not given. # # ==== Options # * <tt>:data</tt> - This option can be used to add custom data attributes. @@ -472,6 +473,15 @@ module ActionView # button_tag # # => <button name="button" type="submit">Button</button> # + # button_tag 'Reset', type: 'reset' + # # => <button name="button" type="reset">Reset</button> + # + # button_tag 'Button', type: 'button' + # # => <button name="button" type="button">Button</button> + # + # button_tag 'Reset', type: 'reset', disabled: true + # # => <button name="button" type="reset" disabled="disabled">Reset</button> + # # button_tag(type: 'button') do # content_tag(:strong, 'Ask me!') # end @@ -479,6 +489,9 @@ module ActionView # # <strong>Ask me!</strong> # # </button> # + # button_tag "Save", data: { confirm: "Are you sure?" } + # # => <button name="button" type="submit" data-confirm="Are you sure?">Save</button> + # # button_tag "Checkout", data: { disable_with: "Please wait..." } # # => <button data-disable-with="Please wait..." name="button" type="submit">Checkout</button> # diff --git a/actionview/test/template/form_tag_helper_test.rb b/actionview/test/template/form_tag_helper_test.rb index cad1c82309..f602c82c42 100644 --- a/actionview/test/template/form_tag_helper_test.rb +++ b/actionview/test/template/form_tag_helper_test.rb @@ -510,6 +510,13 @@ class FormTagHelperTest < ActionView::TestCase ) end + def test_button_tag_with_data_disable_with_option + assert_dom_equal( + %(<button name="button" type="submit" data-disable-with="Please wait...">Checkout</button>), + button_tag("Checkout", data: { disable_with: "Please wait..." }) + ) + end + def test_image_submit_tag_with_confirmation assert_dom_equal( %(<input alt="Save" type="image" src="/images/save.gif" data-confirm="Are you sure?" />), |