aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/test
Commit message (Collapse)AuthorAgeFilesLines
* This test needs integer core ext for timeRafael Mendonça França2019-08-021-0/+1
|
* Require integer conversion for this testRafael Mendonça França2019-08-021-0/+1
|
* Revert "MethodCallAssertions is a regular player of the team ↵Rafael Mendonça França2019-08-021-0/+3
| | | | | | ActiveSupport::TestCase now" This reverts commit 98d0f7ebd34b858f12a12dcf37ae54fdbb5cab64.
* Revert "You give jruby_skip & rubinius_skip a good name"Rafael Mendonça França2019-08-021-0/+11
| | | | This reverts commit 8d2866bb80fbe81acb04f5b0c44f152f571fb29f.
* You give jruby_skip & rubinius_skip a good nameAkira Matsuda2019-08-021-11/+0
| | | | | | | | This hack prevails everywhere in the codebase by being copy & pasted, and it's actually not a negative thing but a necessary thing for framework implementors, so it should better have a name and be a thing. And with this commit, activesupport/test/abstract_unit.rb now doesn't silently autoload AS::TestCase, so we're ready to establish clearner environment for running AS tests (probably in later commits)
* MethodCallAssertions is a regular player of the team ActiveSupport::TestCase nowAkira Matsuda2019-08-021-3/+0
| | | | It's used everywhere, clean and mature enough
* Fix typo submited → submitted [ci skip]hc02082019-07-311-1/+1
|
* Add AS::TimeZone#match?Akira Matsuda2019-07-291-0/+2
|
* Suppress Ruby warning: :warning: non-nil $, will be deprecatedAkira Matsuda2019-07-291-2/+6
|
* Assert query counts in cache relation testst00122019-07-281-1/+16
| | | | This is to guard the change in #35982
* Change test description with the correct URL namePietro Moro2019-07-261-8/+8
|
* Change the test description to say the URL helper name in test.Abhay Nikam2019-07-271-7/+7
|
* Added a phone_to helper method, on the style of mail_to and sms_to. (#36775)Pietro Moro2019-07-261-0/+64
| | | | | | | | | | | * Added a phone_to helper method, on the style of mail_to and sms_to. It creates an anchor tag with the href set to tel: *here your number* which, when clicked on a mobile phone, or on a desktop with a supported application, lets the phone app kick in, and it prepopulates it with the phone number specified. [Pietro Moro + Rafael Mendonça França]
* Merge pull request #36764 from ↵Rafael França2019-07-261-0/+18
|\ | | | | | | | | willianveiga/feature/inputs-inside-disabled-fieldset-are-not-submited-on-remote-true-forms Inputs inside disabled fieldset are not submited on remote: true forms
| * Add test for submitted fields within disabled fieldsetsWillian Gustavo Veiga2019-07-261-0/+18
| |
* | Merge pull request #36576 from mtsmfm/mtsmfm/fix-fixture-resolverRafael Mendonça França2019-07-251-0/+22
|\ \ | |/ |/| | | Support :any variants for ActionView::FixtureResolver
| * Support :any variants for FixtureResolverFumiaki MATSUSHIMA2019-06-301-0/+22
| |
* | Merge pull request #36511 from aantix/sms_link_helperGuillermo Iguaran2019-07-191-0/+62
|\ \ | | | | | | Helper method to create an sms link
| * | Helper method to create an sms link - when clicked it opens the ↵Jim Jones2019-06-181-0/+62
| | | | | | | | | | | | phone/desktop's messaging client with the phone number and optional body value prepopulated.
* | | Empty array instead of nil for source_extractGuilherme Mansur2019-07-141-0/+16
| |/ |/| | | | | | | | | | | | | | | | | The source_extract method will return nil when it can't find the file name in the backtrace, methods that consume this method expect an array and the nil ends up causing type errors down the road like it happened here: #36341. This patch refactors the source_extract method so that it returns an empty array instead of nil when it can't find the source code. Co-authored-by: Kasper Timm Hansen <kaspth@gmail.com>
* | Merge pull request #36482 from Shopify/fix-translation-helper-default-hashRafael França2019-06-171-0/+5
|\ \ | | | | | | Fix TranslationHelper#translate handling of Hash defaults
| * | Fix TranslationHelper#translate handling of Hash defaultsJean Boussier2019-06-141-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is sometimes expected of the `translate` methods to return a Hash, for instance it's the case of the `number.format` key. As such users might need to specify a Hash default, e.g. `translate(:'some.format', default: { separator: '.', delimiter: ',' })`. This works as expected with the `I18n.translate` methods, however `TranslationHelper#translate` apply `Array()` on the default value. As a result the default value end up as `[:separator, '.', :delimiter, ',']`.
* | | Fix rubocop violationsRyuta Kamizono2019-06-141-1/+0
|/ /
* | Merge pull request #36437 from sudara/fix_programmatic_clicks_with_data_remoteGannon McGibbon2019-06-131-0/+14
|\ \ | | | | | | Fix programmatic clicks with data-remote
| * | Ensure non-mouse/programmatic clicks work with data-remoteSudara2019-06-131-0/+14
| | |
* | | Merge pull request #36388 from joelhawksley/actionview-componentAaron Patterson2019-06-132-0/+63
|\ \ \ | | | | | | | | Introduce ActionView::Component
| * | | `RenderingHelper` supports rendering objects that `respond_to?` `:render_in`Joel Hawksley2019-06-122-0/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: Natasha Umer <natashau@github.com> Co-authored-by: Aaron Patterson <tenderlove@github.com> Co-authored-by: Shawn Allen <shawnbot@github.com> Co-authored-by: Emily Plummer <emplums@github.com> Co-authored-by: Diana Mounter <broccolini@github.com> Co-authored-by: John Hawthorn <jhawthorn@github.com> Co-authored-by: Nathan Herald <myobie@github.com> Co-authored-by: Zaid Zawaideh <zawaideh@github.com> Co-authored-by: Zach Ahn <engineering@zachahn.com>
* | | | Enable `Layout/EmptyLinesAroundAccessModifier` copRyuta Kamizono2019-06-137-6/+2
| |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | We sometimes say "✂️ newline after `private`" in a code review (e.g. https://github.com/rails/rails/pull/18546#discussion_r23188776, https://github.com/rails/rails/pull/34832#discussion_r244847195). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059). That cop and enforced style will reduce the our code review cost.
* | | Merge pull request #36422 from jhawthorn/parallelize_actionviewJohn Hawthorn2019-06-063-39/+13
|\ \ \ | |_|/ |/| | Run actionview tests in parallel
| * | Run actionview tests in parallelJohn Hawthorn2019-06-052-0/+12
| | |
| * | Remove actionview tests which modify fixturesJohn Hawthorn2019-06-051-39/+1
| |/ | | | | | | | | | | | | | | | | | | We shouldn't modify fixtures (or any files which are checked-in). It prevents us from parallelizing, and probably has other issues. We could fix these tests by copying the file to a tmpdir and modifying it there, but I don't think they are testing anything useful anymore. Re-initializing a resolver isn't representative of "uncached" rendering (either in dev-mode or using lookup_context.disable_cache).
* / Bump rubocop to 0.71Abhay Nikam2019-06-061-1/+1
|/
* Change `ActionDispatch::Response#content_type` returning Content-Type header ↵yuuji.yaginuma2019-06-011-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | as it is Since #35709, `Response#conten_type` returns only MIME type correctly. It is a documented behavior that this method only returns MIME type, so this change seems appropriate. https://github.com/rails/rails/blob/39de7fac0507070e3c5f8b33fbad6fced84d97ed/actionpack/lib/action_dispatch/http/response.rb#L245-L249 But unfortunately, some users expect this method to return all Content-Type that does not contain charset. This seems to be breaking changes. We can change this behavior with the deprecate cycle. But, in that case, a method needs that include Content-Type with additional parameters. And that method name is probably the `content_type` seems to properly. So I changed the new behavior to more appropriate `media_type` method. And `Response#content_type` changed (as the method name) to return Content-Type header as it is. Fixes #35709. [Rafael Mendonça França & Yuuji Yaginuma ]
* Fix select_tag so that is doesn't change options when include_blank is setYounes SERRAJ2019-05-221-0/+7
|
* Remove useless `GC.start` in `test/template/render_test.rb`Ryuta Kamizono2019-05-061-14/+0
| | | | | The `GC.start` was added at b29e893, but the finalizer has been removed at 7d0ce78 in #35036.
* Clear Resolvers' cache after running RenderTestCases' test casesst00122019-05-061-4/+9
| | | | | | | | | The templates rendered in RenderTestCases tests will be cached by the resolvers unexpectedly. And this will break other tests when executed in certain order. (See https://github.com/rails/rails/issues/36154 for more detail) So to fix this issue, we just need to clear the caches on all resolvers.
* Merge pull request #32313 from lulalala/model_error_as_objectRafael França2019-04-242-7/+17
|\ | | | | Model error as object
| * Raise deprecation for calling `[:f] = 'b'` or `[:f] << 'b'`lulalala2019-03-312-7/+17
| | | | | | | | Revert some tests to ensure back compatibility
* | Bump RuboCop to 0.67.2Koichi ITO2019-04-161-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Performance cops will be extracted from RuboCop to RuboCop Performance when next RuboCop 0.68 will be released. https://github.com/rubocop-hq/rubocop/issues/5977 RuboCop 0.67 is its transition period. Since rails/rails repository uses Performance cops, This PR added rubocop-performance gem to Gemfile. And this PR fixes some offenses using the following auto-correct. ```console % bundle exec rubocop -a Offenses: activerecord/test/cases/connection_adapters/connection_handlers_multi_db_test.rb:212:26: C: [Corrected] Layout/SpaceAroundOperators: Operator = > should be surrounded by a single space. "primary" => { adapter: "sqlite3", database: "db/primary.sqlite3" } ^^ activerecord/test/cases/connection_adapters/connection_handlers_multi_db_test.rb:239:26: C: [Corrected] Layout/SpaceAroundOperators: Operator => should be surrounded by a single space. "primary" => { adapter: "sqlite3", database: "db/primary.sqlite3" } ^^ actionview/test/template/resolver_shared_tests.rb:1:1: C: [Corrected] Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. module ResolverSharedTests ^ actionview/test/template/resolver_shared_tests.rb:10:33: C: [Corrected] Layout/SpaceAroundEqualsInParameterDefault: Surrounding space missing in default value assignment. def with_file(filename, source="File at #{filename}") ^ actionview/test/template/resolver_shared_tests.rb:106:5: C: [Corrected] Rails/RefuteMethods: Prefer assert_not_same over refute_same. refute_same a, b ^^^^^^^^^^^ 2760 files inspected, 5 offenses detected, 5 offenses corrected ```
* | Add additional test for sharing templatesJohn Hawthorn2019-04-121-1/+18
| |
* | Support disabling cache for DigestorJohn Hawthorn2019-04-121-0/+14
| | | | | | | | | | | | This adds a bit of complexity, but is necessary for now to avoid holding extra copies of templates which are resolved from ActionView::Digestor after disabling cache on the lookup context.
* | De-dup Templates, introduce UnboundTemplateJohn Hawthorn2019-04-121-0/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously it's possible to have multiple copies of the "same" Template. For example, if index.html.erb is found both the :en and :fr locale, it will return a different Template object for each. The same can happen with formats, variants, and handlers. This commit de-duplicates templates, there will now only be one template per file/virtual_path/locals tuple. We need to consider virtual_path because both `render "index"`, and `render "index.html"` can both find the same file but will have different virtual_paths. IMO this is rare and should be deprecated/removed, but it exists now so we need to consider it in order to cache correctly. This commit introduces a new UnboundTemplate class, which represents a template with unknown locals. Template objects can be built from it by using `#with_locals`. Currently, this is just a convenience around caching templates, but I hope it's a helpful concept that could have more utility in the future.
* | Add tests against resolverJohn Hawthorn2019-04-113-0/+109
| | | | | | | | | | | | | | | | | | | | | | We didn't previously have many tests directly against the OptimizedFileSystemResolver or FileSystemResolver, though usually failures would be exposed through other tests. It's easier to test some specifics of the behaviour with unit tests. This also lets us test FileSystemResolver (non-optimized) which I don't think previously had much testing (other than from classses inheriting it).
* | Deprecate Template#refreshJohn Hawthorn2019-04-041-17/+3
| |
* | Don't discard source after renderingJohn Hawthorn2019-04-041-2/+2
| | | | | | | | | | | | | | | | | | | | Previously, we would discard the template source after rendering, if we had a virtual path, in hopes that the virtual path would let us find our same template again going through the Resolver. Previously we discarded the source as an optimization, to avoid keeping it around in memory. By instead just reading the file every time source is called, as FileTemplate does, this is unnecessary.
* | Fix deprecation warning about variants and formatsPrathamesh Sonpatki2019-04-041-2/+2
| | | | | | | | | | | | - After https://github.com/rails/rails/pull/35408 and https://github.com/rails/rails/pull/35406, the `formats` and `variants` methods are deprecated in favor of `format` and `variant`.
* | Output junit format test reportFumiaki MATSUSHIMA2019-04-041-0/+2
| |
* | Merge pull request #35145 from st0012/fix-35114Rafael França2019-04-032-0/+23
|\ \ | | | | | | Fix partial caching ignore repeated items issue
| * | Fix partial caching ignore repeated items issuest00122019-04-042-0/+23
| | | | | | | | | | | | | | | | | | This is because we only use hash to maintain the result. So when the key are the same, the result would be skipped. The solution is to maintain an array for tracking every item's position to restructure the result.
* | | Fix checking for template variants when using the ActionView::FixtureResolverEdward Rudd2019-04-031-0/+10
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-13 16:20:34 +0000