aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/test
Commit message (Collapse)AuthorAgeFilesLines
* Fixed #select form builder helper to support block with html outputBogdan Gusiev2014-08-051-0/+13
|
* Properly assert for the expected messagesCarlos Antonio da Silva2014-07-301-4/+8
| | | | | | The message passed to Minitest's assert_raise is used as output in case the assertion fails, but we can test against the exact message by using the actual exception object that is returned from the assert_raise call.
* Fix that render layout should also be picked up by the template dependency ↵David Heinemeier Hansson2014-07-251-0/+15
| | | | tracker, but only half-ways. You can add that layout option on the same render call, and both templates should be added to the dependency tree. But thats going to require a more serious rework of the tracker. Please do help fix this part of it too. For now, render layout needs to be on its own line.
* Merge branch 'rm-remove-mocha'Rafael Mendonça França2014-07-191-0/+2
|\ | | | | | | | | Conflicts: actionpack/test/abstract_unit.rb
| * Stop requiring mocha automaticallyRafael Mendonça França2014-07-191-0/+2
| | | | | | | | | | | | | | | | | | | | | | We are planning to remove mocha from our test suite because of performance problems. To make this possible we should stop require mocha on ActionSupport::TestCase. This should not affect applications since users still need to add mocha to Gemfile and this already load mocha. Added FIXME notes to place that still need mocha removal
* | adding missing test for text area value before type castEugene Gilburg2014-07-191-0/+7
| |
* | adding missing test coverageEugene Gilburg2014-07-181-0/+12
| |
* | subclass Rails::EngineAaron Patterson2014-07-161-1/+2
| |
* | Build only one PartialIteration object for loopRafael Mendonça França2014-07-161-5/+8
| |
* | No need to have a file to PartialIteration classRafael Mendonça França2014-07-161-3/+2
| | | | | | | | This class is only used on the PartialRenderer.
* | Added PartialIteration class used when rendering collectionsJoel Junström2014-07-165-1/+52
| | | | | | | | | | | | | | | | | | | | | | | | The iteration object is available as the local variable "template_name_iteration" when rendering partials with collections. It gives access to the +size+ of the collection beeing iterated over, the current +index+ and two convinicence methods +first?+ and +last?+ "template_name_counter" variable is kept but is deprecated. [Joel Junström + Lucas Uyezu]
* | Return an absolute instead of relative path from an asset url in the case of ↵Jolyon Pawlyn2014-07-151-0/+8
| | | | | | | | the `asset_host` proc returning nil
* | Assert the nature of the original exceptionMatthew Draper2014-07-121-0/+1
| | | | | | | | | | | | Just so it's clearer what's going on in the following assertion. /cc #11993 @robin850
* | Merge pull request #11993 from razielgn/actionview-use-name-to-inspect-errorGuillermo Iguaran2014-07-111-1/+1
|\ \ | | | | | | Use NameError#name to assert raised error.
| * | Use NameError#name to assert raised error.Federico Ravasio2013-11-241-1/+1
| | | | | | | | | | | | | | | This makes the test compatible with other Ruby implementations, which may implement error messages differently.
* | | Fixed borken tests in AV caused by 013c74dGodfrey Chan2014-07-101-2/+2
| |/ |/|
* | Change back occurrences of SQLite(3) to sqlite3 when referring to theZachary Scott2014-07-061-1/+1
| | | | | | | | adapter, fixed from #16057 [ci skip]
* | [ci skip] /sqlite/i --> SQLiteAkshay Vishnoi2014-07-061-1/+1
| |
* | Fix escape_once double-escaping hex-encoded entitiesJohn F. Douthat2014-07-022-0/+2
| | | | | | | | (This is a manual merge of #9102)
* | Add String support for min/max attributes on DatetimeFieldTodd Bealmear2014-06-301-0/+64
| |
* | Deal with regex match groups in excerptGareth Rees2014-06-241-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Original implementation has bugs if the regex contains a match group. Example: excerpt('This is a beautiful? morning', /\b(beau\w*)\b/i, :radius => 5) Expected: "...is a beautiful? mor..." Actual: "...is a beautifulbeaut..." The original phrase was being converted to a regex and returning the text either side of the phrase as expected: 'This is a beautiful? morning'.split(/beautiful/i, 2) # => ["This is a ", "? morning"] When we have a match with groups the match is returned in the array. Quoting the ruby docs: "If pattern is a Regexp, str is divided where the pattern matches. [...] If pattern contains groups, the respective matches will be returned in the array as well." 'This is a beautiful? morning'.split(/\b(beau\w*)\b/iu, 2) # => ["This is a ", "beautiful", "? morning"] If we assume we want to split on the first match – this fix makes that assumption – we can pass the already assigned `phrase` variable as the place to split (because we already know that a match exists from line 168). Originally spotted by Louise Crow (@crowbot) at https://github.com/mysociety/alaveteli/pull/1557
* | Merge pull request #15450 from aditya-kapoor/remove-nbsp-debugRafael Mendonça França2014-06-191-1/+1
|\ \ | | | | | | remove unnecessary gsub for space in ActionView::Helpers#debug
| * | remove unnecessary substitution for space in ActionView::Helpers#debugAditya Kapoor2014-06-141-1/+1
| | |
* | | 'TextHelper#highlight' now accepts a block to highlight the matched words.Lucas Mazza2014-06-191-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | The helper will yield each matched word, and you can use this instead of the ':highlighter' option for more complex replacing logic: highlight('My email is me@work.com', EMAIL_REGEXP) { |m| mail_to(m) } # => 'My email is <a href="mailto:me@work.com">me@work.com</a>'
* | | highlight() now accepts regular expressions as well.Jan Szumiec2014-06-191-1/+9
| | |
* | | excerpt() now accepts regular expression instances as phrases.Jan Szumiec2014-06-191-0/+2
| | |
* | | Merge pull request #15709 from zuhao/refactor_actionview_compiled_templates_testYves Senn2014-06-181-8/+1
|\ \ \ | | | | | | | | Move cleanup into teardown, delete obsolete code.
| * | | Move cleanup into teardown, delete obsolete code.Zuhao Wan2014-06-141-8/+1
| | | |
* | | | reload I18n as we are defining `:ts` localeKuldeep Aggarwal2014-06-151-0/+2
| | | | | | | | | | | | | | | | fix build- see https://travis-ci.org/rails/rails/jobs/27578159#L2913.
* | | | Merge pull request #15715 from ↵Yves Senn2014-06-143-4/+11
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | zuhao/refactor_actionview_cleanup_I18n_translations Clean up I18n stored translations after test.
| * | | Clean up I18n stored translations after test.Zuhao Wan2014-06-143-4/+12
| | | |
* | | | Merge pull request #15712 from zuhao/refactor_actionview_javascript_helper_testYves Senn2014-06-141-3/+3
|\ \ \ \ | |/ / / |/| | | Avoid hard-coded value in test setup and teardown.
| * | | Avoid hard-coded value in test setup and teardown.Zuhao Wan2014-06-141-3/+3
| |/ /
* / / Make sure restoration always happen.Zuhao Wan2014-06-141-0/+1
|/ /
* | Merge pull request #15654 from pdg137/masterMatthew Draper2014-06-132-1/+32
|\ \ | | | | | | | | | In tag helper, honor html_safe on arrays; also make safe_join more similar to Array.join
| * | In tag helper, honor html_safe on array parameters; also make safe_join more ↵Paul Grayson2014-06-122-1/+32
| | | | | | | | | | | | similar to Array.join by first calling flatten.
* | | Merge pull request #15590 from ↵Yves Senn2014-06-123-14/+47
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | zuhao/refactor_actionview_register_template_handler Add unregister_template_handler to prevent leaks. Conflicts: actionview/CHANGELOG.md
| * | Add unregister_template_handler to prevent leaks.Zuhao Wan2014-06-124-14/+47
|/ /
* | Removed CaptureHelper#flush_output_buffer as it is only used in tests.Ryan Davis2014-06-042-82/+0
| | | | | | | | reviewed: @tenderlove
* | Fix AS::NumberHelper results with rationalsJuanjo Bazán2014-05-311-0/+1
| | | | | | | | | | | | | | | | | | | | :precision was incorrectly being applied to Rationals before: ActiveSupport::NumberHelper.number_to_rounded Rational(10, 3), precision: 2 => "3.3" after: ActiveSupport::NumberHelper.number_to_rounded Rational(10, 3), precision: 2 => "3.33"
* | Merge pull request #15061 from tgxworld/remove_unnecessary_includeMatthew Draper2014-05-291-1/+0
|\ \ | | | | | | Remove unnecessary include for integration tests.
| * | Remove unnecessary include for integration tests.Guo Xiang Tan2014-05-111-1/+0
| | |
* | | Merge pull request #15021 from hubertlepicki/allow_custom_host_in_asset_urlRafael Mendonça França2014-05-161-0/+15
|\ \ \ | | | | | | | | | | | | Allow custom asset host to be passed in asset_url
| * | | Allow custom asset host to be passed in asset_urlHubert Łępicki2014-05-081-0/+15
| | | |
* | | | Following documentation guidelineRafael Mendonça França2014-05-141-4/+3
| | | |
* | | | Merge remote-tracking branch 'apotonick/simplify-prefixes'Rafael Mendonça França2014-05-141-0/+49
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | This is the rebased version of #15026 Closes #15026
| * | | | deprecate AbC:Base::parent_prefixes.Nick Sutterer2014-05-131-0/+49
| | |/ / | |/| | | | | | | | | | | | | | | | | | rename ::_local_prefixes to ::local_prefixes to state the public attribute. document the latter. make ::local_prefixes private, test overriding it and remove documentation for overriding ::_parent_prefixes.
* | | | minor: point to the right test suite locationazul2014-05-141-1/+1
| | | |
* | | | Fix assertion order and :scissors: extra spacesCarlos Antonio da Silva2014-05-131-2/+2
| | | |
* | | | Merge pull request #15068 from josepjaume/patch-1Aaron Patterson2014-05-131-0/+6
|\ \ \ \ | | | | | | | | | | Dup options hash to prevent modifications