Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | add tests for path based url_for calls | Aaron Patterson | 2014-05-08 | 1 | -2/+19 |
| | |||||
* | don't manipulate the testclass, just add helpers to the instance | Aaron Patterson | 2014-05-08 | 1 | -10/+11 |
| | |||||
* | add a test for classes with options | Aaron Patterson | 2014-05-08 | 1 | -0/+7 |
| | |||||
* | add tests for the polymorphic_path method | Aaron Patterson | 2014-05-08 | 1 | -0/+3 |
| | |||||
* | add more tests around the polymorphic url api | Aaron Patterson | 2014-05-08 | 1 | -0/+12 |
| | |||||
* | test for inconsistency between String and Symbol url_for handling | Aaron Patterson | 2014-05-07 | 1 | -0/+4 |
| | |||||
* | add tests for symbols passed to polymorphic_url | Aaron Patterson | 2014-05-07 | 1 | -0/+12 |
| | |||||
* | apparently passing a string to polymorphic_url is something we support | Aaron Patterson | 2014-05-06 | 1 | -0/+12 |
| | | | | o_O | ||||
* | make sure url_for works similar to polymorphic_url | Aaron Patterson | 2014-05-06 | 1 | -38/+43 |
| | |||||
* | add a test for the parameters sent to the url helper for new records | Aaron Patterson | 2014-05-06 | 1 | -0/+15 |
| | |||||
* | Merge pull request #14997 from jpcody/nested_value_i18n | Rafael Mendonça França | 2014-05-06 | 1 | -0/+9 |
|\ | | | | | Include label value in i18n attribute lookup | ||||
| * | Include label value in i18n attribute lookup | Joshua Cody | 2014-05-06 | 1 | -0/+9 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, only the object and method name from the label tag were used when looking up the translation for a label. If a value is given for the label, this ought to be additionally used. The following: # form.html.erb <%= form_for @post do |f| %> <%= f.label :type, value: "long" %> <% end %> # en.yml en: activerecord: attributes: post/long: "Long-form Post" Used to simply return "long", but now it will return "Long-form Post". | ||||
* | | Ensure that .process return the method return | Arthur Neves | 2014-05-06 | 2 | -9/+13 |
|/ | |||||
* | passing a nil in the polymorphic array is not supported. remove nils before ↵ | Aaron Patterson | 2014-05-02 | 1 | -4/+4 |
| | | | | you call the method | ||||
* | passing a nil should always raise an ArgumentError | Aaron Patterson | 2014-05-02 | 1 | -0/+25 |
| | |||||
* | always pass options to the _url method | Aaron Patterson | 2014-05-01 | 1 | -3/+13 |
| | |||||
* | always use File.join | phoet | 2014-05-01 | 1 | -0/+8 |
| | |||||
* | Merge pull request #13335 from glorieux/favicon_link_tag_mimetype | Rafael Mendonça França | 2014-04-22 | 1 | -3/+3 |
|\ | | | | | Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to image/x-icon. | ||||
| * | Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to ↵ | glorieux | 2014-04-21 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | | image/x-icon. Although the official IANA-registered MIME type for ICO files is image/vnd.microsoft.icon, registered in 2003, it was submitted to IANA by a third party and is not recognized by Microsoft products. The MIME type image/x-icon should be used since is the one recognized by the major browsers on the market. | ||||
* | | Add test for using ActionView::Helpers::FormHelper.label with block and html | Zachary Scott | 2014-04-22 | 1 | -0/+7 |
|/ | |||||
* | Remove wrapper div for inputs in button_to | Rafael Mendonça França | 2014-04-17 | 1 | -20/+20 |
| | | | | Related with cbb917455f306cf5818644b162f22be09f77d4b2 | ||||
* | Merge pull request #14738 from tilsammans/pull/11407 | Rafael Mendonça França | 2014-04-17 | 3 | -12/+17 |
|\ | | | | | | | | | | | | | Remove wrapping div with inline styles for hidden form fields. Conflicts: actionview/CHANGELOG.md | ||||
| * | Remove wrapping div with inline styles for hidden form fields. | Joost Baaij | 2014-04-14 | 3 | -12/+17 |
| | | | | | | | | | | | | We are dropping HTML 4.01 and XHTML strict compliance since input tags directly inside a form are valid HTML5, and the absense of inline styles help in validating for Content Security Policy. | ||||
* | | Use the index on hidden field | Rafael Mendonça França | 2014-04-14 | 1 | -1/+1 |
| | | |||||
* | | `collection_check_boxes` respects `:index` option for the hidden filed name. | Vasiliy Ermolovich | 2014-04-14 | 1 | -0/+7 |
|/ | | | | closes #14147 | ||||
* | CollectionHelpers now accepts a readonly option | Mauro George | 2014-04-12 | 1 | -0/+44 |
| | |||||
* | Add test for selected and disabled custom attributes in options_for_select | Laura Paredes | 2014-03-31 | 1 | -1/+21 |
| | |||||
* | Fix date_select option overwriting html classes | Izumi Wong-Horiuchi | 2014-03-24 | 1 | -0/+16 |
| | | | | | with_css_classes: true option overwrites other html classes. Concatenate day month and year classes rather than overwriting. | ||||
* | Digestor should just rely on the finder to know about the format and the ↵ | David Heinemeier Hansson | 2014-03-21 | 1 | -10/+7 |
| | | | | variant -- trying to pass it back in makes a mess of things (oh, and doesnt work) | ||||
* | fix `number_to_percentage` with `Float::NAN`, `Float::INFINITY`. | Yves Senn | 2014-03-17 | 1 | -0/+3 |
| | | | | | | | Closes #14405. This is a follow-up to 9e997e9039435617b6a844158f5437e97f6bc107 to restore the documented behavior. | ||||
* | Merge pull request #12662 from nashby/include-hidden-collection | Rafael Mendonça França | 2014-03-15 | 1 | -0/+7 |
|\ | | | | | | | | | | | | | | | add include_hidden option to collection_check_boxes helper Conflicts: actionview/CHANGELOG.md actionview/test/template/form_collections_helper_test.rb | ||||
| * | add include_hidden option to collection_check_boxes helper | Vasiliy Ermolovich | 2013-10-27 | 1 | -0/+7 |
| | | |||||
* | | Clarify AV::Digestor.digest method signature docs and deprecation warning | Jeremy Kemper | 2014-03-15 | 1 | -2/+2 |
| | | |||||
* | | Fix the resolver cache and stop mutating the lookup_context | Rafael Mendonça França | 2014-03-14 | 2 | -21/+0 |
| | | | | | | | | | | Before we had a bug in the resolver cache so the disable_cache were not working when passing options to find | ||||
* | | Introduce #with_formats_and_variants to prevent problems with mutating ↵ | Łukasz Strzałkowski | 2014-03-14 | 2 | -0/+21 |
| | | | | | | | | finder object | ||||
* | | Add mocked disable_cache for FixtureFinder | Łukasz Strzałkowski | 2014-03-14 | 1 | -0/+4 |
| | | |||||
* | | Set format in finder | Łukasz Strzałkowski | 2014-03-14 | 1 | -3/+8 |
| | | |||||
* | | Ensure LookupContext in Digestor selects correct variant | Piotr Chmolowski | 2014-03-09 | 4 | -3/+21 |
| | | | | | | | | | | | | | | | | | | | | Related to: #14242 #14243 14293 Variants passed to LookupContext#find() seem to be ignored, so I've used the setter instead: `finder.variants = [ variant ]`. I've also added some more test cases for variants. Hopefully this time passing tests will mean it actually works. | ||||
* | | Variants in ActionView::Digestor | Piotr Chmolowski | 2014-03-04 | 2 | -8/+42 |
| | | | | | | | | | | | | | | | | | | | | | | Take variants into account when calculating template digests in ActionView::Digest. Digestor#digest now takes a hash as an argument to support variants and allow more flexibility in the future. Old-style arguments have been deprecated. Fixes #14242 | ||||
* | | fixes default attributes for button_tag | Sergey Prikhodko | 2014-03-03 | 1 | -0/+5 |
| | | |||||
* | | refactor, with_locale is not needed because I18n is mocked. | Yves Senn | 2014-02-24 | 1 | -7/+5 |
| | | | | | | | | | | This is a follow up to #14170. While backporting I recognized that this call is not needed at all. | ||||
* | | Fix ActionView label translation for more than 10 nested elements | Vladimir Krylov | 2014-02-24 | 1 | -0/+14 |
| | | |||||
* | | refactor, extract `with_locale` helper. | Yves Senn | 2014-02-24 | 1 | -87/+79 |
| | | |||||
* | | Use the reference for the mime type to get the format | Rafael Mendonça França | 2014-02-18 | 2 | -0/+34 |
| | | | | | | | | | | | | | | | | Before we were calling to_sym in the mime type, even when it is unknown what can cause denial of service since symbols are not removed by the garbage collector. Fixes: CVE-2014-0082 | ||||
* | | Merge branch '4-1-0-beta2' | Rafael Mendonça França | 2014-02-18 | 1 | -0/+39 |
|\ \ | | | | | | | | | | | | | | | | Conflicts: actionview/CHANGELOG.md activerecord/CHANGELOG.md | ||||
| * | | Escape format, negative_format and units options of number helpers | Rafael Mendonça França | 2014-02-18 | 1 | -0/+39 |
| | | | | | | | | | | | | | | | | | | | | | Previously the values of these options were trusted leading to potential XSS vulnerabilities. Fixes: CVE-2014-0081 | ||||
* | | | Fix a fragile test on `action_view/render` | Prem Sichanugrist | 2014-02-18 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | This test were assuming that the list of render options will always be the same. Fixing that so this doesn't break when we add/remove render option in the future. | ||||
* | | | implements new option :month_format_string for date select helpers [Closes ↵ | Xavier Noria | 2014-02-15 | 1 | -0/+10 |
| | | | | | | | | | | | | #13618] | ||||
* | | | Added tests to render helper that expect `render partial: @foo` to | Iain Beeston | 2014-02-12 | 2 | -0/+11 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | automatically call @foo.to_partial_path Calling `render @foo` allows local variables but not options to be passed to the partial renderer. The correct way to render an object AND pass options to the partial renderer is to pass the object in the `:partial` parameter. However, there were previously no tests for this behaviour (in `render_helper_test.rb` at least). | ||||
* | | | Adding an documentation example and a test to button_to with path | Attila Domokos | 2014-02-02 | 1 | -0/+7 |
| | | | | | | | | | I did not see in the docs that `button_to` supports not only URLs but paths as well. I documented this functionality with a unit tests and added an example to the docs as well. |