aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/test
Commit message (Collapse)AuthorAgeFilesLines
...
* Use public_send for form tagsagius2014-10-311-0/+27
|
* Honor public/private in ActionView::Helpers::Tags::Base#valueTobias Pfeiffer2014-10-311-0/+6
| | | | | * use public_send instead of send to avoid calling private methods in form helpers
* Use new hash syntaxRafael Mendonça França2014-10-251-1/+1
|
* :scissors:Rafael Mendonça França2014-10-251-1/+1
|
* Merge pull request #17064 from frenkel/fix_select_tag_include_blankRafael Mendonça França2014-10-251-0/+6
|\ | | | | Use include_blank value as option label
| * Use include_blank value as option labelFrank Groeneveld2014-10-171-0/+6
| | | | | | | | Update select_tag to reflect documentation and behave the same as form builder select. If the value of include_blank is not boolean true, use that value as the option label.
* | Fix how file_ and password_field_tag edit optionsclaudiob2014-10-151-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit fixes the behavior of `file_field_tag` and `password_field_tag` when invoked with a hash of options. These two helpers are different from all the other ones in that they modify the options hash passed as a parameter, whereas all the other helpers duplicate it before updating it. The result is that *bad things* can happen if the user re-uses the same hash. For instance, users who write the following code to display a file field followed by a text field (both with the same class): ```rhtml <% options = {class: 'important'} %> <%= file_field_tag 'Upload', options %> <%= text_field_tag 'Name', options %> ``` would instead see **two file fields!** ```html <input class="important" id="Upload" name="Upload" type="file"> <input class="important" id="Name" name="Name" type="file" value="value"> ``` This PR replaces `update` with `merge` in the code of the two helpers, fixing the issue above. The included test verifies the change, since it passes after this PR, but fails before with the following error: ``` Expected: <input type="text" name="title" id="title" value="Hello!" class="important" /> Actual: <input type="password" name="title" id="title" value="Hello!" class="important" /> ```
* | remove un-needed sortschneems2014-10-072-9/+8
| | | | | | | | | | | | HTML doesn't care what order the elements are rendered in, so why should we? Updates tests to use proper `assert_dom_equal` instead of `assert_equal` /cc @jeremy
* | Change `gsub` to `tr` where possibleAlexander Balashov2014-10-061-1/+1
| |
* | Added processing of `nil` to `highlight` helper methodigor042014-09-301-0/+4
| |
* | Don’t require already required modulesclaudiofullscreen2014-09-261-2/+0
|/ | | | | | | | | abstract_unit.rb requires `action_controller` which [already includes the following lines of code](https://github.com/rails/rails/blob/64fcdce1d3a6a8768ab17f3be144270456814f82/actionpack/lib/action_controller.rb#L2L3): ```ruby require 'abstract_controller' require 'action_dispatch' ```
* Merge pull request #17058 from eval/issue-17057Rafael Mendonça França2014-09-251-0/+9
|\ | | | | | | Remove internal options from query string of paths
| * Remove internal options from query string of pathsGert Goet2014-09-251-0/+9
| | | | | | | | Fixes #17057
* | Revert "Revert "Merge pull request #16888 from jejacks0n/render_template""Godfrey Chan2014-09-261-18/+5
|/ | | | This reverts commit 585e75696b31395aee895e5366e331c07c3f5ee1.
* Revert "Merge pull request #16888 from jejacks0n/render_template"Godfrey Chan2014-09-231-5/+18
| | | | | | | This reverts commit 07635a74b5ee08dcba3f6617def6230d8f114fe5, reversing changes made to 1b5f61a025b6ce1ee52b7148e3ed2a9acbde28b9. Reason: it's not ready :bomb:, see https://github.com/rails/rails/pull/16888#issuecomment-56400816
* Merge pull request #16888 from jejacks0n/render_templateGodfrey Chan2014-09-231-18/+5
|\ | | | | | | Changes default render behavior from file to template.
| * Changes default render behavior from file to template.jejacks0n2014-09-111-18/+5
| |
* | handle <%== nil %> casesAaron Patterson2014-09-142-0/+5
| | | | | | | | | | This is much less common than string literal appends, so add a special case method for it. Maybe fixes bug reported by @jeremy on 97ef636191933f1d4abc92fc10871e6d1195285c
* | Revert "Merge pull request #15312 from JuanitoFatas/action_view/asset_path"Matthew Draper2014-09-141-0/+11
|/ | | | | | | This reverts commit 21ec7fefea5a1b823cb88733b019b3d52240801d. Per #16911, there's actually a good reason for a "blank" value to have a useful `to_s` here. So let's also add some tests to prove that.
* Merge pull request #16839 from chancancode/default_test_orderRafael Mendonça França2014-09-101-1/+1
|\ | | | | | | Default to sorting user's test cases for now
| * Default to sorting user's test cases for nowGodfrey Chan2014-09-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | Goals: 1. Default to :random for newly generated applications 2. Default to :sorted for existing applications with a warning 3. Only show the warning once 4. Only show the warning if the app actually uses AS::TestCase Fixes #16769
* | Do not memoize document_root_element in view testsRafael Mendonça França2014-09-081-0/+11
|/ | | | | | | Memoizing will not make possible to assert the output of the view if it is changed after the first assert_select call Related with plataformatec/simple_form#1130 and rails/rails-dom-testing#15
* fix the undefined method content_tag #15245Rajarshi Das2014-09-061-1/+0
| | | | not required include ActionView::Helpers::TagHelper in test as well
* Add support for ARIA attributes in tagsPaoMar2014-09-031-0/+7
|
* Ship with rails-html-sanitizer instead.Kasper Timm Hansen2014-09-031-1/+1
|
* Leave all our tests as order_dependent! for nowMatthew Draper2014-09-021-0/+5
| | | | | | | | | We're seeing too many failures to believe otherwise. This reverts commits bc116a55ca3dd9f63a1f1ca7ade3623885adcc57, cbde413df3839e06dd14e3c220e9800af91e83ab, bf0a67931dd8e58f6f878b9510ae818ae1f29a3a, and 2440933fe2c27b27bcafcd9019717800db2641aa.
* Remove warningRafael Mendonça França2014-09-011-2/+2
|
* Allow polymorphic routes with nil when a route can still be drawnSammy Larbi2014-08-311-2/+34
| | | | | | | | | | | | | | | | Suppose you have two resources routed in the following manner: ```ruby resources :blogs do resources :posts end resources :posts ``` When using polymorphic resource routing like `url_for([@blog, @post])`, and `@blog` is `nil` Rails should still try to match the route to the top-level posts resource. Fixes #16754
* Merge pull request #16488 from agrobbin/form-label-builderJeremy Kemper2014-08-251-0/+9
|\ | | | | Provide a builder for form labels to customize wrapping around I18n content
| * provide a builder for form labels to customize wrapping around I18n contentAlex Robbin2014-08-201-0/+9
| |
* | just use the placeholder tag value if it is passed as a StringAlex Robbin2014-08-221-4/+19
| |
* | add I18n support for `:placeholder` HTML option is passed to form fieldsAlex Robbin2014-08-221-0/+168
| |
* | Revert "Add I18n support for `:placeholder` HTML option is passed to form ↵Jeremy Kemper2014-08-211-168/+0
|/ | | | fields"
* Removed warningRafael Mendonça França2014-08-181-1/+1
|
* Fix assertion to map the behaviour of the old sanitizerRafael Mendonça França2014-08-181-1/+1
|
* Merge pull request #15889 from carnesmedia/model-nameRafael Mendonça França2014-08-171-2/+2
|\ | | | | | | Use #model_name on instances instead of classes
| * Use #model_name on instances instead of classesAmiel Martin2014-06-241-2/+2
| | | | | | | | | | | | This allows rails code to be more confdent when asking for a model name, instead of having to ask for the class. Rails core discussion here: https://groups.google.com/forum/#!topic/rubyonrails-core/ThSaXw9y1F8
* | Merge branch 'master' into loofahRafael Mendonça França2014-08-173-8/+169
|\ \ | | | | | | | | | | | | Conflicts: actionpack/CHANGELOG.md
| * | Remove usafe of respond_to in ActionView testsJosé Valim2014-08-171-3/+1
| | |
| * | Merge pull request #16438 from agrobbin/input-placeholder-i18nJeremy Kemper2014-08-141-0/+168
| |\ \ | | | | | | | | Add I18n support for `:placeholder` HTML option is passed to form fields
| | * | add I18n support for `:placeholder` HTML option is passed to form fieldsAlex Robbin2014-08-121-0/+168
| | | |
| * | | AM, AP, AV, and AMo tests are already order_independent!Akira Matsuda2014-08-131-5/+0
| |/ /
* | | Merge branch 'master' into loofahRafael Mendonça França2014-08-1212-9/+130
|\| | | | | | | | | | | | | | | | | | | | Conflicts: actionpack/CHANGELOG.md actionpack/test/controller/integration_test.rb actionview/CHANGELOG.md
| * | Nobody sucks so nobody should call this awful method nameRafael Mendonça França2014-08-121-1/+1
| | |
| * | users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent!Akira Matsuda2014-08-121-0/+5
| | | | | | | | | | | | | | | Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes everyone's tests order dependent, which should never be done by the framework.
| * | Fixed #select form builder helper to support block with html outputBogdan Gusiev2014-08-051-0/+13
| | |
| * | Properly assert for the expected messagesCarlos Antonio da Silva2014-07-301-4/+8
| | | | | | | | | | | | | | | | | | The message passed to Minitest's assert_raise is used as output in case the assertion fails, but we can test against the exact message by using the actual exception object that is returned from the assert_raise call.
| * | Fix that render layout should also be picked up by the template dependency ↵David Heinemeier Hansson2014-07-251-0/+15
| | | | | | | | | | | | tracker, but only half-ways. You can add that layout option on the same render call, and both templates should be added to the dependency tree. But thats going to require a more serious rework of the tracker. Please do help fix this part of it too. For now, render layout needs to be on its own line.
| * | Merge branch 'rm-remove-mocha'Rafael Mendonça França2014-07-191-0/+2
| |\ \ | | | | | | | | | | | | | | | | Conflicts: actionpack/test/abstract_unit.rb
| | * | Stop requiring mocha automaticallyRafael Mendonça França2014-07-191-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are planning to remove mocha from our test suite because of performance problems. To make this possible we should stop require mocha on ActionSupport::TestCase. This should not affect applications since users still need to add mocha to Gemfile and this already load mocha. Added FIXME notes to place that still need mocha removal
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-29 10:30:04 +0000