aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/test
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #30213 from ckundo/ccundiff-alt-text-defaultRafael Mendonça França2017-08-231-16/+16
|\ | | | | | | Do not generate default alt text for images
| * Do not generate default alt text in image tagsCameron Cundiff2017-08-171-16/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Auto-generating content from the filename of an image is not suitable alternative text; alt text that isn't fully considered can be distracting and fatiguing for screen readers users (blind, low vision, dyslexic people). - Setting a filename fallback short circuits screen reader default behavior and configuration for blank descriptions. - Setting poor defaults also creates false negatives for accessibility linting and testing software, that makes it harder to improve application accessibility. *** - After this change, if authors leave images without alt text, screen readers will fallback to default behavior for missing alt text. - Also with this change, Automated linting and testing tools will correctly generate warnings. [Fixes #30096]
* | Use ssl in guide and comment [ci skip]Yoshiyuki Hirano2017-08-191-1/+1
|/
* Fix RuboCop offensesKoichi ITO2017-08-167-69/+69
| | | | And enable `context_dependent` of Style/BracesAroundHashParameters cop.
* Extend image_tag to accept ActiveStorage Attachments and Variants (#30084)Anton Khamets2017-08-071-3/+0
| | | | | | | | | | | | | | | | | | * Extend image_tag to accept ActiveStorage's Attachments and Variants * Flip resolve_image_source around * Add tests for the new use-cases of image_tag * Remove the higher-level test * Update image_tag documentation * Add error states into the test suite * Re-raise polymorhic_url's NoMethodError as ArgumentError * delegate_missing_to will raise DelegationError instead of NoMethodError
* Merge pull request #30020 from rails/active-storage-importDavid Heinemeier Hansson2017-08-042-0/+68
|\ | | | | Add Active Storage to Rails
| * Refactor convert_direct_upload_option_to_urlRafael Mendonça França2017-08-031-0/+31
| | | | | | | | Also make sure file_field doesn't mutate the original options passed in.
| * Make sure Action View doesn't break with Active StorageRafael Mendonça França2017-08-031-0/+37
| | | | | | | | | | When Active Storage is not loaded and direct_upload is used on file_field_tag we should not raise an exception.
* | Allow non-English values for collection_radio_buttons/check_boxescolorfulfool2017-08-021-0/+14
|/
* Merge pull request #30001 from y-yagi/fix_test_directoryKasper Timm Hansen2017-07-302-2/+2
|\ | | | | Fix test directory to correct path
| * Fix test directory to correct pathyuuji.yaginuma2017-07-302-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Together, fix to the following lint violation. ``` rails/actionview/test/ujs/public/test/data-confirm.js 303:11 error Strings must use singlequote quotes rails/actionview/test/ujs/public/test/data-remote.js 414:32 error Extra semicolon semi ✖ 2 problems (2 errors, 0 warnings) ```
* | Fix testing helpers that use Action View's capturing helpers (e.g. content_for)George Claghorn2017-07-251-0/+8
|/
* Merge pull request #29897 from kirs/frozen-actionviewRafael França2017-07-2474-0/+147
|\ | | | | Use frozen string literal in actionview/
| * Use frozen string literal in actionview/Kir Shatrov2017-07-2474-0/+147
| |
* | Merge pull request #29792 from lugray/delegate_respond_toRafael França2017-07-241-0/+11
|\ \ | |/ |/| Delegate respond_to? in ActionView::Helpers::ControllerHelper
| * Delegate respond_to? in ActionView::Helpers::ControllerHelperLisa Ugray2017-07-191-0/+11
| | | | | | | | | | | | Since methods defined in the controller helper are mostly delegated to the controller, delegate respond_to? as well, so that for example `respond_to?(:params)` behaves as expected.
* | Add jQuery to test vendor filesMarc Rendl Ignacio2017-07-202-1/+9832
|/ | | | | ... so that we can run most, if not all, of rails-ujs tests without necessarily requiring an internet connection.
* Enable `Layout/FirstParameterIndentation` copRyuta Kamizono2017-07-172-24/+24
| | | | | | | We have some indentation cops. But now there is a little inconsistent params indentations. Enable `Layout/FirstParameterIndentation` cop to prevent newly inconsistent indentation added and auto-correct to existing violations.
* [Action View] `rubocop -a --only Layout/EmptyLineAfterMagicComment`Koichi ITO2017-07-111-0/+1
|
* Expectation firstAkira Matsuda2017-07-022-8/+8
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-0286-86/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Merge pull request #29540 from kirs/rubocop-frozen-stringMatthew Draper2017-07-0286-0/+86
|\ | | | | | | Enforce frozen string in Rubocop
| * Enforce frozen string in RubocopKir Shatrov2017-07-0186-0/+86
| |
* | Merge pull request #29506 from pat/frozen-string-literalsMatthew Draper2017-07-0213-212/+212
|\ \ | | | | | | | | | Make ActiveSupport frozen-string-literal friendly.
| * | Make ActionView frozen string literal friendly.Pat Allan2017-06-2013-212/+212
| | | | | | | | | | | | Plus a couple of related ActionPack patches.
* | | Merge pull request #29349 from robertomiranda/responsive-imagesMatthew Draper2017-07-021-1/+4
|\ \ \ | | | | | | | | | | | | Add srcset option to image_tag helper
| * | | Add `srcset` option to `image_tag` helperRoberto Miranda2017-06-291-1/+4
| | |/ | |/|
* / | Fallback Parameters#to_s to Hash#to_sKir Shatrov2017-06-301-0/+6
|/ / | | | | Fixes https://github.com/rails/rails/issues/29617
* / Fix current_page? helper issue with engine root pathsavroff2017-06-191-3/+13
|/
* Generate field ids in `collection_check_boxes` and `collection_radio_buttons`yuuji.yaginuma2017-06-111-18/+18
| | | | | This makes sure that the labels are linked up with the fields. Fixes #29014
* Merge pull request https://github.com/rails/rails/pull/28637 from ↵Kasper Timm Hansen2017-06-082-23/+31
| | | | st0012/fix-partial-cache-logging
* Use a hash to record every partial's cache hit status instead of sharing a ↵Stan Lo2017-06-084-0/+45
| | | | boolean.
* Don't support namespace in form_with.Kasper Timm Hansen2017-06-071-18/+0
| | | | | form_with requires people to pass an id manually, so users can just prefix their namespace right there.
* Use mattr_accessor default: option throughout the projectGenadi Samokovarov2017-06-031-2/+1
|
* Merge pull request #29187 from robin850/remove-mathnRafael França2017-05-301-3/+11
|\ | | | | Remove requirement on mathn
| * Remove requirement on mathnRobin Dupret2017-05-301-3/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | The test using mathn was first introduced in f1d9179 to check that the `distance_of_time_in_words` properly doesn't use the `Fixnum#/` method by explicitly requiring this library as it redefines this method. Given that `mathn` has been gemified in Ruby 2.5 and is deprecated since version 2.2, we can certainly safely assume that people will most-likely not require this library in their application. However, to make sure that we don't regress, let's add a test similar to the one before f1d9179.
* | Merge pull request #29176 from bogdanvlviv/define-path-with__dir__Matthew Draper2017-05-2611-29/+29
|\ \ | | | | | | Define path with __dir__
| * | Define path with __dir__bogdanvlviv2017-05-2311-29/+29
| |/ | | | | | | | | | | ".. with __dir__ we can restore order in the Universe." - by @fxn Related to 5b8738c2df003a96f0e490c43559747618d10f5f
* | Merge pull request #29119 from spohlenz/fix-select-with-enumerableMatthew Draper2017-05-241-0/+17
|\ \ | |/ |/| Fix select tag helper used with Enumerable choices
| * Fix select tag helper used with Enumerable choicesSam Pohlenz2017-05-171-0/+17
| | | | | | | | | | | | Allows a custom object implementing Enumerable to be used as the choices parameter for a select tag, which previously wasn't possible due to the call to `empty?` on the choices (which isn't implemented on Enumerable).
* | Add :json type to auto_discovery_link_tagMike Gunderloy2017-05-201-0/+1
| | | | | | | | | | This allows auto_discovery_link_tag to support the JSON Feed standard. See https://jsonfeed.org/version/1 for more information.
* | ERB::Util.url_encode no longer escapes ~ since ruby 2.5Akira Matsuda2017-05-191-2/+2
| | | | | | | | see: https://bugs.ruby-lang.org/issues/6696
* | Use recyclable cache keys (#29092)David Heinemeier Hansson2017-05-183-5/+5
|/
* Should escape meta characters in regexpRyuta Kamizono2017-05-074-10/+10
|
* Merge pull request #28753 from st0012/add-render-with-variants-testKasper Timm Hansen2017-05-013-0/+10
|\ | | | | Add tests for rendering with variants
| * Add tests for render template/partial with variants option.Stan Lo2017-04-143-0/+10
| |
* | Merge pull request #20701 from iamvery/date-helper-argument-errorAndrew White2017-04-271-0/+10
|\ \ | | | | | | Ensure input to distance_of_time_in_words is not nil
| * | Ensure input to distance_of_time_in_words is not nilJay Hayes2017-04-271-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Internally all input is converted to time so that it can be treated uniformly. Remove now-unneeded condition * Now that all input is treated is converted to time, we no longer need to type check it. Rename variables to clarify their purpose Extract private method to normalize distance_of_time args to time Update actionview changelog
* | | Merge pull request #28844 from ↵Kasper Timm Hansen2017-04-271-0/+2
|\ \ \ | | | | | | | | | | | | | | | | kyuden/remove_unnecessary_attributes_of_select_in_form_with Remove unnecessary `skip_default_ids` and `allow_method_names_outside_object` attributes of select tag in `form_with`
| * | | Remove unnecessary `skip_default_ids` and ↵kyuden2017-04-241-0/+2
| |/ / | | | | | | | | | `allow_method_names_outside_object` attributes of select tag in `form_with`
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-07 06:36:29 +0000