aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/test
Commit message (Collapse)AuthorAgeFilesLines
* Remove RecordTagHelper, add extraction noticesTodd Bealmear2015-02-161-87/+3
| | | | | | | Per DHH in #18337, ActionView::Helpers::RecordTagHelper has been extracted to an external gem (source currently lives at todd/record_tag_helper). Removal notices have also been added for anyone upgrading that use the extracted methods.
* Allow to pass a string value to size option in `image_tag` and `video_tag`Mehdi Lahmam2015-02-161-0/+2
| | | | This makes the behavior more consistent with `width` or `height` options
* use kwargs instead of xhr method. refs #18771.yuuji.yaginuma2015-02-071-2/+2
|
* Fixed undefined method `i18n_key' for nil:NilClass for labels in non AR form_forMiklos Fazekas2015-02-061-0/+12
| | | | | Refactoring at #18647 broke using non active record objects in form_for. This patch restores the original behaviour where we only compute i18 key when object.respond_to?(:to_model)
* Add tests to make sure label and placeholder respect to_modelRafael Mendonça França2015-02-052-0/+58
|
* Partial template name does no more have to be a valid Ruby identifierAkira Matsuda2015-02-063-13/+9
| | | | because the partial renderer would not create an lvar per each template since c67005f221f102fe2caca231027d9b11cf630484
* Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵Vipul A M2015-02-035-5/+0
| | | | onwards.
* Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846robertomiranda2015-01-312-2/+2
| | | | ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769
* Fixed test for deprecation warning in actionview, renaming from ↵Vipul A M2015-01-313-29/+29
| | | | https://github.com/rails/rails/commit/baf14ae513337cb185acf865e93dfc48f3aabf6a
* Merge pull request #18546 from brainopia/action_view_renderRafael Mendonça França2015-01-221-0/+9
|\ | | | | A shortcut to setup controller environment
| * Support `:assigns` option when rendering with controllers/mailers.brainopia2015-01-221-0/+9
| |
* | Eliminate a ruby warning in a test in Action ViewYuki Nishijima2015-01-171-1/+5
| | | | | | | | | | | | | | This eliminates the warning below: actionview/test/template/form_helper_test.rb:913: warning: method redefined; discarding old id_came_from_user? actionview/test/template/form_helper_test.rb:104: warning: previous definition of id_came_from_user? was here
* | Use option url: false to allow entries without a link tagDaniel Gomez de Souza2015-01-161-0/+24
|/
* Only use the `_before_type_cast` in the form when from user inputSean Griffin2015-01-141-0/+17
| | | | | | While we don't want to change the form input when validations fail, blindly using `_before_type_cast` will cause the input to display the wrong data for any type which does additional work on database values.
* Add tests with an explanation of why we're using `_before_type_cast`Sean Griffin2015-01-141-3/+4
| | | | | | | If you entered incorrect input into a form (particularly with a numericality validation), we should not replace what you typed in with `0`, since clicking submit a second time would essentially be the same as erroneously accepting the junk input as 0.
* Revert "Don't use the `_before_type_cast` version of attributes in the form"Sean Griffin2015-01-141-1/+1
| | | | This reverts commit 787e22bb491bd8c36db1e9734261c4ce02c5c5fd.
* Don't use the `_before_type_cast` version of attributes in the formSean Griffin2015-01-141-1/+1
| | | | | | | | | | | We should never be ignoring valuable information that the types may need to give us. The reason that it originally used `_before_type_cast` is unclear, but appears to date back long enough that the reasons may not be relevant today. There is only one test that asserts that it uses the before type cast version, but it gives no context as to why and uses a mock which does not simulate the real world. Fixes #18523.
* No need of requiring `rbconfig`, it is by-default loadedKuldeep Aggarwal2015-01-101-1/+0
|
* Avoid changing the global state on the testsRafael Mendonça França2015-01-051-1/+6
|
* Merge pull request #17676 from ↵Rafael Mendonça França2015-01-051-0/+19
|\ | | | | | | | | | | tigrish/fix_custom_i18n_exception_handler_regression Fix I18n regression introduced by #13832
| * Fix I18n regression introduced by #13832Christopher Dell2014-11-191-0/+19
| | | | | | | | Previously, when the `:raise` options was set to `false`, it would get overwritten to `true`, preventing custom exception handlers to be used.
* | Merge pull request #18328 from brainopia/remove_tz_proxyRafael Mendonça França2015-01-041-1/+1
|\ \ | | | | | | Use directly TZInfo::Timezone without proxy
| * | Use directly TZInfo::Timezone without proxybrainopia2015-01-041-1/+1
| | | | | | | | | | | | | | | Since real timezone is loaded anyway in `#utc_offset` which is called during `#create`
* | | Remove wrong TODO commentRafael Mendonça França2015-01-041-1/+1
|/ /
* | Remove deprecated `AbstractController::Base::parent_prefixes`Rafael Mendonça França2015-01-041-16/+0
| |
* | Unsafe default translations should not be marked html_safeJustin Coyne2015-01-021-0/+6
| | | | | | | | | | | | Previously default translation keys that didn't end in `_html`, but came after a missing key that ended in `_html` were being returned as html_safe. Now they are not. Fixes #18257
* | Merge pull request #17974 from killthekitten/fix-render-blockRafael Mendonça França2015-01-022-0/+8
|\ \ | | | | | | | | | | | | | | | | | | Make possible to use blocks with short version of render partial Conflicts: actionview/CHANGELOG.md
| * | Make possible to use blocks with short version of render partialNikolay Shebanov2014-12-192-0/+8
| | |
* | | Merge pull request #17973 from maurogeorge/file_field_hidden_fieldRafael Mendonça França2015-01-021-5/+20
|\ \ \ | | | | | | | | | | | | Generate a hidden_tag when using a file_field
| * | | Add a hidden_field on the file_fieldMauro George2015-01-021-5/+20
|/ / / | | | | | | | | | | | | This will avoid a error be raised when the only input on the form is the `file_field`.
* | | Fix form_for to work with objects that implement to_modelTravis Grathwell2014-12-291-5/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, if you tried to use form_for with a presenter object that implements to_model, it would crash in action_dispatch/routing/polymorphic_routes.rb when asking the presenter whether it is .persisted? Now, we always ask .persisted? of the to_model object instead. This seems to been an issue since 1606fc9d840da869a60213bc889da6fcf1fdc431 Signed-off-by: Eugenia Dellapenna <eugenia.dellapenna@gmail.com>
* | | fix error message of option as with invalid charters in partial renderingAngelo capilleri2014-12-291-3/+17
| | | | | | | | | | | | | | | before this PR IDENTIFIER_ERROR_MESSAGE could lead to misunderstand the convention of partial name. Added OPTION_AS_ERROR_MESSAGE for unvalid charter in as option.
* | | Merge pull request #18107 from mkdynamic/add-reply-to-mail-toSean Griffin2014-12-241-2/+2
|\ \ \ | | | | | | | | Add support for Reply-To field in mail_to helper
| * | | Add support for Reply-To field in mail_to helperMark Dodwell2014-12-201-2/+2
| |/ /
* | | Better tests for AV::RecordIdentifierclaudiob2014-12-232-0/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit intends to clarify the scope of ActionView::RecordIdentifier methods `dom_id` and `dom_class`. Most of the current documentation comes from da257eb8 (7 years ago) when the decoupling of ActionView, ActiveRecord and ActiveModel was not a concern. Since then, steps have been taken to reach such decoupling. Therefore I think it's important to show that ActionView::RecordIdentifier **does not strictly depend on the ActiveRecord API**: any class `Post` implementing `post.to_key` and `post.model_name.param_key` will work. This commit adds a test to prove that ActionView::RecordIdentifier methods can also be used on objects that do not subclass ActiveRecord::Base.
* | | Remove unused Sheep fixture from AVclaudiob2014-12-222-14/+0
|/ / | | | | | | | | | | | | | | The `Sheep` fixture was added in eb23754e when moving template tests from actionpack to actionview, but it's not actually used in ActionView tests. The `Sheep` fixture is only used to test `uncountable` in ActiveModel tests, and is already defined in activemodel/test/models/sheep.rb
* | Test to ensure content_tag works when fixing #17661Jon Atack2014-12-161-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After c2fe093, which was reverted yesterday, there will likely be future PRs to address #17661. The test `actionview/test/template/capture_helper_test.rb #test_capture_returns_nil_if_the_returned_value_is_not_a_string` should have errored with c2fe093, but it was rewritten in the PR to not raise. My guess is that it may have seemed irrelevant to the content_tag tests or already covered by them. This test provides additional protection by being in the content_tag test suite to explicitly raise a red flag in future cases. It foregoes some redundancy for safety — at least until #17661 is closed.
* | Regression test for #18024Santiago Pastorino2014-12-151-0/+5
| |
* | Revert "Re-enable capture'ing non-String values"Santiago Pastorino2014-12-152-7/+2
| | | | | | | | This reverts commit c2fe0938d7201d4ce0bb2f25e72bf5f70df128af.
* | Re-enable capture'ing non-String valuesCarsten Zimmermann2014-12-142-2/+7
| | | | | | | | | | | | | | This has been discussed in #17661 and partially reverts the changes made in 9de83050d3a4b260d4aeb5d09ec4eb64f913ba64 and 986cac73e3c56b3dfa22fd1464f6913e38d32cc3 The test case added to content_for acts as a regression / acceptance test.
* | Fix options overwritten by superJose Añasco2014-12-091-0/+5
| |
* | Merge pull request #17878 from claudiob/remove-unused-modgreet-fixtureYves Senn2014-12-021-1/+0
|\ \ | | | | | | Remove unused AV/test/fixtures/scope
| * | Remove unused AV/test/fixtures/scopeclaudiob2014-12-011-1/+0
| | | | | | | | | | | | | | | The file `modgreet.erb` was added 8 years ago in 21187c0 and is not used anymore by any test.
* | | Remove unused AV/test/fixtures/happy_pathclaudiob2014-12-011-1/+0
|/ / | | | | | | | | | | | | | | | | | | The `test/fixtures/happy_path/render_action/hello_world.erb` file was introduced in 8ab37c7 for the `TestRenderAction` test. That test was subsequently removed in 34f058e, so the fixture is not used anymore. If Travis CI is happy, then you can be sure the fixture can be removed.
* | Merge pull request #17871 from claudiob/remove-unused-blog-public-fixturesSantiago Pastorino2014-12-024-4/+0
|\ \ | | | | | | Remove unused AV/test/fixtures/blog_public
| * | Remove unused AV/test/fixtures/blog_publicclaudiob2014-12-014-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | The fixtures were added to support StaticTests in 401cd97 but those tests were then removed in d5ad92ce. If Travis CI is happy with this PR, then you can be sure that those fixtures are not needed anymore.
* | | Remove one AV fixture (duplicate of an AP fixture)claudiob2014-12-011-3/+0
|/ / | | | | | | | | | | | | | | | | | | | | | | Both ActionPack and ActionView include `test/fixtures/functional_caching/fragment_cached_without_digest.html.erb`. The [ActionPack file](https://github.com/rails/rails/blob/master/actionpack/test/fixtures/functional_caching/fragment_cached_without_digest.html.erb) is used by the tests. The [ActionView file](https://github.com/rails/rails/blob/master/actionview/test/fixtures/functional_caching/fragment_cached_without_digest.html.erb) is not: it was introduced in eb23754e when some tests and fixtures were moved from AP to AV, but no tests in AV uses the fixture. Long story short: if Travis CI is happy with removing the fixture, you can be sure that is not needed anymore!
* | Pass symbol as an argument instead of a blockErik Michaels-Ober2014-11-294-4/+4
| |
* | Move test that depends on ActiveRecordclaudiob2014-11-211-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit moves a test from `test/template` to `test/activerecord` since the test depends on ActiveRecord. This matches the documentation from [RUNNING_UNIT_TESTS](https://github.com/rails/rails/blob/f28d1ddd507174ac233b773cc4f35c3c05ad32e7/actionview/RUNNING_UNIT_TESTS.rdoc): > Test cases in the test/activerecord/ directory depend on having activerecord and sqlite3 installed. > If Active Record is not in actionview/../activerecord directory, or the sqlite3 rubygem is not installed, these tests are skipped. > Other tests are runnable from a fresh copy of actionview without any configuration. --- More details about this commit. All the tests starting with `require 'active_record_unit'` are already inside `test/activerecord`, except for the one test this commit moves. If you don't have `active_record` on your machine, the following command currently fails on master: ```bash ```
* | Fix select_tag generating tag when set to false.Guo Xiang Tan2014-11-211-0/+6
| | | | | | | | Fixes https://github.com/rails/rails/issues/17701.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 13:17:55 +0000