aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/test
Commit message (Collapse)AuthorAgeFilesLines
* use new constructor. (Oops! :bomb:)Aaron Patterson2015-07-081-1/+1
|
* Support explicit defintion of resouce name for collection caching.Dov Murik2015-07-071-3/+5
| | | | | | | | | | | | | | If a template includes `# Template Collection: ...` anywhere in its source, that name will be used as the cache name for the partial that is rendered for the collection. This allows users to enable collection caching even if the template doesn't start with `<% cache ... do %>`. Moreover, the `# Template Collection: ...` notation is recognized in all template types (and template types other than ERB can define a resource_cache_call_pattern method to allow the `cache ... do` pattern to be recognized too).
* Merge pull request #20669 from akolomiychuk/image-pathYves Senn2015-06-291-0/+5
|\ | | | | | | Passing nil to image_tag
| * Add nil check in asset_pathAnton Kolomiychuk2015-06-291-0/+5
| |
* | Fix cache issue when different partials use the same collectionRoque Pinel2015-06-281-4/+13
| | | | | | | | | | | | | | | | | | Adds the `virtual_path` option to `cache_fragment_name` so it can be provided when needed. That allows `cache_collection_render` to get the appropriate cache key with the digest generated based on the template and prevent collision with other templates that cache the same collection.
* | Improve detection of partial templates eligible for collection caching.Dov Murik2015-06-221-0/+30
|/ | | | | | | | | | | | | | The regular expression which was used to detect partial templates that begin with a `<% cache ... do %>` call missed some cases. This commits attempts to improve the detection for some cases such as multi-line comments at the beginning of the template. The different templates are listed in two new unit test methods. Note that specially crafted Ruby code can still evade such `cache`-call detection: for example, a user might have its own method which itself calls the Rails `cache` helper. In such a case, the template's code doesn't start with a literal `cache` string and therefore will not be eligible for collection caching.
* Merge pull request #20108 from akshay-vishnoi/button-tagArthur Nogueira Neves2015-06-151-0/+7
|\ | | | | Add missing spec and documentation for button_tag helper
| * Add missing spec and documentation for button_tag helperAkshay Vishnoi2015-05-241-0/+7
| |
* | Merge pull request #20107 from ankit8898/av_refac_record_tag_helperArthur Nogueira Neves2015-06-151-2/+1
|\ \ | | | | | | Removed not needed includes, As record_tag_helper is moved to a gem we..
| * | Removed not needed includes, As record_tag_helper is moved to a gem we are notAnkit Gupta2015-05-101-2/+1
| |/ | | | | | | testing is completely here now. RenderErbUtils and AM::Conversion are not used
* | Revert "revises a test to account for case-insensitive file systems"Matthew Draper2015-06-141-18/+2
| | | | | | | | This reverts commit d345ce9630ce4c01bc81a09fb015e7bd935600ad.
* | Merge pull request #20058 from farukaydin/cache-digests-dependency-rakeRafael Mendonça França2015-06-111-0/+20
|\ \ | | | | | | add error log that notify 'file not found' when using cache_digest dependency rake
| * | add error log that notify 'file not found' when using ↵Faruk AYDIN2015-05-071-0/+20
| |/ | | | | | | cache_digests:dependency and cache_digests:nested_dependency tasks
* | Raise an ArgumentError when `include_blank` is false for a required field inGrey Baker2015-06-081-0/+7
| | | | | | | | | | | | | | | | | | | | `Tags::Base#select_content_tag`. Previously, passing a falsey value to `include_blank` would be ignored if the field was required, and a blank line would still be inserted. The following will now raise instead of quietly failing: `select("post", "category", %w(a required field), { include_blank: false }, required: 'required')`
* | Revert "Merge pull request #19685 from vngrs/actionview_parent_layout_bug"Rafael Mendonça França2015-06-021-14/+0
| | | | | | | | | | | | | | | | | | | | | | This reverts commit a9d58c77da800bb0052c9bfa432828b02526022c, reversing changes made to 041c2c879a3c4086ad3aa6d30fed1eede1d53c11. Reason: The old behavior is how it was working in previous version of Rails since 4.0.x so it is not safe to backport to a stable branch. See https://github.com/rails/rails/issues/19626#issuecomment-89862258 and https://github.com/rails/rails/pull/15050#issuecomment-45333449
* | Remove `assigns` and `assert_template`.Guo Xiang Tan2015-05-306-135/+38
| |
* | Deprecate `:nothing` option for render methodMehmet Emin İNAÇ2015-05-281-1/+1
| | | | | | | | `head` method works similar to `render` method with `:nothing` option
* | Remove deprecation warning.Guo Xiang Tan2015-05-221-1/+1
| | | | | | | | https://travis-ci.org/rails/rails/jobs/63594316#L1982
* | revises a test to account for case-insensitive file systemsXavier Noria2015-05-211-3/+19
| | | | | | | | | | | | | | | | | | | | | | | | The patched test assumed the file system is case-sensitive, but that is not necessarily the case. In particular, this test did not pass in the recommended setup for the dev box, because the /vagrant shared folder is case-insensitive. After looking at some gems that provide access to file system metadata I have chosen to go with the check you can see in the patch because, albeit it's a bit dirty creating a file, it is super easy to understand and clearly portable. References https://github.com/rails/rails-dev-box/issues/102.
* | Do not put partial name to local_assigns when rendering without an objectHenrik Nygren2015-05-142-0/+9
| | | | | | | | | | | | | | | | When one rendered a partial template without specifying an object or a collection (e.g. <%= render partial: 'partial_name' %>), Rails would make an object called :partial_name available in local_assigns. I don't think this was the intended behavior, since no local variable called 'partial_name' gets defined in the view.
* | Merge pull request #20149 from karanarora/Typo-fixRafael Mendonça França2015-05-131-11/+11
|\ \ | |/ |/| remove redundant parenthesis.
| * remove redundant parenthesis. karanarora2015-05-141-11/+11
| |
* | use the right assertions.Yves Senn2015-05-051-2/+2
| | | | | | | | | | | | | | Prompted by: https://github.com/rails/rails/commit/e38dd7bfa4360e241eadf0cf44abdf86ea33a393#commitcomment-11011496 /cc @kuldeepaggarwal
* | Remove :rescue_format option for translate helper since it's no longer ↵Bernard Potocki2015-05-041-14/+2
| | | | | | | | supported by I18n.
* | Merge pull request #19998 from imanel/fix-missing-translationMatthew Draper2015-05-051-0/+13
|\ \ | | | | | | Handle raise flag in translate when both main and default translation is missing.
| * | Handle raise flag in translate when both main and default translation is ↵Bernard Potocki2015-05-041-0/+13
| | | | | | | | | | | | missing. Fixes #19967
* | | Merge pull request #18783 from mikestone14/actionview-image-tag-overrideRafael Mendonça França2015-05-031-0/+8
|\ \ \ | |/ / |/| | Actionview image tag size option override
| * | image_tag raises an error if size is passed with height and/or widthMike Stone2015-04-241-0/+8
| | |
* | | add test-case for `link_to_if` behavior with a block.Yves Senn2015-05-011-0/+10
| | | | | | | | | | | | | | | | | | | | | This illustrates the purpose of the block for `link_to_if` and `link_to_unless` helper methods. It should help to prevent further mistakes like #19844.
* | | Revert "Merge pull request #19844 from ↵Yves Senn2015-05-011-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | stevenspiel/link_to_if_block_helper_addition" This reverts commit d459b001b43d25053e7982e96eb8383538a6e358, reversing changes made to 4d4950fae9e2a6970b5f1793aadc56a0b44e28a3. :sweat: The block is not supposed to be passed to `link_to`. It's used for a customized behavior of the `condtion = false` case. The docs illustrate that like so: ``` <%= link_to_if(@current_user.nil?, "Login", { controller: "sessions", action: "new" }) do link_to(@current_user.login, { controller: "accounts", action: "show", id: @current_user }) end %> ```
* | | Merge pull request #19844 from stevenspiel/link_to_if_block_helper_additionYves Senn2015-05-011-0/+5
|\ \ \ | |_|/ |/| | | | | Update url_helper.rb
* | | :put_litter_in_its_place: Unused methodsAkira Matsuda2015-04-252-12/+0
| | |
* | | :put_litter_in_its_place: Unused methodAkira Matsuda2015-04-251-6/+0
| |/ |/| | | | | This method is not in use since 479c7cacd5db58ab7200bc1de58c829a1a643278
* | Silence warning from requiring mathnPrem Sichanugrist2015-04-221-1/+1
|/ | | | | | | | | Running Action View test case currently printing out this warning: lib/mathn.rb is deprecated This should silence the warning since we really want to require this file in this test.
* Override default form builder for a controllerKevin McPhillips2015-04-132-0/+45
|
* Merge pull request #19685 from vngrs/actionview_parent_layout_bugRafael Mendonça França2015-04-081-0/+14
|\ | | | | fix for actionview parent layout bug
| * fix for actionview parent layout bugMehmet Emin İNAÇ2015-04-081-0/+14
| | | | | | | | | | | | | | This commit fixes issue #19626 Don't need to check layout conditions if there is no condition test for parent layout bug fix
* | Accept lambda as child_index option in #fields_for methodKarol Galanciak2015-04-051-0/+17
|/
* Allow an array to be a default translation value.Adam Prescott2015-04-041-0/+5
| | | | | | | | | | | 4.2.1 introduced a change to the way `translate`/`t` works with an option of `default: [[]]`. In 4.2.0, this would give a default value of `[]`, but in 4.2.1, it leads to a missing translation. `default: [[]]` is again allowed for cases where a default of `[]` is needed. This addresses GitHub issue 19640.
* Merge pull request #19421 from jcoyne/translate_defaults_with_nilRafael Mendonça França2015-03-201-0/+5
| | | | Strip nils out of default translations. Fixes #19419
* Revert "Merge pull request #19404 from dmathieu/remove_rack_env"Jeremy Kemper2015-03-201-1/+1
| | | | | | | Preserving RACK_ENV behavior. This reverts commit 7bdc7635b885e473f6a577264fd8efad1c02174f, reversing changes made to 45786be516e13d55a1fca9a4abaddd5781209103.
* [Fix Select tag Tests] Test correct use of multiple option for selectAkshay Vishnoi2015-03-201-4/+4
|
* don't fallback to RACK_ENV when RAILS_ENV is not presentDamien Mathieu2015-03-191-1/+1
|
* Closes rails/rails#18864: Renaming transactional fixtures to transactional testsBrandon Weiss2015-03-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | I’m renaming all instances of `use_transcational_fixtures` to `use_transactional_tests` and “transactional fixtures” to “transactional tests”. I’m deprecating `use_transactional_fixtures=`. So anyone who is explicitly setting this will get a warning telling them to use `use_transactional_tests=` instead. I’m maintaining backwards compatibility—both forms will work. `use_transactional_tests` will check to see if `use_transactional_fixtures` is set and use that, otherwise it will use itself. But because `use_transactional_tests` is a class attribute (created with `class_attribute`) this requires a little bit of hoop jumping. The writer method that `class_attribute` generates defines a new reader method that return the value being set. Which means we can’t set the default of `true` using `use_transactional_tests=` as was done previously because that won’t take into account anyone using `use_transactional_fixtures`. Instead I defined the reader method manually and it checks `use_transactional_fixtures`. If it was set then it should be used, otherwise it should return the default, which is `true`. If someone uses `use_transactional_tests=` then it will overwrite the backwards-compatible method with whatever they set.
* Cleaning JavaScriptHelperTestThiago Pradi2015-03-141-8/+1
|
* Cleaning unused views from actionpack tests inside actionviewThiago Pradi2015-03-141-1/+0
|
* Zlib isn't required for AssetTagHelperTest anymoreThiago Pradi2015-03-141-1/+0
|
* Cleaning unused methods from abstract_unitThiago Pradi2015-03-141-57/+0
|
* Deleting unused fixturesThiago Pradi2015-03-142-10/+0
|
* Let strip_tags leave HTML escaping to Rails.Kasper Timm Hansen2015-03-101-0/+4
| | | | Prevents double escaping errors, such as "&amp;" becoming "&amp;amp;".
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-27 11:03:09 +0000