aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/test
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge pull request #30513 from y-yagi/fix_30444Akira Matsuda2017-10-251-1/+3
|\ \ | | | | | | Does not include disabled element in params
| * | Does not include disabled element in paramsyuuji.yaginuma2017-09-031-1/+3
| |/ | | | | | | | | | | | | In the case of remote, it should be the same behavior as submitting HTML form. Fixes #30444
* | Remove deprecated Erubis ERB handlerRafael Mendonça França2017-10-231-15/+0
| |
* | Merge pull request #29127 from DmytroVasin/rails-ujs-remote-callbacksGuillermo Iguaran2017-10-191-63/+29
|\ \ | | | | | | Fix callback in rails ujs
| * | Fix callback in rails ujsVasin Dmitriy2017-06-071-63/+29
| | |
* | | Remove unused `FixtureTemplate` classyuuji.yaginuma2017-10-191-11/+0
| | | | | | | | | | | | `FixtureTemplate` is no longer used since 3d7892d.
* | | Implement H2 Early Hints for Railseileencodes2017-10-042-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When puma/puma#1403 is merged Puma will support the Early Hints status code for sending assets before a request has finished. While the Early Hints spec is still in draft, this PR prepares Rails to allowing this status code. If the proxy server supports Early Hints, it will send H2 pushes to the client. This PR adds a method for setting Early Hints Link headers via Rails, and also automatically sends Early Hints if supported from the `stylesheet_link_tag` and the `javascript_include_tag`. Once puma supports Early Hints the `--early-hints` argument can be passed to the server to enable this or set in the puma config with `early_hints(true)`. Note that for Early Hints to work in the browser the requirements are 1) a proxy that can handle H2, and 2) HTTPS. To start the server with Early Hints enabled pass `--early-hints` to `rails s`. This has been verified to work with h2o, Puma, and Rails with Chrome. The commit adds a new option to the rails server to enable early hints for Puma. Early Hints spec: https://tools.ietf.org/html/draft-ietf-httpbis-early-hints-04 [Eileen M. Uchitelle, Aaron Patterson]
* | | Add test case for `font_url`yuuji.yaginuma2017-10-031-0/+26
| | | | | | | | | | | | Since test of `font_url` was not in Action View's test suite, so it added.
* | | Remove unused methods from `RenderPartialWithRecordIdentificationController`yuuji.yaginuma2017-09-301-10/+0
| | | | | | | | | | | | These methods no longer used since a3da293.
* | | Include `ActionDispatch::DrawOnce` in `ActiveSupport::TestCase`Ryuta Kamizono2017-09-271-1/+1
| | | | | | | | | | | | It is also used in `BlockTestCase`.
* | | Remove unused code that was copied from actionpackRyuta Kamizono2017-09-271-52/+1
| | | | | | | | | | | | | | | `abstract_unit.rb` in actionview was copied from actionpack in the commit eb23754e. But some part is never used for actionview's tests.
* | | Fix `test_should_sanitize_illegal_style_properties` failureRyuta Kamizono2017-09-251-2/+2
| |/ |/| | | | | | | | | | | | | | | https://travis-ci.org/rails/rails/jobs/279300966#L2600 The result of `Loofah::HTML5::Scrub.scrub_css` was changed since v2.1.0.rc1. https://github.com/flavorjones/loofah/commit/ca56295ff9e802018ea18d23ed49be235a95ccad
* | Merge pull request #30392 from koic/unify_source_control_keep_file_nameMatthew Draper2017-08-311-0/+0
|\ \ | | | | | | Unify the internal source control .keep file name
| * | Unify the internal source control .keep file nameKoichi ITO2017-08-241-0/+0
| | |
* | | Make sure image_alt is deprecatedRafael Mendonça França2017-08-231-5/+15
| | |
* | | Remove alt generation from image_submit_tagRafael Mendonça França2017-08-231-1/+1
| | |
* | | Merge pull request #30213 from ckundo/ccundiff-alt-text-defaultRafael Mendonça França2017-08-231-16/+16
|\ \ \ | |/ / |/| | | | | Do not generate default alt text for images
| * | Do not generate default alt text in image tagsCameron Cundiff2017-08-171-16/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Auto-generating content from the filename of an image is not suitable alternative text; alt text that isn't fully considered can be distracting and fatiguing for screen readers users (blind, low vision, dyslexic people). - Setting a filename fallback short circuits screen reader default behavior and configuration for blank descriptions. - Setting poor defaults also creates false negatives for accessibility linting and testing software, that makes it harder to improve application accessibility. *** - After this change, if authors leave images without alt text, screen readers will fallback to default behavior for missing alt text. - Also with this change, Automated linting and testing tools will correctly generate warnings. [Fixes #30096]
* | | Use ssl in guide and comment [ci skip]Yoshiyuki Hirano2017-08-191-1/+1
|/ /
* | Fix RuboCop offensesKoichi ITO2017-08-167-69/+69
| | | | | | | | And enable `context_dependent` of Style/BracesAroundHashParameters cop.
* | Extend image_tag to accept ActiveStorage Attachments and Variants (#30084)Anton Khamets2017-08-071-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Extend image_tag to accept ActiveStorage's Attachments and Variants * Flip resolve_image_source around * Add tests for the new use-cases of image_tag * Remove the higher-level test * Update image_tag documentation * Add error states into the test suite * Re-raise polymorhic_url's NoMethodError as ArgumentError * delegate_missing_to will raise DelegationError instead of NoMethodError
* | Merge pull request #30020 from rails/active-storage-importDavid Heinemeier Hansson2017-08-042-0/+68
|\ \ | | | | | | Add Active Storage to Rails
| * | Refactor convert_direct_upload_option_to_urlRafael Mendonça França2017-08-031-0/+31
| | | | | | | | | | | | Also make sure file_field doesn't mutate the original options passed in.
| * | Make sure Action View doesn't break with Active StorageRafael Mendonça França2017-08-031-0/+37
| | | | | | | | | | | | | | | When Active Storage is not loaded and direct_upload is used on file_field_tag we should not raise an exception.
* | | Allow non-English values for collection_radio_buttons/check_boxescolorfulfool2017-08-021-0/+14
|/ /
* | Merge pull request #30001 from y-yagi/fix_test_directoryKasper Timm Hansen2017-07-302-2/+2
|\ \ | | | | | | Fix test directory to correct path
| * | Fix test directory to correct pathyuuji.yaginuma2017-07-302-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Together, fix to the following lint violation. ``` rails/actionview/test/ujs/public/test/data-confirm.js 303:11 error Strings must use singlequote quotes rails/actionview/test/ujs/public/test/data-remote.js 414:32 error Extra semicolon semi ✖ 2 problems (2 errors, 0 warnings) ```
* | | Fix testing helpers that use Action View's capturing helpers (e.g. content_for)George Claghorn2017-07-251-0/+8
|/ /
* | Merge pull request #29897 from kirs/frozen-actionviewRafael França2017-07-2474-0/+147
|\ \ | | | | | | Use frozen string literal in actionview/
| * | Use frozen string literal in actionview/Kir Shatrov2017-07-2474-0/+147
| | |
* | | Merge pull request #29792 from lugray/delegate_respond_toRafael França2017-07-241-0/+11
|\ \ \ | |/ / |/| | Delegate respond_to? in ActionView::Helpers::ControllerHelper
| * | Delegate respond_to? in ActionView::Helpers::ControllerHelperLisa Ugray2017-07-191-0/+11
| | | | | | | | | | | | | | | | | | Since methods defined in the controller helper are mostly delegated to the controller, delegate respond_to? as well, so that for example `respond_to?(:params)` behaves as expected.
* | | Add jQuery to test vendor filesMarc Rendl Ignacio2017-07-202-1/+9832
|/ / | | | | | | | | ... so that we can run most, if not all, of rails-ujs tests without necessarily requiring an internet connection.
* | Enable `Layout/FirstParameterIndentation` copRyuta Kamizono2017-07-172-24/+24
| | | | | | | | | | | | | | We have some indentation cops. But now there is a little inconsistent params indentations. Enable `Layout/FirstParameterIndentation` cop to prevent newly inconsistent indentation added and auto-correct to existing violations.
* | [Action View] `rubocop -a --only Layout/EmptyLineAfterMagicComment`Koichi ITO2017-07-111-0/+1
| |
* | Expectation firstAkira Matsuda2017-07-022-8/+8
| |
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-0286-86/+0
| | | | | | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* | Merge pull request #29540 from kirs/rubocop-frozen-stringMatthew Draper2017-07-0286-0/+86
|\ \ | | | | | | | | | Enforce frozen string in Rubocop
| * | Enforce frozen string in RubocopKir Shatrov2017-07-0186-0/+86
| | |
* | | Merge pull request #29506 from pat/frozen-string-literalsMatthew Draper2017-07-0213-212/+212
|\ \ \ | | | | | | | | | | | | Make ActiveSupport frozen-string-literal friendly.
| * | | Make ActionView frozen string literal friendly.Pat Allan2017-06-2013-212/+212
| | | | | | | | | | | | | | | | Plus a couple of related ActionPack patches.
* | | | Merge pull request #29349 from robertomiranda/responsive-imagesMatthew Draper2017-07-021-1/+4
|\ \ \ \ | | | | | | | | | | | | | | | Add srcset option to image_tag helper
| * | | | Add `srcset` option to `image_tag` helperRoberto Miranda2017-06-291-1/+4
| | |/ / | |/| |
* / | | Fallback Parameters#to_s to Hash#to_sKir Shatrov2017-06-301-0/+6
|/ / / | | | | | | Fixes https://github.com/rails/rails/issues/29617
* / / Fix current_page? helper issue with engine root pathsavroff2017-06-191-3/+13
|/ /
* | Generate field ids in `collection_check_boxes` and `collection_radio_buttons`yuuji.yaginuma2017-06-111-18/+18
| | | | | | | | | | This makes sure that the labels are linked up with the fields. Fixes #29014
* | Merge pull request https://github.com/rails/rails/pull/28637 from ↵Kasper Timm Hansen2017-06-082-23/+31
| | | | | | | | st0012/fix-partial-cache-logging
* | Use a hash to record every partial's cache hit status instead of sharing a ↵Stan Lo2017-06-084-0/+45
| | | | | | | | boolean.
* | Don't support namespace in form_with.Kasper Timm Hansen2017-06-071-18/+0
| | | | | | | | | | form_with requires people to pass an id manually, so users can just prefix their namespace right there.
* | Use mattr_accessor default: option throughout the projectGenadi Samokovarov2017-06-031-2/+1
|/
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-17 20:32:07 +0000