aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/test
Commit message (Collapse)AuthorAgeFilesLines
* Use the given name in html_options for the hidden field in ↵Angel N. Sciortino2013-09-241-0/+7
| | | | collection_check_boxes
* Fix some edge cases for AV `select` helper with `:selected` optionBogdan Gusiev2013-09-231-0/+16
|
* Ability to pass block to AV#select helperBogdan Gusiev2013-09-231-0/+15
| | | | | | | | Example: = select(report, "campaign_ids") do - available_campaigns.each do |c| %option{:data => {:tags => c.tags.to_json}, :value => c.id}= c.name
* handle `:namespace` form option in collection labelsVasiliy Ermolovich2013-09-221-0/+36
|
* Merge pull request #12232 from claudiob/delete-unused-helper-fixturesSantiago Pastorino2013-09-204-16/+0
|\ | | | | Remove unused AV helper fixtures from e10a2531
| * Remove unused AV helper fixtures from e10a2531claudiob2013-09-144-16/+0
| | | | | | | | | | Several fixtures for helpers are removed. They were introduced in ActionView by @strzalek but never referenced in any test.
* | Bust the template digest cache key when details are changedDaniel Schierbeck2013-09-191-1/+29
| | | | | | | | | | | | Since the lookup details will influence which template is resolved, they need to be included in the cache key -- otherwise two different templates may erroneously share the same digest value.
* | There's no need to do thisSantiago Pastorino2013-09-171-4/+1
|/ | | | | | | AS does the following inside Time.find_zone! ... `ActiveSupport::TimeZone[time_zone] || TZInfo::Timezone.get(time_zone)` and given that the test is stubbing AS::TZ[] we don't need the removed code.
* "generates" applies to "collection radio" so it should be singularWaynn Lue2013-09-121-2/+2
| | | I accidentally pushed this change to docrails before realizing that it's technically a code change, so I'm opening this pull request (and rolling back my change to docrails).
* Merge pull request #12112 from adamniedzielski/fix-form-for-namespace-and-asRafael Mendonça França2013-09-121-0/+12
|\ | | | | | | | | | | | | form_for - fix :namespace and :as options clash Conflicts: actionview/CHANGELOG.md
| * form_for - fix :namespace and :as options clashAdam Niedzielski2013-09-091-0/+12
| | | | | | | | | | | | | | | | :as option should not overwrite :namespace option when generating html id attribute of the form element. id should be prefixed by specified namespace even if :as option is present Add test case showing the issue and code fixing it
* | Merge pull request #11603 from ↵Rafael Mendonça França2013-09-121-0/+3
|\ \ | | | | | | | | | | | | | | | jetthoughts/join_strings_instead_of_contactination Cleanup: replace String concatenation by joining for excerpt helper
| * | Cleanup of excerpt helperPaul Nikitochkin2013-09-061-0/+3
| |/ | | | | | | | | * replaced String concatenation by joining * separator has default value to '', even it is nil
* / Remove helper fixtures not used in any testclaudiob2013-09-091-2/+0
|/ | | | | | The fixture for module AbcHelper defines three functions bare_a, bare_b and bare_c, but only bare_a is used in the code that tests helper functions.
* Fix failure with minitest 5.0.7Carlos Antonio da Silva2013-09-061-0/+1
| | | | | | | | | | | | | Require minitest/mock in test where stub method is needed. Apparently this was being "imported" by minitest pride plugin, which previously required "minitest/autorun", that required "minitest/mock", making the method available by chance. It has been changed in minitest: https://github.com/seattlerb/minitest/commit/595ce955c0d89575726d10fc18d2afd8f334bcbe So we need to make sure we require what we really need where necessary.
* Merge pull request #12143 from rajcybage/fixing_typosCarlos Antonio da Silva2013-09-051-1/+1
|\ | | | | fix actionview and activemodel test cases typos
| * fix actionview and activemodel test cases typosRajarshi Das2013-09-051-1/+1
| |
* | Fix method name typosVipul A M2013-09-052-2/+2
|/
* Merge pull request #11768 from cloudspace/cache_template_loadingRafael Mendonça França2013-08-271-2/+11
|\ | | | | Only cache template digests if !config.cache_template_loading
| * Only cache template digests if config.cache_template_loadingJosh Lauer2013-08-061-2/+11
| | | | | | | | | | | | since ActionView::Resolver.caching is set to the same value as config.cache_template_loading only cache template digests if config.cache_template_loading is not falsy fixes issues #10752 and #10791
* | Move abstract's controller tests to AVŁukasz Strzałkowski2013-08-2521-0/+917
| | | | | | | | The ones that were actually testing AV functionality and should belong in there
* | Move actionpack's controller testsŁukasz Strzałkowski2013-08-253-11/+11
| |
* | Move AP's capture tests to AVŁukasz Strzałkowski2013-08-251-0/+81
| |
* | Move remaining layouts tests to AVŁukasz Strzałkowski2013-08-2517-0/+288
| |
* | Split rendering tests between AP & AVŁukasz Strzałkowski2013-08-251-248/+13
| | | | | | | | All rendering test remain in AV. Head, ETag etc. test stay in AP
* | Move render_test to AVŁukasz Strzałkowski2013-08-2592-0/+1722
| |
* | Do not load AV inside APŁukasz Strzałkowski2013-08-251-0/+1
| | | | | | | | Move that part to AV railtie
* | Don not require AC::CachingŁukasz Strzałkowski2013-08-251-1/+0
| |
* | Remove ApplicationController & RoutingTestHelpersŁukasz Strzałkowski2013-08-251-9/+0
| |
* | Remove unused ActionDispatch::RoutingVerbsŁukasz Strzałkowski2013-08-251-15/+1
| |
* | Remove unused in AV fixture-controllersŁukasz Strzałkowski2013-08-251-29/+0
| |
* | Load AV::Layouts dynamicly via railtiesŁukasz Strzałkowski2013-08-251-0/+2
| |
* | Fix AV tests, I18nProxy was moved to AVŁukasz Strzałkowski2013-08-251-1/+1
| |
* | Move view_paths from AP to AVŁukasz Strzałkowski2013-08-253-0/+176
| |
* | Remove privatizing of Fixnum#/ from assert_distance_of_time_in_wordsAlex Tambellini2013-08-051-5/+7
| | | | | | | | | | | | | | | | MRI reimplemented Date in C so it doesn't hit this division anymore while JRuby still uses the old stdlib implementation of Date so it will always hit this. With this change the actionview date_helper_test.rb tests should pass on JRuby.
* | Merge pull request #11743 from gaurish/tmp-magicGuillermo Iguaran2013-08-051-0/+0
|\ \ | |/ |/| [Jruby] Make all tests in ActionView::TemplateDigestorTest green
| * Add tmp dir in actionview/test/Gaurish Sharma2013-08-051-0/+0
| | | | | | | | | | | | | | | | Missing tmp directory will cause the test to fail on JRuby. will commit adds tmp directory & 22 TemplateDigestorTests which were failing before are now green. Further Discussion on this can be seen at #11743
* | Add "extname" option to javascript_include_tagNathan Stitt2013-08-031-0/+7
|/ | | | | | | | | | | | ActionView::Helpers.asset_path is where the logic for javascript_include_tag resides. It takes an extname option for specifying the extension or false to not append it. This exposes that option to javascript_include_tag. Without the option files that didn't end with ".js" would get the extension appended to them. This broke JST templates and other file types that should be interpreted as JavaScript but who's file extension isn't ".js"
* Make current_page? compare binary stringsRafael Mendonça França2013-08-011-0/+8
|
* Fix `current_page?` when the URL contains escaped charactersRafael Mendonça França2013-08-011-0/+13
| | | | | | | In some cases webservers like nginx send the escaped characters lowercased to the Rails application. The current_page? helper was comparing the escaped strings that are different since Ruby escapes the URL using uppercased characters.
* text_area should handle nil value option like text_fieldJoel Cogen2013-07-241-0/+7
|
* add support for html attributes to grouped_options_for_selectVasiliy Ermolovich2013-07-201-0/+10
|
* Fix test name typosVipul A M2013-07-191-2/+2
|
* Fix default rendered format problem when calling render method without ↵kennyj2013-07-151-0/+5
| | | | :content_type option. Closes #11393.
* Merge pull request #11348 from sanemat/fix/link-to-blockRafael Mendonça França2013-07-071-0/+7
|\ | | | | Fix actionview link_to with block and url_hash
| * Fix link_to with block and url_hashsanemat2013-07-071-0/+7
| | | | | | | | | | | | Use link_to with block and url_hash, expect block as name. But ignore block and use url_hash as name. 3-2-stable passes this test. 4-0-stable and master fail this.
* | Fix "Stack Level Too Deep" error when rendering recursive partialsRafael Mendonça França2013-07-073-0/+27
| | | | | | | | | | | | | | When rendering recursive partial Action View is trying to generate the view digest infinitly causing a stack level error. Fixes #11340
* | Added an `enforce_utf8` hash option for `form_tag` methodTakayuki Matsubara2013-07-071-1/+16
|/ | | | | | | | | | | | | | | | | | Control to output a hidden input tag with name `utf8` without monkey patching Before: form_tag # => '<form>..<input name="utf8" type="hidden" value="&#x2713;" />..</form>' After: form_tag # => '<form>..<input name="utf8" type="hidden" value="&#x2713;" />..</form>' form_tag({}, { :enforce_utf8 => false }) # => '<form>....</form>'
* Remove action view test duplicationsanemat2013-07-071-3/+0
| | | | Same test exists above 2 or 3 lines.
* Remove `FormBuilder` deprecation warning about block argument and associated ↵Vipul A M2013-07-021-12/+0
| | | | tests