aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/test
Commit message (Collapse)AuthorAgeFilesLines
...
* passing a nil should always raise an ArgumentErrorAaron Patterson2014-05-021-0/+25
|
* always pass options to the _url methodAaron Patterson2014-05-011-3/+13
|
* always use File.joinphoet2014-05-011-0/+8
|
* Merge pull request #13335 from glorieux/favicon_link_tag_mimetypeRafael Mendonça França2014-04-221-3/+3
|\ | | | | Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to image/x-icon.
| * Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to ↵glorieux2014-04-211-3/+3
| | | | | | | | | | | | | | | | image/x-icon. Although the official IANA-registered MIME type for ICO files is image/vnd.microsoft.icon, registered in 2003, it was submitted to IANA by a third party and is not recognized by Microsoft products. The MIME type image/x-icon should be used since is the one recognized by the major browsers on the market.
* | Add test for using ActionView::Helpers::FormHelper.label with block and htmlZachary Scott2014-04-221-0/+7
|/
* Remove wrapper div for inputs in button_toRafael Mendonça França2014-04-171-20/+20
| | | | Related with cbb917455f306cf5818644b162f22be09f77d4b2
* Merge pull request #14738 from tilsammans/pull/11407Rafael Mendonça França2014-04-173-12/+17
|\ | | | | | | | | | | | | Remove wrapping div with inline styles for hidden form fields. Conflicts: actionview/CHANGELOG.md
| * Remove wrapping div with inline styles for hidden form fields.Joost Baaij2014-04-143-12/+17
| | | | | | | | | | | | We are dropping HTML 4.01 and XHTML strict compliance since input tags directly inside a form are valid HTML5, and the absense of inline styles help in validating for Content Security Policy.
* | Use the index on hidden fieldRafael Mendonça França2014-04-141-1/+1
| |
* | `collection_check_boxes` respects `:index` option for the hidden filed name.Vasiliy Ermolovich2014-04-141-0/+7
|/ | | | closes #14147
* CollectionHelpers now accepts a readonly optionMauro George2014-04-121-0/+44
|
* Add test for selected and disabled custom attributes in options_for_selectLaura Paredes2014-03-311-1/+21
|
* Fix date_select option overwriting html classesIzumi Wong-Horiuchi2014-03-241-0/+16
| | | | | with_css_classes: true option overwrites other html classes. Concatenate day month and year classes rather than overwriting.
* Digestor should just rely on the finder to know about the format and the ↵David Heinemeier Hansson2014-03-211-10/+7
| | | | variant -- trying to pass it back in makes a mess of things (oh, and doesnt work)
* fix `number_to_percentage` with `Float::NAN`, `Float::INFINITY`.Yves Senn2014-03-171-0/+3
| | | | | | | Closes #14405. This is a follow-up to 9e997e9039435617b6a844158f5437e97f6bc107 to restore the documented behavior.
* Merge pull request #12662 from nashby/include-hidden-collectionRafael Mendonça França2014-03-151-0/+7
|\ | | | | | | | | | | | | | | add include_hidden option to collection_check_boxes helper Conflicts: actionview/CHANGELOG.md actionview/test/template/form_collections_helper_test.rb
| * add include_hidden option to collection_check_boxes helperVasiliy Ermolovich2013-10-271-0/+7
| |
* | Clarify AV::Digestor.digest method signature docs and deprecation warningJeremy Kemper2014-03-151-2/+2
| |
* | Fix the resolver cache and stop mutating the lookup_contextRafael Mendonça França2014-03-142-21/+0
| | | | | | | | | | Before we had a bug in the resolver cache so the disable_cache were not working when passing options to find
* | Introduce #with_formats_and_variants to prevent problems with mutating ↵Łukasz Strzałkowski2014-03-142-0/+21
| | | | | | | | finder object
* | Add mocked disable_cache for FixtureFinderŁukasz Strzałkowski2014-03-141-0/+4
| |
* | Set format in finderŁukasz Strzałkowski2014-03-141-3/+8
| |
* | Ensure LookupContext in Digestor selects correct variantPiotr Chmolowski2014-03-094-3/+21
| | | | | | | | | | | | | | | | | | | | Related to: #14242 #14243 14293 Variants passed to LookupContext#find() seem to be ignored, so I've used the setter instead: `finder.variants = [ variant ]`. I've also added some more test cases for variants. Hopefully this time passing tests will mean it actually works.
* | Variants in ActionView::DigestorPiotr Chmolowski2014-03-042-8/+42
| | | | | | | | | | | | | | | | | | | | | | Take variants into account when calculating template digests in ActionView::Digest. Digestor#digest now takes a hash as an argument to support variants and allow more flexibility in the future. Old-style arguments have been deprecated. Fixes #14242
* | fixes default attributes for button_tagSergey Prikhodko2014-03-031-0/+5
| |
* | refactor, with_locale is not needed because I18n is mocked.Yves Senn2014-02-241-7/+5
| | | | | | | | | | This is a follow up to #14170. While backporting I recognized that this call is not needed at all.
* | Fix ActionView label translation for more than 10 nested elementsVladimir Krylov2014-02-241-0/+14
| |
* | refactor, extract `with_locale` helper.Yves Senn2014-02-241-87/+79
| |
* | Use the reference for the mime type to get the formatRafael Mendonça França2014-02-182-0/+34
| | | | | | | | | | | | | | | | Before we were calling to_sym in the mime type, even when it is unknown what can cause denial of service since symbols are not removed by the garbage collector. Fixes: CVE-2014-0082
* | Merge branch '4-1-0-beta2'Rafael Mendonça França2014-02-181-0/+39
|\ \ | | | | | | | | | | | | | | | Conflicts: actionview/CHANGELOG.md activerecord/CHANGELOG.md
| * | Escape format, negative_format and units options of number helpersRafael Mendonça França2014-02-181-0/+39
| | | | | | | | | | | | | | | | | | | | | Previously the values of these options were trusted leading to potential XSS vulnerabilities. Fixes: CVE-2014-0081
* | | Fix a fragile test on `action_view/render`Prem Sichanugrist2014-02-181-1/+1
| | | | | | | | | | | | | | | | | | This test were assuming that the list of render options will always be the same. Fixing that so this doesn't break when we add/remove render option in the future.
* | | implements new option :month_format_string for date select helpers [Closes ↵Xavier Noria2014-02-151-0/+10
| | | | | | | | | | | | #13618]
* | | Added tests to render helper that expect `render partial: @foo` toIain Beeston2014-02-122-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | automatically call @foo.to_partial_path Calling `render @foo` allows local variables but not options to be passed to the partial renderer. The correct way to render an object AND pass options to the partial renderer is to pass the object in the `:partial` parameter. However, there were previously no tests for this behaviour (in `render_helper_test.rb` at least).
* | | Adding an documentation example and a test to button_to with pathAttila Domokos2014-02-021-0/+7
| | | | | | | | | I did not see in the docs that `button_to` supports not only URLs but paths as well. I documented this functionality with a unit tests and added an example to the docs as well.
* | | Rails config for raise on missing translationsKassio Borges2014-01-271-0/+10
| | | | | | | | | | | | | | | Add a config to setup whether raise exception for missing translation or not.
* | | Merge pull request #13414 from britto/jb-fix-dependency-matchingRafael Mendonça França2014-01-161-4/+110
|\ \ \ | | | | | | | | Improve ERB dependency detection
| * | | Avoid scanning multiple render calls as a single match.João Britto2014-01-091-4/+26
| | | | | | | | | | | | | | | | Each chunk of text coming after `render` is now handled individually as a possible list of arguments.
| * | | Improve ERB dependency detection.João Britto2014-01-091-4/+88
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current implementation can't handle some special cases of oddly-formatted Ruby. Now we are able to detect them: * Multi-line arguments on the `render` call * Strings containing quotes, e.g. `"something's wrong"` * Multiple kinds of identifiers - instance variables, class variables and globals * Method chains as arguments for the `render` call Also, this fix reduces the rate of "false positives" which showed up when we had calls/access to identifiers containing `render`, like `surrender` and `rendering`.
* | | | "serie" => "series"Waynn Lue2014-01-131-2/+2
| | | |
* | | | standardize on jruby_skip & rbx_skipGaurish Sharma2014-01-131-0/+8
|/ / / | | | | | | | | | | | | | | | This Adds helpers(jruby_skip & rbx_skip). In Future, Plan is to use these helpers instead of calls directly to RUBY_ENGINE/RbConfig/JRUBY_VERSION
* | | Switched to use `display:none` in extra_tags_for_form method.Gaelian Ditchburn2014-01-053-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The use of `display:inline` with the content_tag call in the extra_tags_for_form method potentially causes display issues with some browsers, namely Internet Explorer. IE's behaviour of not collapsing the line height on divs with ostensibly no content means that the automatically added div containing the hidden authenticity_token, utf8 and _method form input tags may interfere with other visible form elements in certain circumstances. The use of `display:none` rather than `display:inline` fixes this problem. Fixes #6403
* | | Unused class in AV testAkira Matsuda2013-12-251-2/+0
| | |
* | | Unused classes in AV testsAkira Matsuda2013-12-243-18/+0
| | |
* | | Prefer assert_raise instead of flunk + rescue to test for exceptionsCarlos Antonio da Silva2013-12-192-6/+6
| | | | | | | | | | | | | | | | | | Change most tests to make use of assert_raise returning the raised exception rather than relying on a combination of flunk + rescue to check for exception types/messages.
* | | Merge pull request #13363 from kuldeepaggarwal/f-video-optionsGuillermo Iguaran2013-12-171-1/+1
|\ \ \ | |/ / |/| | allow video_tag to accept `size` as `Number` for square shaped videos
| * | allow video_tag to accept `size` as `Number` for square shaped videosKuldeep Aggarwal2013-12-181-1/+1
| | |
* | | Fix integration test to pass same-origin verificationJeremy Kemper2013-12-171-1/+1
|/ /
* | Disable available locales checks to avoid warnings running the testsCarlos Antonio da Silva2013-12-171-0/+3
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 10:01:17 +0000