aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/CHANGELOG.md
Commit message (Collapse)AuthorAgeFilesLines
* Fix field_error_proc wrap form select optgroup and divider option tagneumayr2017-11-091-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | ### Summary The [`:field_error_proc`](https://github.com/rails/rails/blob/master/actionview/lib/action_view/base.rb#L145) is responsible for decorating input tags that refer to attributes with errors. This default build-in rails feature wrap invalid form elements with additional markup: `<div class="field_with_errors">[…]</div>`. * Fix for `field_error_proc` wraps form select `optgroup` * Fix for `field_error_proc` wraps form select divider `option` * Add tests for uncovered elements with errors [Fixes #31088] #### Test coverage * `test_select_grouped_options_with_errors` * `test_time_zone_select_with_priority_zones_and_errors` #### Extend test coverage * `test_collection_select_with_errors` * `test_label_with_errors` * `test_check_box_with_errors` * `test_check_boxes_with_errors` * `test_radio_button_with_errors` * `test_radio_buttons_with_errors` * `test_collection_check_boxes_with_errors` * `test_collection_radio_buttons_with_errors`
* Remove deprecated Erubis ERB handlerRafael Mendonça França2017-10-231-0/+4
|
* Do not generate default alt text in image tagsCameron Cundiff2017-08-171-0/+6
| | | | | | | | | | | | | | | | | | | | | - Auto-generating content from the filename of an image is not suitable alternative text; alt text that isn't fully considered can be distracting and fatiguing for screen readers users (blind, low vision, dyslexic people). - Setting a filename fallback short circuits screen reader default behavior and configuration for blank descriptions. - Setting poor defaults also creates false negatives for accessibility linting and testing software, that makes it harder to improve application accessibility. *** - After this change, if authors leave images without alt text, screen readers will fallback to default behavior for missing alt text. - Also with this change, Automated linting and testing tools will correctly generate warnings. [Fixes #30096]
* Merge pull request #29349 from robertomiranda/responsive-imagesMatthew Draper2017-07-021-0/+4
|\ | | | | | | Add srcset option to image_tag helper
| * Add `srcset` option to `image_tag` helperRoberto Miranda2017-06-291-0/+4
|/
* :scissors:Ryuta Kamizono2017-06-281-4/+4
| | | | [ci skip]
* Add changes to CHANGELOGsavroff2017-06-191-0/+6
| | | | | | fix fix
* Generate field ids in `collection_check_boxes` and `collection_radio_buttons`yuuji.yaginuma2017-06-111-0/+8
| | | | | This makes sure that the labels are linked up with the fields. Fixes #29014
* Add :json type to auto_discovery_link_tagMike Gunderloy2017-05-201-0/+4
| | | | | This allows auto_discovery_link_tag to support the JSON Feed standard. See https://jsonfeed.org/version/1 for more information.
* Cleanup CHANGELOGs [ci skip]Ryuta Kamizono2017-04-301-1/+2
| | | | | | * Remove trailing spaces. * Add backticks around method and command. * Fix indentation.
* Ensure input to distance_of_time_in_words is not nilJay Hayes2017-04-271-0/+5
| | | | | | | | | | | | | | | | * Internally all input is converted to time so that it can be treated uniformly. Remove now-unneeded condition * Now that all input is treated is converted to time, we no longer need to type check it. Rename variables to clarify their purpose Extract private method to normalize distance_of_time args to time Update actionview changelog
* Start Rails 5.2 developmentMatthew Draper2017-03-221-216/+1
|
* Merge pull request #28407 from claudiob/changelog-skip-pipelineRichard Schneeman2017-03-131-0/+17
|\ | | | | Add CHANGELOG for #26226 [ci skip]
| * Add CHANGELOG for #26226 [ci skip]claudiob2017-03-131-0/+17
| |
* | Small grammar change + new line for "fixes"Jon Moss2017-03-131-2/+4
|/ | | | [ci skip]
* Remove `encode_special_chars` option from `strip_tags`Andrew Hood2017-02-271-0/+7
|
* Preparing for 5.1.0.beta1 releaseRafael Mendonça França2017-02-231-0/+2
|
* Change ActionView ERB Handler from Erubis to ErubiJeremy Evans2017-01-251-0/+14
| | | | | | | | | | | | | | | | | | | | | | | Erubi offers the following advantages for Rails: * Works with ruby's --enable-frozen-string-literal option * Has 88% smaller memory footprint * Does no freedom patching (Erubis adds a method to Kernel) * Has simpler internals (1 file, <150 lines of code) * Has an open development model (Erubis doesn't have a public source control repository or bug tracker) * Is not dead (Erubis hasn't been updated since 2011) Erubi is a simplified fork of Erubis that contains just the parts that are generally needed (which includes the parts that Rails uses). The only intentional difference in behavior is that it does not include support for <%=== tags for debug output. That could be added to the ActionView ERB handler if it is desired. The Erubis template handler remains in a deprecated state so that code that accesses it directly does not break. It can be removed after Rails 5.1.
* Allow render locals to be assigned to instance variablesAndrew White2017-01-151-0/+6
| | | | | | | | | In #26672 we blocked use of Ruby keywords as identifiers for view locals but inadvertently broke the use of instance variable names as identifiers. Whilst not explicitly documented this behavior has been around for a long time and there's no need to break it now. Fixes #27480.
* Add `check_parameters` option to `current_page?`Maksym Pugach2017-01-041-0/+4
| | | | | | | | | | | | | | | Example: For "http://www.example.com/shop/checkout?order=desc&page=1" current_page?('http://www.example.com/shop/checkout') => true current_page?( 'http://www.example.com/shop/checkout', check_parameters: true ) => false
* do not mutate `object_name` of class in `fields_for`yuuji.yaginuma2016-12-271-0/+6
| | | | | | Since it affects the entire form, should not mutate `object_name` of class. Fixes #26931
* Fixed usage of cache_template_loadingMax Melentiev2016-12-061-0/+8
| | | | It disables recompilation of templates on every request in test env.
* [ci skip] Mention `form_with` and `fields` in changelog.Kasper Timm Hansen2016-11-211-0/+30
| | | | Implemented in 67f81cc.
* Changelog editsVipul A M2016-11-121-3/+3
|
* Removed deprecated `#original_exception` in `ActionView::Template::Error`.Rafael Mendonça França2016-10-101-0/+4
|
* Change render to support any hash keys in localsPeter Schilling2016-10-021-0/+18
| | | | | | | | | | | | | | | | | | | this lets you pass ruby keywords to templates: <%= render 'example', class: "cool" %> <%= render 'example', "spaces are" => "a-ok" %> <%= render 'example', Foo: "bar" %> Previously you'd see confusing syntax errors like this: SyntaxError (.../_example.html.erb:1: syntax error, unexpected '=' Now you can reference invalid identifiers through local_assigns. If you try to use an invalid keyword (e.g. class) in your template, you get a syntax error on the line where you use it.
* Pass over changelogs [ci skip]Vipul A M2016-08-101-1/+1
|
* Move CHANGELOG entry to the top.Kasper Timm Hansen2016-08-071-11/+11
|
* Modify LogSubscriber for single partial's cache message.Stan Lo2016-08-081-0/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement naive partial caching mechanism. Add test for LogSubscriber Use ActionView::Base#log_payload to store log_subscriber's payload, so we can pass cache result into it. Fixed tests Remove useless settings Check if #log_payload exists before calling it. Because other classes also includes CacheHelper but don't have is attribute Use @log_payload_for_partial_reder instead of #log_payload to carry ActionView's payload. Update test's hash syntax Add configuration to enable/disable fragment caching logging Remove unless test and add new test to ensure cache info won't effect next rendering's log Move :enable_fragment_cache_logging config from ActionView to ActionPack Apply new config to tests Update actionview's changelog Update configuration guide Improve actionview's changelog Refactor PartialRenderer#render and log tests Mute subscriber's log instead of disabling instrumentation. Fix typo, remove useless comment and use new hash syntax Improve actionpack's log_subscriber test Fix rebase mistake Apply new config to all caching intstrument actions
* Use to_a to pre-buffer the collectionSteven Harman2016-07-261-5/+5
| | | | | | | | We can safely assume we're not dealing with an infinite collection as we're about to call `each` on it and collect the results until it terminates on its own. Given that, `to_a` is implemented by the normal Array-like objects, and less Array-like objects like `Enumerator` and `Enumerator::Lazy`.
* Fix collection_from_options to allow EnumeratorsSteven Harman2016-07-261-0/+11
| | | | | | | | | | | | | An optimization was introduced in https://github.com/rails/rails/commit/27f4ffd11a91b534fde9b484cb7c4e515ec0fe77 which tried to `#to_ary` the collection to prevent unnecessary queries for ActiveRecord scopes/relations. If the given collection did not respond to `#to_ary`, and empty collection was returned. That meant you couldn't use collections built from `Enumerator` nor `Enumerable`. With this change, `#collection_from_options` will attempt the optimization, but fall back to passing along the given collection, as-is.
* New syntax for tag helpers i.e. tag.br instead of tag(br) #25195Marek2016-06-271-0/+25
|
* English fixGeorge Millo2016-06-231-1/+1
| | | --skip-ci
* Merge pull request #25469 from ↵Rafael Mendonça França2016-06-221-0/+8
|\ | | | | | | | | | | herminiotorres/update-datetime-to-datetime-local-by-html-specification Change datetime to datetime-local helper tag
| * Change datetime to datetime-local helper tagHerminio Torres2016-06-211-0/+8
|/ | | | | | | | | | | A change was made in the helper that renders the `datetime`, being now by default `datetime-local` and creating an alias of `datetime-local` for `datetime`, `datetime` tag and it passes to be an abstract class for all other tags that inherit from him. As a new specification of the HTML 5 the text field type `datetime` will no longer exist and will pass a `datetime-local`. Ref: https://html.spec.whatwg.org/multipage/forms.html#local-date-and-time-state-(type=datetime-local)
* Change the raw template handler to render html-safe stringseileencodes2016-06-211-0/+11
| | | | | | | | | | | | | | | In PR #24929 the changelog was updated to make note that while the new template handler was changed to raw this changed the behavior when outputting plain html or js files. Previously ERB would output the files unescaped. Changing the default handler to RAW meant that these same files would be rendered as escaped rather than as js or html. Because of this change in behavior and after the discussion #24949 in we decided to change the behavior of the Raw handler to output html_safe strings by default. Now files rendered with the default handler (raw) render the file unescaped.
* Remove space, properly italicizeJon Moss2016-05-211-5/+5
| | | | | | Difference in rendering --> https://gist.github.com/maclover7/a50ff9231eb825c39c77cd5858af6d9a [ci skip]
* Confirm with the specification when generating emtpy option for select with ↵Vipul A M2016-05-211-0/+17
| | | | | | | | | | | | `include_blank: true` option. We now generate option with empty label, example: `<select id="places" name="places"><option value="" label=" "></option></select>` for include_blank: true. This is only done, if content is missing on the option, and we providing the value from this option. Fixes #24816
* Start Rails 5.1 development :tada:Rafael Mendonça França2016-05-101-342/+1
|
* Improve AV changelog with regards to default RAW handlerRodrigo Rosenfeld Rosas2016-05-091-1/+18
| | | | It highlights which kind of incompatibilities this could lead to when rendering plain JS or HTML partials.
* Preparing for 5.0.0.rc1 releaseRafael Mendonça França2016-05-061-1/+6
|
* Prep Rails 5 beta 4eileencodes2016-04-271-0/+2
|
* Merge pull request #24225 from ↵Rafael Mendonça França2016-04-201-0/+16
|\ | | | | | | | | | | neumayr/date_select_helper_with_css_classes_accept_hash date_select helper with_css_classes option also accept a hash
| * date_select helper with_css_classes option also accept a hashneumayr2016-04-051-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `date_select` helper `:with_css_classes` option now accepts a hash of strings for `:year`, `:month`, `:day`, `:hour`, `:minute`, `:second` that will extend the select type with the given css class value. ```erb <%= f.date_select :birthday, with_css_classes: { month: "my-month", year: "my-year" } %> ``` ```html <select id="user_birthday_3i" name="user[birthday(3i)]">…</select> <select id="user_birthday_2i" name="user[birthday(2i)]" class="my-month">…</select> <select id="user_birthday_1i" name="user[birthday(1i)]" class="my-year">…</select> ``` Optional, add global `html_options` to modify every select tag in the set. ```erb <%= f.date_select :birthday, with_css_classes: { month: "my-month", year: "my-year" }, { class: "my-date optional" } %> ``` Supported DateHelper methods: `select_day`, `select_month`, `select_year`, `select_hour`, `select_minute`, `select_second`, `select_datetime`, `select_time`, `time_select`, `date_select` and `datetime_select`. `:with_css_classes` option was added to the `date_select` with #7975.
* | Add CHANGELOG entry for #23869Rafael Mendonça França2016-04-201-0/+4
|/ | | | [ci skip]
* Deprecate `datetime_field` and `datetime_field_tag` helpers.Wojciech Wnętrzak2016-03-311-0/+6
| | | | | Datetime input type was removed from HTML specification. One can use `datetime_local_field` and `datetime_local_field_tag` instead.
* guides, sync 5.0 release notes with changelogsYves Senn2016-03-221-1/+1
| | | | | | | | [ci skip] Sync AV, AR, AJ, AS, AM changelogs with our 5.0 release notes draft. This is a follow up to c94045d and contains changes made since the release of beta1.
* Fix CHANGELOG spacing [ci skip]Jeremy Daer2016-03-021-4/+4
|
* Add CHANGELOG entry for "Rendering ..." loggingPrem Sichanugrist2016-02-261-0/+6
|
* Preparing for 5.0.0.beta3 releaseeileencodes2016-02-241-0/+2
| | | | Adds changelog headers for beta3 release
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-10 18:17:08 +0000